Moved creating SiPixelTemplateStore from DB to an ESProducer

[Dr15Jones]

PR description:

All DB construction was switched to using EventSetup. Cases using reading from files were kept local to module.
The new ESProducer was added as a Task to all needed Sequences.

PR validation:

Code compiles. All changed python files are readable by python3. No cmsRun jobs were run.

[Dr15Jones]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42514/36519

• This PR adds an extra 68KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CalibTracker/SiPixelLorentzAngle/src/SiPixelLorentzAnglePCLWorker.cc modified in PR(s): From cmssw 12 4 11 patch3 #42461
  • File RecoLocalTracker/SiPixelRecHits/plugins/BuildFile.xml modified in PR(s): Porting Pixel Tracks to Alpaka [Not to Merge]  #41117, Pixel Alpaka Migration: Local Reconstruction [III] #41285

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• CalibTracker/SiPixelLorentzAngle (alca)
• CondFormats/SiPixelTransient (db, reconstruction)
• DQM/SiPixelPhase1Config (dqm)
• DQM/SiPixelPhase1Track (dqm)
• DQMOffline/Trigger (dqm)
• FastSimulation/TrackingRecHitProducer (fastsim)
• RecoLocalTracker/SiPixelRecHits (reconstruction)

@perrotta, @ssekmen, @tvami, @nothingface0, @civanch, @emanueleusai, @consuegs, @mdhildreth, @mandrenguyen, @pmandrik, @saumyaphor4252, @clacaputo, @syuvivida, @sbein, @tjavaid, @micsucmed, @francescobrivio, @rvenditti can you please review it and eventually sign? Thanks.
@VourMa, @felicepantaleo, @fioriNTU, @threus, @cericeci, @JanFSchulte, @jhgoh, @missirol, @HuguesBrun, @seemasharmafnal, @ferencek, @trocino, @rociovilar, @sroychow, @GiacomoSguazzoni, @rovere, @VinInn, @mroguljic, @tocheng, @jandrea, @idebruyn, @mmusich, @mtosi, @arossi83, @Fedespring, @dkotlins, @gpetruc, @matt-komm, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[Dr15Jones]

please test

[makortel]

I believe this should be

Suggested change

	#include "FWCore/Framework/interface/eventsetuprecord_registration_macro.h"
	#include "FWCore/Utilities/interface/typelookup.h"

which would then avoid adding the dependence on FWCore/Framework to this package.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42514/36520

• This PR adds an extra 76KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CalibTracker/SiPixelLorentzAngle/src/SiPixelLorentzAnglePCLWorker.cc modified in PR(s): From cmssw 12 4 11 patch3 #42461
  • File FastSimulation/Configuration/python/Reconstruction_BefMix_cff.py modified in PR(s): [RFC] Add updated but "off" FastSim pixel resolution histograms infrastructure #34812
  • File RecoLocalTracker/SiPixelRecHits/plugins/BuildFile.xml modified in PR(s): Porting Pixel Tracks to Alpaka [Not to Merge]  #41117, Pixel Alpaka Migration: Local Reconstruction [III] #41285

[tvami]

+db

[missirol]

@cms-sw/fastsim-l2 , could you please review this PR ?

There are upcoming HLT PRs that require this PR to be merged first (changes to customizeHLTforCMSSW.py, which is touched by this PR).

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[mmusich]

Is it worth backporting this (at least to 13.2.X)?

[Dr15Jones]

This appears to have broken some tests in the IB. I'm in the process of doing a fix.

[perrotta]

Is it worth backporting this (at least to 13.2.X)?

Let backport only what is necessary, and/or not too complicate (see also #42514 (comment))

[mmusich]

Let backport only what is necessary,

AFAIK this makes a sizeable performance improvement in DQM memory requirement, so that's why I am asking if we want to make use of this or not (e.g. for the HI data-taking or for a second take on the pp 2023 reprocessing?)

[Dr15Jones]

The fix for the unit test is in #42597

[makortel]

Is it worth backporting this (at least to 13.2.X)?

@cms-sw/ppd-l2 asked in the O&C today to backport this PR (+ #42597) down to 13_0_X.

[jordan-martins]

thanks @makortel ! Indeed, this will come in hand with the most likely rereco of the 2023 DATA to happen in 130X, in case it happens