Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] Add track-to-track monitoring of HLT GSF electron tracks with respect to offline #44917

Merged
merged 4 commits into from
May 10, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented May 7, 2024

backport of #44868

PR description:

Title says it all, supports track-to-track monitoring of HLT GSF electron tracks with respect to offline for both Run 3 (hltEgammaGsfTracks) and Phase 2 (hltEgammaGsfTracksL1Seeded).
In addition:

  • add regular GSF tracking monitoring at HLT also in Phase-2;
  • fix a bug in the vertex collection used for egmTrackingMonHLT

PR validation:

Run successfully both runTheMatrix.py -l 13034.0 -t 4 -j 8 (Run 3) and runTheMatrix.py -l 24834.0 -t 4 -j 8 (Phase 2) and observed the corresponding monitoring elements filled.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #44868 in CMSSW_14_0_X for data-taking purposes.

@mmusich
Copy link
Contributor Author

mmusich commented May 7, 2024

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2024

A new Pull Request was created by @mmusich for CMSSW_14_0_X.

It involves the following packages:

  • Configuration/EventContent (operations)
  • DQM/TrackingMonitorSource (dqm)
  • DQMOffline/Trigger (dqm)

@tjavaid, @davidlange6, @rappoccio, @rvenditti, @antoniovagnerini, @syuvivida, @cmsbuild, @antoniovilela, @fabiocos, @nothingface0 can you please review it and eventually sign? Thanks.
@missirol, @trocino, @threus, @VourMa, @fioriNTU, @sroychow, @HuguesBrun, @arossi83, @idebruyn, @jandrea, @cericeci, @mtosi, @JanFSchulte, @rociovilar, @mmusich, @jhgoh, @fabiocos, @Fedespring, @VinInn, @Martin-Grunewald this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented May 7, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2024

-1

Failed Tests: UnitTests RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a199d3/39277/summary.html
COMMIT: 03c2897
CMSSW: CMSSW_14_0_X_2024-05-07-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44917/39277/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

RelVals-INPUT

  • 2500.22500.2_NANOmc124Xrun3/step2_NANOmc124Xrun3.log

Comparison Summary

Summary:

  • You potentially added 17 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 139 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3432929
  • DQMHistoTests: Total failures: 2711
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3430198
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 120633.12000000001 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 12834.0,... ): 9634.955 KiB HLT/EGM
  • DQMHistoSizes: changed ( 23234.0,... ): 10470.565 KiB HLT/EGM
  • Checked 206 log files, 170 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented May 8, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a199d3/39292/summary.html
COMMIT: 03c2897
CMSSW: CMSSW_14_0_X_2024-05-07-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44917/39292/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 48 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 56 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3433921
  • DQMHistoTests: Total failures: 143
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3433758
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 120633.12000000001 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 12834.0,... ): 9634.955 KiB HLT/EGM
  • DQMHistoSizes: changed ( 23234.0,... ): 10470.565 KiB HLT/EGM
  • Checked 206 log files, 170 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented May 9, 2024

@cms-sw/dqm-l2 please take a look.

@tjavaid
Copy link

tjavaid commented May 10, 2024

+1

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 2fe7933 into cms-sw:CMSSW_14_0_X May 10, 2024
10 checks passed
@mmusich mmusich deleted the mm_dev_tkToTk_egamma_14_0_X branch May 10, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants