updated parameters and model for photon XGboost MVA (HLT) [14_1_X]

[smorovic]

PR description:

• Latest XGBoost model in cms-data added to the unit test. Requires: XGBoost Photon MVA files version 2 cms-data/RecoEgamma-PhotonIdentification#15
• Removed unused parameters and updating relevant parameters to the values intended for inclusion into the pp HLT menu.

PR validation:

Unit test added for the new model file.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44719/39920

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44719/39920/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44719/39920/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44719/39921

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @smorovic for master.

It involves the following packages:

• HLTrigger/Egamma (hlt)
• RecoEgamma/PhotonIdentification (reconstruction)

@mandrenguyen, @cmsbuild, @jfernan2, @mmusich, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@jainshilpi, @silviodonato, @afiqaize, @ram1123, @sameasy, @sobhatta, @lgray, @a-kapoor, @varuns23, @missirol, @valsdav, @Martin-Grunewald, @Sam-Harper, @Prasant1993 this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

[smorovic]

please test with cms-data/RecoEgamma-PhotonIdentification#15

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13e5b9/38798/summary.html
COMMIT: 3d38b0b
CMSSW: CMSSW_14_1_X_2024-04-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44719/38798/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @Duchstf Tau spring24 update #44349
• @fwyzard Use explicit acelerator types in alpaka tests #44676
• @hqucms Add orbitNumber to NanoAOD #44667
• @iarspider [CPP20] Remove references to deprecated std::is_pod #44651
• @iarspider [CPP20] Fix deprecated enum arithmetics in SiPixelAliPCLThresholdsPayloadInspectorHelper #44653
• @fwyzard Move EventSetup record dependency to non-device source file #44656
• @jsamudio Fix crash in PF Clustering due to empty HCAL RecHits collection #44693
• @fmanteca Removed pixelLayers requirement in MuonSelectors.cc #44692
• @makortel Workaround to produce exactly same data products in Serial and CUDA backends in Alpaka modules possibly used at HLT #44698
• @bhattlokesh2027 Cell offset and Cell area calculation of partial wafer cells for HGCAL V18 #43925
• @iarspider Phase2L1CaloJetEmulator: fix maybe-uninitialized warning #44633
• @brallmond Updated Tau Filterbits for 2024 Data Taking #44688

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13e5b9/38798/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13e5b9/38798/git-merge-result

Comparison Summary

Summary:

• You potentially added 111 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 107 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3316263
• DQMHistoTests: Total failures: 169
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3316074
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: found differences in 1 / 46 workflows

[mmusich]

test parameters:

• pull_request = XGBoost Photon MVA files version 2 cms-data/RecoEgamma-PhotonIdentification#15

[mmusich]

@cmsbuild, please test

• to get cleaner comparisons

[mmusich]

type egamma

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13e5b9/38809/summary.html
COMMIT: 3d38b0b
CMSSW: CMSSW_14_1_X_2024-04-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44719/38809/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 17 lines to the logs
• Reco comparison results: 45 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3316263
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3316243
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[mmusich]

+hlt

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-data/RecoEgamma-PhotonIdentification#15

[rappoccio]

+1