Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated parameters and model for photon XGboost MVA (HLT) [14_0_X (backport)] #44720

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

smorovic
Copy link
Contributor

PR description:

PR validation:

Unit test added for the new model file.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of:
#44719
Reason: integration into the next 14_0 release for the proton-proton HLT menu

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 12, 2024

A new Pull Request was created by @smorovic for CMSSW_14_0_X.

It involves the following packages:

  • HLTrigger/Egamma (hlt)
  • RecoEgamma/PhotonIdentification (reconstruction)

@jfernan2, @mmusich, @cmsbuild, @Martin-Grunewald, @mandrenguyen can you please review it and eventually sign? Thanks.
@ram1123, @lgray, @jainshilpi, @sobhatta, @valsdav, @missirol, @Prasant1993, @sameasy, @a-kapoor, @Sam-Harper, @varuns23, @Martin-Grunewald, @afiqaize, @silviodonato this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 12, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor

mmusich commented Apr 12, 2024

backport of #44719

@mmusich
Copy link
Contributor

mmusich commented Apr 12, 2024

type egamma

@mmusich
Copy link
Contributor

mmusich commented Apr 12, 2024

test parameters:

@mmusich
Copy link
Contributor

mmusich commented Apr 12, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49ae34/38813/summary.html
COMMIT: c2050de
CMSSW: CMSSW_14_0_X_2024-04-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44720/38813/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49ae34/38813/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49ae34/38813/git-merge-result

Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 51 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3308451
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3308425
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@mmusich
Copy link
Contributor

mmusich commented Apr 12, 2024

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-data/RecoEgamma-PhotonIdentification#15

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e3136cc into cms-sw:CMSSW_14_0_X Apr 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants