Add orbitNumber to NanoAOD

[hqucms]

PR description:

Add orbitNumber to NanoAOD as requested by ECAL for selecting BXs after calibration triggers.

PR validation:

Tested with runTheMatrix.py -l 2500 --ibeos.

[cmsbuild]

cms-bot internal usage

[hqucms]

enable nano

[hqucms]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44667/39868

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/NanoAOD/plugins/NanoAODOutputModule.cc modified in PR(s): [RFC] descriptions.addDefault -> descriptions.addWithDefaultLabel #44372

[cmsbuild]

A new Pull Request was created by @hqucms for master.

It involves the following packages:

• PhysicsTools/NanoAOD (xpog)

@hqucms, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: RelVals-INPUT RelVals-NANO
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f3aee/38702/summary.html
COMMIT: b67f6ee
CMSSW: CMSSW_14_1_X_2024-04-08-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44667/38702/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 2500.3232500.323_l1DPGNANO130Xrun3/step2_l1DPGNANO130Xrun3.log

RelVals-NANO

• 2500.3232500.323_l1DPGNANO130Xrun3/step2_l1DPGNANO130Xrun3.log

Comparison Summary

Summary:

• You potentially added 95 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 46 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3308887
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3308864
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[hqucms]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f3aee/38724/summary.html
COMMIT: b67f6ee
CMSSW: CMSSW_14_1_X_2024-04-09-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44667/38724/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 61 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 41 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3316263
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3316240
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

NANO Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 15
• DQMHistoTests: Total histograms compared: 16484
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 16484
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
• Checked 55 log files, 32 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.574	2.574	0.000 ( +0.0% )	4.60	4.62	-0.4%	2.161	2.172
2500.001	2.721	2.722	-0.000 ( -0.0% )	4.12	4.11	+0.4%	2.582	2.593
2500.002	2.667	2.667	0.000 ( +0.0% )	4.29	4.27	+0.5%	2.576	2.588
2500.01	1.320	1.318	0.002 ( +0.2% )	8.18	8.31	-1.5%	2.263	2.267
2500.011	1.741	1.739	0.003 ( +0.1% )	4.57	4.57	-0.1%	2.397	2.411
2500.012	1.583	1.580	0.002 ( +0.1% )	6.44	6.45	-0.1%	2.347	2.403
2500.1	2.218	2.218	0.000 ( +0.0% )	4.61	4.60	+0.4%	2.000	2.067
2500.2	2.333	2.333	0.000 ( +0.0% )	5.26	5.26	+0.1%	1.895	1.975
2500.21	1.185	1.182	0.002 ( +0.2% )	3.52	3.52	+0.1%	2.157	2.266
2500.211	1.548	1.546	0.002 ( +0.2% )	3.10	3.15	-1.7%	2.209	2.249
2500.3	2.089	2.089	0.000 ( +0.0% )	10.16	10.17	-0.1%	1.891	1.972
2500.301	2.667	2.667	0.000 ( +0.0% )	8.51	8.48	+0.4%	1.853	1.956
2500.31	7.164	7.159	0.004 ( +0.1% )	1.38	1.35	+1.9%	1.698	1.709
2500.311	1.568	1.564	0.004 ( +0.3% )	6.58	6.76	-2.8%	1.046	1.055
2500.312	540.457	540.453	0.004 ( +0.0% )	0.53	0.53	-0.2%	1.595	1.633
2500.313	817.694	817.689	0.004 ( +0.0% )	0.73	0.73	+0.2%	1.585	1.583
2500.32	1.258	1.256	0.002 ( +0.2% )	12.25	12.98	-5.6%	2.312	2.317
2500.321	1.645	1.643	0.002 ( +0.1% )	9.81	9.84	-0.3%	2.396	2.397
2500.322	1.165	1.163	0.002 ( +0.2% )	10.39	10.37	+0.2%	2.105	2.202
2500.323	7.772	7.768	0.004 ( +0.1% )	3.39	3.37	+0.7%	1.916	1.818
2500.324	1.761	1.759	0.002 ( +0.1% )	10.10	10.11	-0.0%	2.187	2.177
2500.325	4.146	4.144	0.002 ( +0.1% )	4.21	4.19	+0.4%	2.206	2.208
2500.326	3.097	3.095	0.002 ( +0.1% )	1.81	1.80	+0.5%	2.042	2.129
2500.327	1.793	1.791	0.002 ( +0.1% )	10.00	10.29	-2.8%	2.317	2.334
2500.4	2.246	2.245	0.000 ( +0.0% )	9.73	9.67	+0.7%	1.832	1.829
2500.401	1.778	1.778	0.000 ( +0.0% )	8.43	8.56	-1.5%	1.715	1.705
2500.402	2.795	2.795	0.000 ( +0.0% )	8.47	8.10	+4.5%	1.907	1.910
2500.403	8.752	8.752	0.000 ( +0.0% )	2.76	2.76	-0.3%	1.930	1.931
2500.404	5.105	5.105	0.000 ( +0.0% )	1.34	1.32	+1.1%	1.773	1.777
2500.405	2.803	2.803	0.000 ( +0.0% )	8.34	8.16	+2.2%	1.853	1.802
2500.5	5.194	5.192	0.003 ( +0.1% )	15.99	15.90	+0.6%	1.568	1.563
2500.51	9.120	9.119	0.001 ( +0.0% )	9.64	9.62	+0.2%	1.513	1.511

[hqucms]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1