Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move EventSetup record dependency to non-device source file #44656

Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Apr 8, 2024

PR description:

Move

#include "RecoParticleFlow/PFRecHitProducer/interface/PFRecHitTopologyRecord.h"

from a (device) header file to a (non-device) source file.

It should prevent TBB and EDM framework files to be compiled by the device compilers, like nvcc.

PR validation:

None.

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 8, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2024

cms-bot internal usage

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 8, 2024

type bugfix

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 8, 2024

fixes #44645

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44656/39855

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2024

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

  • RecoParticleFlow/PFClusterProducer (reconstruction)

@mandrenguyen, @jfernan2 can you please review it and eventually sign? Thanks.
@mmarionncern, @sameasy, @seemasharmafnal, @rovere, @felicepantaleo, @hatakeyamak, @missirol, @lgray this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-086972/38682/summary.html
COMMIT: b4b1ba8
CMSSW: CMSSW_14_1_X_2024-04-08-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44656/38682/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 9, 2024

type pf

@cmsbuild cmsbuild added the pf label Apr 9, 2024
@fwyzard
Copy link
Contributor Author

fwyzard commented Apr 9, 2024

@jsamudio FYI

@jfernan2
Copy link
Contributor

jfernan2 commented Apr 9, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants