-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move EventSetup record dependency to non-device source file #44656
Move EventSetup record dependency to non-device source file #44656
Conversation
please test |
cms-bot internal usage |
type bugfix |
fixes #44645 |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44656/39855
|
A new Pull Request was created by @fwyzard for master. It involves the following packages:
@mandrenguyen, @jfernan2 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-086972/38682/summary.html Comparison SummarySummary:
|
type pf |
@jsamudio FYI |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Move
from a (device) header file to a (non-device) source file.
It should prevent TBB and EDM framework files to be compiled by the device compilers, like
nvcc
.PR validation:
None.