Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include EventSetup record definitions in device code #44682

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

iarspider
Copy link
Contributor

PR description:

As suggested in #44645 (comment)

PR validation:

Bot tests. Compilation is expected to fail, but errors about missing intrinsics when compiling PFClusterSoAProducerKernel.dev.cc and PFRecHitProducerKernel.dev.cc should be gone.

@iarspider
Copy link
Contributor Author

please test for el9_amd64_gcc13

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 10, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44682/39880

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • RecoParticleFlow/PFRecHitProducer (reconstruction)

@mandrenguyen, @jfernan2 can you please review it and eventually sign? Thanks.
@hatakeyamak, @mmarionncern, @lgray, @missirol, @seemasharmafnal this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build HeaderConsistency
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-992de0/38727/summary.html
COMMIT: 7e5ff42
CMSSW: CMSSW_14_1_X_2024-04-05-2300/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44682/38727/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-992de0/38727/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-992de0/38727/git-merge-result

Build

I found compilation error when building:

Copying tmp/el9_amd64_gcc13/src/HeterogeneousTest/AlpakaWrapper/src/alpaka/HeterogeneousTestAlpakaWrapperCudaAsync/libHeterogeneousTestAlpakaWrapperCudaAsync_nv.a to productstore area:
Copying tmp/el9_amd64_gcc13/src/HeterogeneousTest/AlpakaWrapper/src/alpaka/HeterogeneousTestAlpakaWrapperROCmAsync/libHeterogeneousTestAlpakaWrapperROCmAsync_rocm.a to productstore area:
Copying tmp/el9_amd64_gcc13/src/RecoParticleFlow/PFRecHitProducer/plugins/RecoParticleFlowPFRecHitProducersPluginsPortableROCmAsync/libRecoParticleFlowPFRecHitProducersPluginsPortableROCmAsync_rocm.a to productstore area:
cp: cannot stat 'tmp/el9_amd64_gcc13/src/RecoParticleFlow/PFRecHitProducer/plugins/RecoParticleFlowPFRecHitProducersPluginsPortableROCmAsync/libRecoParticleFlowPFRecHitProducersPluginsPortableROCmAsync_rocm.a': No such file or directory
>> Deleted: tmp/el9_amd64_gcc13/src/RecoParticleFlow/PFRecHitProducer/plugins/RecoParticleFlowPFRecHitProducersPluginsPortableROCmAsync/libRecoParticleFlowPFRecHitProducersPluginsPortableROCmAsync_rocm.a
gmake: *** [config/SCRAM/GMake/Makefile.rules:1838: tmp/el9_amd64_gcc13/src/RecoParticleFlow/PFRecHitProducer/plugins/RecoParticleFlowPFRecHitProducersPluginsPortableROCmAsync/libRecoParticleFlowPFRecHitProducersPluginsPortableROCmAsync_rocm.a] Error 1
Copying tmp/el9_amd64_gcc13/src/RecoParticleFlow/PFClusterProducer/plugins/RecoParticleFlowPFClusterProducersPluginsPortableROCmAsync/libRecoParticleFlowPFClusterProducersPluginsPortableROCmAsync_rocm.a to productstore area:
@@@@ Checking for missing symbols was SKIPPED due to NO_LIB_CHECKING flag in BuildFile: libUtilitiesStaticAnalyzers.so
Copying tmp/el9_amd64_gcc13/src/RecoLocalTracker/SiPixelClusterizer/plugins/RecoLocalTrackerSiPixelClusterizerPluginsPortableROCmAsync/libRecoLocalTrackerSiPixelClusterizerPluginsPortableROCmAsync_rocm.a to productstore area:
Copying tmp/el9_amd64_gcc13/src/RecoTracker/PixelVertexFinding/plugins/RecoPixelVertexingPixelVertexFindingPluginsPortableROCmAsync/libRecoPixelVertexingPixelVertexFindingPluginsPortableROCmAsync_rocm.a to productstore area:
Copying tmp/el9_amd64_gcc13/src/RecoTracker/PixelVertexFinding/test/deviceVertexFinderByDensity_tROCmAsync/libdeviceVertexFinderByDensity_tROCmAsync_rocm.a to productstore area:


@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44682/39881

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

Pull request #44682 was updated. @mandrenguyen, @jfernan2, @cmsbuild can you please check and sign again.

@iarspider
Copy link
Contributor Author

please test for el9_amd64_gcc13

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44682/40096

@cmsbuild
Copy link
Contributor

Pull request #44682 was updated. @makortel, @mandrenguyen, @cmsbuild, @fwyzard, @jfernan2 can you please check and sign again.

@fwyzard
Copy link
Contributor

fwyzard commented Apr 25, 2024

+heterogeneous

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-992de0/39088/summary.html
COMMIT: a9b6640
CMSSW: CMSSW_14_1_X_2024-04-19-2300/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44682/39088/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 12262 lines to the logs
  • Reco comparison results: 60020 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3425959
  • DQMHistoTests: Total failures: 195438
  • DQMHistoTests: Total nulls: 250
  • DQMHistoTests: Total successes: 3230251
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.0279999999999996 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 1.019 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13034.0 ): 1.412 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 141.042 ): -0.020 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.044 ): 0.004 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 250202.181 ): 0.006 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.469 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): -1.600 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 8.0 ): -0.262 KiB SiStrip/MechanicalView
  • Checked 206 log files, 170 edm output root files, 49 DQM output files

@antoniovilela
Copy link
Contributor

please test for el8_amd64_gcc12

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-992de0/39134/summary.html
COMMIT: a9b6640
CMSSW: CMSSW_14_1_X_2024-04-28-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44682/39134/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 4 lines from the logs
  • Reco comparison results: 47 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3433373
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3433353
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 206 log files, 170 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6a03776 into cms-sw:master Apr 29, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants