Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add L1 objects into Run3Scouting Nano #44642

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Conversation

artlbv
Copy link
Contributor

@artlbv artlbv commented Apr 6, 2024

PR description:

This PR adds the L1 trigger objects to the Run3 scouting NanoAOD.
This proposal was presented and approved by the scouting group on the 5th of April: https://indico.cern.ch/event/1399442/#6-l1-objects-in-scouting-event

It follows the approach of the main Nano except it takes the L1 objects from the unpacked uGT data record, and not the L1 Muon and Calo systems themselves, since only the uGT FED is stored in the scouting RAW.

PR validation:

Tested by producing scouting NanoAOD from a 2023 scouting RAW file as shown in the linked slides.
The scouting nano size increase is 5%.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but will likely need one for this to have an effect for the upcoming data taking in 140x.

FY @elfontan @kelmorab @eyigitba @slaurila @aloeliger @epalencia

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44642/39838

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2024

A new Pull Request was created by @artlbv for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@vlimant, @hqucms, @cmsbuild can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@vlimant
Copy link
Contributor

vlimant commented Apr 7, 2024

enable nano

@vlimant
Copy link
Contributor

vlimant commented Apr 7, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9a7da8/38663/summary.html
COMMIT: 81cb199
CMSSW: CMSSW_14_1_X_2024-04-07-0000/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44642/38663/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16430
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16430
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 51 log files, 29 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.553 2.553 0.000 ( +0.0% ) 4.59 4.69 -2.1% 2.167 2.168
2500.001 2.703 2.703 0.000 ( +0.0% ) 4.09 4.16 -1.6% 2.589 2.593
2500.002 2.643 2.643 0.000 ( +0.0% ) 4.21 4.31 -2.3% 2.584 2.584
2500.01 1.318 1.318 0.000 ( +0.0% ) 8.10 8.40 -3.5% 2.271 2.276
2500.011 1.739 1.739 0.000 ( +0.0% ) 4.58 4.61 -0.8% 2.434 2.444
2500.012 1.580 1.580 0.000 ( +0.0% ) 6.40 6.54 -2.2% 2.350 2.354
2500.1 2.196 2.196 0.000 ( +0.0% ) 4.56 4.63 -1.4% 1.990 2.070
2500.2 2.313 2.313 0.000 ( +0.0% ) 5.21 5.32 -2.0% 1.896 1.972
2500.21 1.181 1.181 0.000 ( +0.0% ) 3.47 3.55 -2.3% 2.212 2.271
2500.211 1.545 1.545 0.000 ( +0.0% ) 3.05 3.18 -4.2% 2.234 2.253
2500.3 2.069 2.069 0.000 ( +0.0% ) 9.74 10.41 -6.5% 1.964 1.965
2500.301 2.642 2.642 0.000 ( +0.0% ) 8.36 8.62 -3.1% 1.949 1.951
2500.31 7.159 7.159 0.000 ( +0.0% ) 1.34 1.42 -5.8% 1.706 1.702
2500.311 1.564 1.564 0.000 ( +0.0% ) 6.48 7.18 -9.8% 1.054 1.054
2500.312 540.453 540.453 0.000 ( +0.0% ) 0.50 0.53 -6.0% 1.597 1.594
2500.313 817.689 817.689 0.000 ( +0.0% ) 0.70 0.74 -5.0% 1.577 1.585
2500.32 1.255 1.255 0.000 ( +0.0% ) 12.31 13.24 -7.0% 2.280 2.317
2500.321 1.642 1.642 0.000 ( +0.0% ) 9.38 10.01 -6.3% 2.410 2.401
2500.322 1.163 1.163 0.000 ( +0.0% ) 9.67 10.50 -7.9% 2.099 2.213
2500.323 1.758 1.758 0.000 ( +0.0% ) 9.68 10.16 -4.7% 2.178 2.147
2500.324 3.093 3.093 0.000 ( +0.0% ) 1.74 1.83 -4.6% 2.127 2.097
2500.325 1.789 1.789 0.000 ( +0.0% ) 9.76 10.34 -5.6% 2.266 2.295
2500.4 2.227 2.227 0.000 ( +0.0% ) 9.47 9.91 -4.5% 1.864 1.840
2500.401 1.755 1.755 0.000 ( +0.0% ) 8.14 8.37 -2.7% 1.725 1.728
2500.402 2.771 2.771 0.000 ( +0.0% ) 7.92 8.30 -4.7% 1.843 1.835
2500.403 5.081 5.081 0.000 ( +0.0% ) 1.31 1.34 -1.9% 1.862 1.843
2500.404 2.779 2.779 0.000 ( +0.0% ) 7.98 8.42 -5.2% 1.780 1.749
2500.5 5.192 4.936 0.255 ( +5.2% ) 15.11 15.97 -5.4% 1.414 1.300
2500.51 9.119 8.960 0.159 ( +1.8% ) 9.42 9.73 -3.1% 1.483 1.397

@vlimant
Copy link
Contributor

vlimant commented Apr 7, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8565143 into cms-sw:master Apr 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants