Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] Backport of: #44642 Add L1 objects into Run3Scouting Nano #44655

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

artlbv
Copy link
Contributor

@artlbv artlbv commented Apr 8, 2024

Needed for the actual 140X data-taking release as this is used for all HLT scouting studies.

PR description:

This PR adds the L1 trigger objects to the Run3 scouting NanoAOD.
This proposal was presented and approved by the scouting group on the 5th of April: https://indico.cern.ch/event/1399442/#6-l1-objects-in-scouting-event

It follows the approach of the main Nano except it takes the L1 objects from the unpacked uGT data record, and not the L1 Muon and Calo systems themselves, since only the uGT FED is stored in the scouting RAW.

PR validation:

Tested by producing scouting NanoAOD from a 2023 scouting RAW file as shown in the linked slides.
The scouting nano size increase is 5% in data and ~1% in MC.
Original PR tests confirm this: #44642 (comment)

FYI @elfontan @kelmorab

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2024

A new Pull Request was created by @artlbv for CMSSW_14_0_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@hqucms, @vlimant, @cmsbuild can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2024

cms-bot internal usage

@artlbv
Copy link
Contributor Author

artlbv commented Apr 8, 2024

Backport of #44642

@vlimant
Copy link
Contributor

vlimant commented Apr 8, 2024

enable nano

@vlimant
Copy link
Contributor

vlimant commented Apr 8, 2024

please test

@artlbv artlbv changed the title Add L1 objects into Run3Scouting Nano [14_0_X] Backport of: #44642 Add L1 objects into Run3Scouting Nano Apr 8, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dcff89/38675/summary.html
COMMIT: 44eec9f
CMSSW: CMSSW_14_0_X_2024-04-07-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44655/38675/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16470
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16470
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 47 log files, 27 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.553 2.553 0.000 ( +0.0% ) 5.19 5.12 +1.4% 2.205 2.241
2500.001 2.703 2.703 0.000 ( +0.0% ) 4.62 4.64 -0.3% 2.125 2.645
2500.002 2.643 2.643 0.000 ( +0.0% ) 4.85 4.83 +0.3% 2.240 2.633
2500.01 1.318 1.318 0.000 ( +0.0% ) 9.60 9.56 +0.4% 1.991 2.283
2500.011 1.740 1.740 0.000 ( +0.0% ) 5.18 5.18 -0.1% 1.999 2.431
2500.012 1.581 1.581 0.000 ( +0.0% ) 7.36 7.29 +1.1% 2.004 2.422
2500.1 2.197 2.197 0.000 ( +0.0% ) 5.25 5.26 -0.1% 2.055 2.067
2500.2 2.314 2.314 0.000 ( +0.0% ) 6.02 5.83 +3.3% 1.939 1.985
2500.21 1.182 1.182 0.000 ( +0.0% ) 4.29 4.25 +1.0% 1.963 2.271
2500.211 1.546 1.546 0.000 ( +0.0% ) 3.74 3.70 +1.2% 2.053 2.354
2500.3 2.065 2.065 0.000 ( +0.0% ) 12.21 12.03 +1.5% 1.968 1.978
2500.301 2.637 2.637 0.000 ( +0.0% ) 9.83 9.49 +3.6% 1.954 1.959
2500.31 1.255 1.255 0.000 ( +0.0% ) 19.32 18.61 +3.8% 2.364 2.344
2500.311 1.641 1.641 0.000 ( +0.0% ) 13.36 12.87 +3.8% 2.444 2.415
2500.312 7.159 7.159 0.000 ( +0.0% ) 1.40 1.43 -1.5% 1.697 1.700
2500.313 1.564 1.564 0.000 ( +0.0% ) 5.34 6.64 -19.6% 1.050 1.058
2500.314 1.163 1.163 0.000 ( +0.0% ) 13.96 13.79 +1.3% 1.843 2.178
2500.315 1.757 1.757 0.000 ( +0.0% ) 13.77 13.56 +1.6% 2.061 2.333
2500.316 3.093 3.093 0.000 ( +0.0% ) 2.20 2.21 -0.5% 1.828 2.276
2500.317 1.788 1.788 0.000 ( +0.0% ) 12.98 13.25 -2.0% 2.187 2.194
2500.4 2.226 2.226 0.000 ( +0.0% ) 11.94 11.65 +2.5% 1.801 1.857
2500.401 1.749 1.749 0.000 ( +0.0% ) 10.30 9.97 +3.3% 1.809 1.690
2500.402 2.770 2.770 0.000 ( +0.0% ) 9.65 9.76 -1.1% 1.740 1.913
2500.403 5.080 5.080 0.000 ( +0.0% ) 1.59 1.59 -0.5% 1.735 1.866
2500.404 2.778 2.778 0.000 ( +0.0% ) 9.70 9.38 +3.4% 1.864 1.702
2500.5 5.192 4.936 0.255 ( +5.2% ) 15.83 15.98 -1.0% 1.630 1.592
2500.51 9.119 8.960 0.159 ( +1.8% ) 9.70 9.83 -1.3% 1.655 1.537

@vlimant
Copy link
Contributor

vlimant commented Apr 8, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ac9dcf3 into cms-sw:CMSSW_14_0_X Apr 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants