[14_1_X] Bumped CepGen version to 1.2.3 #9122

forthommel · 2024-04-06T10:25:23Z

This PR bumps the version of CepGen to 1.2.3.
Changelog is available here.

cmsbuild · 2024-04-06T10:25:45Z

A new Pull Request was created by @forthommel for branch IB/CMSSW_14_1_X/master.

@iarspider, @smuzaffar, @cmsbuild, @aandvalenzuela can you please review it and eventually sign? Thanks.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.
cms-bot commands are listed here

cmsbuild · 2024-04-06T10:25:45Z

cms-bot internal usage

smuzaffar · 2024-04-06T11:09:02Z

please test

cmsbuild · 2024-04-06T12:48:04Z

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af56af/38651/summary.html
COMMIT: b847a34
CMSSW: CMSSW_14_1_X_2024-04-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9122/38651/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@belforte bump crabclient to v3.240404 #9120

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af56af/38651/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af56af/38651/git-merge-result

Build

I found compilation error when building:

>> Package GeneratorInterface/CepGenInterface built
Entering library rule at src/GeneratorInterface/CepGenInterface/plugins
>> Compiling edm plugin src/GeneratorInterface/CepGenInterface/plugins/CepGenGeneratorFilter.cc
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-04-06-1100/src/GeneratorInterface/CepGenInterface/interface/CepGenGeneratorFilter.h:8,
                 from src/GeneratorInterface/CepGenInterface/plugins/CepGenGeneratorFilter.cc:5:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-04-06-1100/src/GeneratorInterface/CepGenInterface/interface/CepGenEventGenerator.h:36:19: error: 'ParametersList' in namespace 'cepgen' does not name a type
   36 |     const cepgen::ParametersList proc_params_;
      |                   ^~~~~~~~~~~~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_1_X_2024-04-06-1100/src/GeneratorInterface/CepGenInterface/interface/CepGenEventGenerator.h:37:48: error: 'ParametersList' is not a member of 'cepgen'
   37 |     std::vector > modif_modules_, output_modules_;
      |                                                ^~~~~~~~~~~~~~

forthommel · 2024-04-06T14:54:01Z

cms-sw/cmssw#44647 should fix this issue. Backports to 13_0_X and 10_6_X should be issued too.

smuzaffar · 2024-04-06T21:07:41Z

test parameters:
pull_request = cms-sw/cmssw#44647

smuzaffar · 2024-04-06T21:07:45Z

please test

cmsbuild · 2024-04-07T00:23:02Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af56af/38656/summary.html
COMMIT: b847a34
CMSSW: CMSSW_14_1_X_2024-04-06-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9122/38656/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@belforte bump crabclient to v3.240404 #9120

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af56af/38656/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af56af/38656/git-merge-result

Comparison Summary

Summary:

You potentially added 104 lines to the logs
Reco comparison results: 50 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3307717
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3307694
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

smuzaffar · 2024-04-08T19:58:37Z

please test for el8_aarch64_gcc12

smuzaffar · 2024-04-11T06:13:52Z

please test

cmsbuild · 2024-04-11T14:22:21Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af56af/38770/summary.html
COMMIT: b847a34
CMSSW: CMSSW_14_1_X_2024-04-09-2300/el8_aarch64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9122/38770/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@fwyzard Update to CUDA 12.4.1 #9126

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af56af/38770/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af56af/38770/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

cmsbuild · 2024-04-12T00:07:45Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af56af/38765/summary.html
COMMIT: b847a34
CMSSW: CMSSW_14_1_X_2024-04-10-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/9122/38765/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@fwyzard Update to CUDA 12.4.1 #9126

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af56af/38765/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af56af/38765/git-merge-result

Unit Tests

I found 2 errors in the following unit tests:

---> test TestGeneratorInterfacePythia8ConcurrentGeneratorFilter had ERRORS
---> test runtestPhysicsToolsPatAlgos had ERRORS

Comparison Summary

There are some workflows for which there are errors in the baseline:
546.0 step 2
547.0 step 3
548.0 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

You potentially added 116 lines to the logs
Reco comparison results: 53 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3316263
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3316240
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

forthommel · 2024-04-12T06:56:15Z

Hello @smuzaffar!
I must admit I am now lost in your release/architectures validation plan. Could you please let me know if there is a list of conditions I should test locally in addition to the standard ones?

smuzaffar · 2024-04-12T07:03:40Z

+externals

unit tests failure are not related to this update ( these tests are failing for cmssw IBs)

@forthommel , I just wanted to make sure new version builds for all supported archs.

cmsbuild · 2024-04-12T07:04:02Z

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmssw#44647

forthommel · 2024-04-12T07:10:16Z

+externals

unit tests failure are not related to this update ( these tests are failing for cmssw IBs)

@forthommel , I just wanted to make sure new version builds for all supported archs.

Many thanks for your detailed explanation, @smuzaffar! I am reassured that this single extra include line is not breaking all the future workflows :-)

smuzaffar · 2024-04-15T07:17:46Z

please test

lets refresh the tests

forthommel · 2024-04-15T09:26:14Z

@smuzaffar This PhysicsTools/PatAlgos failed unit test looks fairly platform-independent...

iarspider · 2024-04-15T09:33:53Z

@smuzaffar This PhysicsTools/PatAlgos failed unit test looks fairly platform-independent...

@forthommel this one is known: cms-sw/cmssw#33084 (comment)

cmsbuild · 2024-04-15T16:32:24Z

-1

Failed Tests: UnitTests RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af56af/38842/summary.html
COMMIT: b847a34
CMSSW: CMSSW_14_1_X_2024-04-14-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9122/38842/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af56af/38842/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-af56af/38842/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

You potentially added 95 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 99 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3317863
DQMHistoTests: Total failures: 26
DQMHistoTests: Total nulls: 5
DQMHistoTests: Total successes: 3317812
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 3146.823999999999 KiB( 47 files compared)
DQMHistoSizes: changed ( 11634.0,... ): 0.247 KiB Physics/NanoAODDQM
DQMHistoSizes: changed ( 12834.0,... ): 448.699 KiB HLT/EXO
DQMHistoSizes: changed ( 12834.0,... ): 0.445 KiB HLT/Filters
DQMHistoSizes: changed ( 13234.0,... ): 0.120 KiB Physics/NanoAODDQM
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

cmsbuild · 2024-04-19T16:35:24Z

REMINDER @sextonkennedy, @rappoccio, @antoniovilela: This PR was tested with cms-sw/cmssw#44647, please check if they should be merged together

rappoccio · 2024-04-19T17:53:39Z

+1

Tests in cmssw PR are passing

rappoccio · 2024-04-19T17:53:43Z

merge

Bumped CepGen version to 1.2.3

b847a34

cmsbuild added tests-pending externals-pending pending-signatures orp-pending labels Apr 6, 2024

forthommel changed the title ~~Bumped CepGen version to 1.2.3~~ [14_1_X] Bumped CepGen version to 1.2.3 Apr 6, 2024

cmsbuild added tests-started and removed tests-pending labels Apr 6, 2024

cmsbuild added tests-rejected and removed tests-started labels Apr 6, 2024

forthommel mentioned this pull request Apr 6, 2024

CepGenInterface: Added missing include cms-sw/cmssw#44647

Merged

cmsbuild added requires-external tests-started and removed tests-rejected labels Apr 6, 2024

cmsbuild added tests-approved tests-pending and removed tests-started tests-approved labels Apr 7, 2024

cmsbuild added tests-approved and removed tests-pending labels Apr 8, 2024

menglu21 mentioned this pull request Apr 9, 2024

[10_6_X] CepGenInterface: Added missing include cms-sw/cmssw#44648

Merged

cmsbuild added tests-started and removed tests-approved labels Apr 11, 2024

cmsbuild added tests-rejected and removed tests-started labels Apr 12, 2024

cmsbuild added externals-approved fully-signed and removed externals-pending pending-signatures labels Apr 12, 2024

cmsbuild added tests-started and removed tests-rejected labels Apr 15, 2024

cmsbuild added tests-rejected and removed tests-started labels Apr 15, 2024

cmsbuild added orp-approved and removed orp-pending labels Apr 19, 2024

cmsbuild merged commit ca30f8a into cms-sw:IB/CMSSW_14_1_X/master Apr 19, 2024
14 of 17 checks passed

forthommel deleted the cepgen-14_1_X branch April 19, 2024 17:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14_1_X] Bumped CepGen version to 1.2.3 #9122

[14_1_X] Bumped CepGen version to 1.2.3 #9122

forthommel commented Apr 6, 2024

cmsbuild commented Apr 6, 2024

cmsbuild commented Apr 6, 2024 •

edited

Loading

smuzaffar commented Apr 6, 2024

cmsbuild commented Apr 6, 2024

forthommel commented Apr 6, 2024

smuzaffar commented Apr 6, 2024

smuzaffar commented Apr 6, 2024

cmsbuild commented Apr 7, 2024

smuzaffar commented Apr 8, 2024

smuzaffar commented Apr 11, 2024

cmsbuild commented Apr 11, 2024

cmsbuild commented Apr 12, 2024

forthommel commented Apr 12, 2024

smuzaffar commented Apr 12, 2024

cmsbuild commented Apr 12, 2024

forthommel commented Apr 12, 2024

smuzaffar commented Apr 15, 2024

forthommel commented Apr 15, 2024

iarspider commented Apr 15, 2024

cmsbuild commented Apr 15, 2024

cmsbuild commented Apr 19, 2024

rappoccio commented Apr 19, 2024

rappoccio commented Apr 19, 2024

[14_1_X] Bumped CepGen version to 1.2.3 #9122

[14_1_X] Bumped CepGen version to 1.2.3 #9122

Conversation

forthommel commented Apr 6, 2024

cmsbuild commented Apr 6, 2024

cmsbuild commented Apr 6, 2024 • edited Loading

smuzaffar commented Apr 6, 2024

cmsbuild commented Apr 6, 2024

Build

forthommel commented Apr 6, 2024

smuzaffar commented Apr 6, 2024

smuzaffar commented Apr 6, 2024

cmsbuild commented Apr 7, 2024

Comparison Summary

smuzaffar commented Apr 8, 2024

smuzaffar commented Apr 11, 2024

cmsbuild commented Apr 11, 2024

Unit Tests

cmsbuild commented Apr 12, 2024

Unit Tests

Comparison Summary

forthommel commented Apr 12, 2024

smuzaffar commented Apr 12, 2024

cmsbuild commented Apr 12, 2024

forthommel commented Apr 12, 2024

smuzaffar commented Apr 15, 2024

forthommel commented Apr 15, 2024

iarspider commented Apr 15, 2024

cmsbuild commented Apr 15, 2024

Unit Tests

RelVals-INPUT

Comparison Summary

cmsbuild commented Apr 19, 2024

rappoccio commented Apr 19, 2024

rappoccio commented Apr 19, 2024

cmsbuild commented Apr 6, 2024 •

edited

Loading