Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 14_0_X (6/N) [14_1_X] #44733

Merged
merged 2 commits into from
Apr 14, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Apr 14, 2024

PR description:

This PR is a quick follow-up to #44717 in order to make cmssw on-par with the version of the "V1.1" menu for the 2024 pp data-taking period.

This update includes the integration of the following JIRA tickets:

  • CMSHLT-3153 : [PRO/PPS] Set smartPS=1 for PPS-Jet trigger
  • CMSHLT-3159 : [BTV/EXO] Add two PNet3BTag Paths to GRun subtable
  • CMSHLT-3160 : [TSG] Set PS=1 for non-AXO Scouting Paths in "2p0E34_NoAXO" column

In addition update the makeOnlineSpecial script as used to derive the V1.2 of the FOG "Special" menus.

PR validation:

TSG integration tests

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but will be backported to CMSSW_14_0_X (2024 data-taking release)

mmusich added 2 commits April 14, 2024 10:49
This version of the GRun HLT menu corresponds to few updates to the "V1.1" menu for the 2024 pp data-taking period.
This update includes the integration of the following JIRA tickets:
- [CMSHLT-3153](https://its.cern.ch/jira/browse/CMSHLT-3153) : [PRO/PPS] Set smartPS=1 for PPS-Jet trigger
- [CMSHLT-3159](https://its.cern.ch/jira/browse/CMSHLT-3159) : [BTV/EXO] Add two PNet3BTag Paths to GRun subtable
- [CMSHLT-3160](https://its.cern.ch/jira/browse/CMSHLT-3160) : [TSG] Set PS=1 for non-AXO Scouting Paths in "2p0E34_NoAXO" column
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 14, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Apr 14, 2024

type hlt-integration

@mmusich
Copy link
Contributor Author

mmusich commented Apr 14, 2024

enable gpu

@mmusich
Copy link
Contributor Author

mmusich commented Apr 14, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44733/39948

  • This PR adds an extra 788KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@mmusich, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@missirol, @silviodonato, @Martin-Grunewald this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-92fce9/38836/summary.html
COMMIT: 4e07c35
CMSSW: CMSSW_14_1_X_2024-04-13-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44733/38836/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 4 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 52 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3317863
  • DQMHistoTests: Total failures: 29
  • DQMHistoTests: Total nulls: 5
  • DQMHistoTests: Total successes: 3317809
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 3144.015 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 12834.0,... ): 448.699 KiB HLT/EXO
  • DQMHistoSizes: changed ( 12834.0,... ): 0.445 KiB HLT/Filters
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 34 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 39740
  • DQMHistoTests: Total failures: 1714
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 38026
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Apr 14, 2024

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

  • HLT dump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants