Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated AK8 path names for 2024 data-taking #44614

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

marinakolosova
Copy link
Contributor

@marinakolosova marinakolosova commented Apr 4, 2024

PR description:

  • Replaced AK8 paths from B2G DQM monitoring
  • The new paths were introduced in CMSHLT-3028

PR validation:

I have tested the changes by re-running the HLT, RECO+DQM and Harvesting steps with cmsDriver and checked that the new folders are now created and filled.

I have also checked:
runTheMatrix.py -l limited -i all --ibeos

with output:
47 46 45 36 19 1 1 1 1 1 1 tests passed, 0 0 0 0 0 0 0 0 0 0 0 failed

The above changes will be backported to:
CMSSW_14_1_X (#44615)
CMSSW_14_0_X (#44617)

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44614/39804

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2024

A new Pull Request was created by @marinakolosova for master.

It involves the following packages:

  • DQMOffline/Trigger (dqm)

@antoniovagnerini, @cmsbuild, @tjavaid, @nothingface0, @rvenditti, @syuvivida can you please review it and eventually sign? Thanks.
@Fedespring, @trocino, @jhgoh, @missirol, @HuguesBrun, @rociovilar, @mtosi, @cericeci this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Apr 4, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0d046a/38600/summary.html
COMMIT: 0c3b50b
CMSSW: CMSSW_14_1_X_2024-04-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44614/38600/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 109 lines to the logs
  • Reco comparison results: 37 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3307717
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3307697
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 9594.837000000001 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 12834.0,... ): 1370.691 KiB HLT/B2G
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Apr 8, 2024

@cms-sw/dqm-l2 can you please have a look?

@tjavaid
Copy link

tjavaid commented Apr 8, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants