Do not include EventSetup record definitions in device code

[fwyzard]

PR description:

Do not include EventSetup record definitions in device code.

To minimise the code changes, forward-declare the records in a common header, and include their definition only in host code.

PR validation:

Builds on top of CMSSW_14_1_X_2024-04-23-2300.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

A backport is not required, though it may be prepared to keep the 14.0.x and 14.1.x alpaka code base consistent.

[fwyzard]

type bugfix

[fwyzard]

enable gpu

[fwyzard]

please test

[cmsbuild]

cms-bot internal usage

[fwyzard]

type pf

[iarspider]

@fwyzard should I close my PR in favor of this one?

[fwyzard]

I forgot about it !
Either is fine, of course.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44828/40070

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoParticleFlow/PFRecHitProducer/plugins/alpaka/CalorimeterDefinitions.h modified in PR(s): Do not include EventSetup record definitions in device code  #44682
  • File RecoParticleFlow/PFRecHitProducer/plugins/alpaka/PFRecHitSoAProducer.cc modified in PR(s): Do not include EventSetup record definitions in device code  #44682
  • File RecoParticleFlow/PFRecHitProducer/plugins/alpaka/PFRecHitTopologyESProducer.cc modified in PR(s): Do not include EventSetup record definitions in device code  #44682

[cmsbuild]

A new Pull Request was created by @fwyzard for master.

It involves the following packages:

• RecoParticleFlow/PFRecHitProducer (reconstruction)

@mandrenguyen, @jfernan2 can you please review it and eventually sign? Thanks.
@hatakeyamak, @lgray, @seemasharmafnal, @missirol, @mmarionncern this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3a17e7/39046/summary.html
COMMIT: 2599c10
CMSSW: CMSSW_14_1_X_2024-04-23-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44828/39046/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 100 lines to the logs
• Reco comparison results: 47 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3319852
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3319829
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 20 differences found in the comparisons
• DQMHistoTests: Total files compared: 3
• DQMHistoTests: Total histograms compared: 39740
• DQMHistoTests: Total failures: 908
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 38832
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
• Checked 8 log files, 10 edm output root files, 3 DQM output files
• TriggerResults: no differences found

[jfernan2]

This PR looks fine from RECO side, but I wonder if we should move to #44682 to consider the comments and extra changes reflected there

[fwyzard]

This PR looks fine from RECO side, but I wonder if we should move to #44682 to consider the comments and extra changes reflected there

These two PRs are effectively identical.

[jfernan2]

-1
To clean the queue and since 44682 includes an extra commit: https://github.com/cms-sw/cmssw/pull/44682/files#diff-9c44348b4ee0dea4da8f43aca44f793d031b4742198d729e47bf07a1be0bd4fc