Move EventSetup record dependency to non-device source file [14.0.x]

[fwyzard]

PR description:

Move

#include "RecoParticleFlow/PFRecHitProducer/interface/PFRecHitTopologyRecord.h"

from a (device) header file to a (non-device) source file.

It should prevent TBB and EDM framework files to be compiled by the device compilers, like nvcc.

PR validation:

None.

Backport status:

Backport of #44656 to 14.0.x.

[fwyzard]

type bugfix

[cmsbuild]

A new Pull Request was created by @fwyzard for CMSSW_14_0_X.

It involves the following packages:

• RecoParticleFlow/PFClusterProducer (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@hatakeyamak, @seemasharmafnal, @felicepantaleo, @mmarionncern, @missirol, @lgray, @sameasy, @rovere this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Move EventSetup record dependency to non-device source file #44656

[cmsbuild]

cms-bot internal usage

[fwyzard]

backport #44656

[fwyzard]

type pf

[fwyzard]

enable gpu

[fwyzard]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bc682c/38694/summary.html
COMMIT: b722972
CMSSW: CMSSW_14_0_X_2024-04-08-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44663/38694/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 92 lines to the logs
• Reco comparison results: 40 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3349032
• DQMHistoTests: Total failures: 23
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3348987
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 166 edm output root files, 49 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 30 differences found in the comparisons
• DQMHistoTests: Total files compared: 3
• DQMHistoTests: Total histograms compared: 39740
• DQMHistoTests: Total failures: 1410
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 38330
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
• Checked 8 log files, 10 edm output root files, 3 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1