Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MiniAOD] Increase AK4 CHS pt cut and remove unsupported taggers for AK4 CHS and AK8 Puppi jets #43965

Merged
merged 5 commits into from
Feb 19, 2024

Conversation

nurfikri89
Copy link
Contributor

@nurfikri89 nurfikri89 commented Feb 14, 2024

This PR is the long awaited follow up of Issue #37167. The following changes to MiniAOD content are introduced:

  • AK4 CHS jets (slimmedJets) pT threshold increase from 10 GeV to 15 GeV.
  • Remove PileupJetID and Quark-Gluon Likelihood taggers for AK4 CHS jets.
  • Remove unsupported taggers for AK4 CHS jets.
  • Remove unsupported taggers for AK8 Puppi jets (slimmedJetsAK8).

Event size decreases by about 2.6%. The size comparison test was performed with 5000 events from a Run3Summer23 TTTo4Q AODSIM file.

List of tagger outputs stored for AK4CHS jets:

pfJetBProbabilityBJetTags
pfJetProbabilityBJetTags
pfTrackCountingHighEffBJetTags
pfDeepCSVJetTags:probb
pfDeepCSVJetTags:probc
pfDeepCSVJetTags:probudsg
pfDeepCSVJetTags:probbb
pfParticleNetFromMiniAODAK4CHSCentralJetTags:probb
pfParticleNetFromMiniAODAK4CHSCentralJetTags:probc
pfParticleNetFromMiniAODAK4CHSCentralJetTags:probele
pfParticleNetFromMiniAODAK4CHSCentralJetTags:probg
pfParticleNetFromMiniAODAK4CHSCentralJetTags:probmu
pfParticleNetFromMiniAODAK4CHSCentralJetTags:probtaum1h0p
pfParticleNetFromMiniAODAK4CHSCentralJetTags:probtaum1h1p
pfParticleNetFromMiniAODAK4CHSCentralJetTags:probtaum1h2p
pfParticleNetFromMiniAODAK4CHSCentralJetTags:probtaum3h0p
pfParticleNetFromMiniAODAK4CHSCentralJetTags:probtaum3h1p
pfParticleNetFromMiniAODAK4CHSCentralJetTags:probtaup1h0p
pfParticleNetFromMiniAODAK4CHSCentralJetTags:probtaup1h1p
pfParticleNetFromMiniAODAK4CHSCentralJetTags:probtaup1h2p
pfParticleNetFromMiniAODAK4CHSCentralJetTags:probtaup3h0p
pfParticleNetFromMiniAODAK4CHSCentralJetTags:probtaup3h1p
pfParticleNetFromMiniAODAK4CHSCentralJetTags:probuds
pfParticleNetFromMiniAODAK4CHSCentralJetTags:ptcorr
pfParticleNetFromMiniAODAK4CHSCentralJetTags:ptnu
pfParticleNetFromMiniAODAK4CHSCentralJetTags:ptreshigh
pfParticleNetFromMiniAODAK4CHSCentralJetTags:ptreslow
pfParticleNetFromMiniAODAK4CHSCentralDiscriminatorsJetTags:BvsAll
pfParticleNetFromMiniAODAK4CHSCentralDiscriminatorsJetTags:CvsB
pfParticleNetFromMiniAODAK4CHSCentralDiscriminatorsJetTags:CvsL
pfParticleNetFromMiniAODAK4CHSCentralDiscriminatorsJetTags:QvsG
pfParticleNetFromMiniAODAK4CHSCentralDiscriminatorsJetTags:TauVsEle
pfParticleNetFromMiniAODAK4CHSCentralDiscriminatorsJetTags:TauVsJet
pfParticleNetFromMiniAODAK4CHSCentralDiscriminatorsJetTags:TauVsMu

List of tagger outputs stored for AK4Puppi jets:

pfDeepCSVJetTags:probb
pfDeepCSVJetTags:probbb
pfDeepCSVJetTags:probc
pfDeepCSVJetTags:probudsg
pfJetBProbabilityBJetTags
pfJetProbabilityBJetTags
pfTrackCountingHighEffBJetTags
pfDeepFlavourJetTags:probb
pfDeepFlavourJetTags:probbb
pfDeepFlavourJetTags:probc
pfDeepFlavourJetTags:probg
pfDeepFlavourJetTags:problepb
pfDeepFlavourJetTags:probuds
pfParticleNetFromMiniAODAK4PuppiCentralJetTags:probb
pfParticleNetFromMiniAODAK4PuppiCentralJetTags:probc
pfParticleNetFromMiniAODAK4PuppiCentralJetTags:probele
pfParticleNetFromMiniAODAK4PuppiCentralJetTags:probg
pfParticleNetFromMiniAODAK4PuppiCentralJetTags:probmu
pfParticleNetFromMiniAODAK4PuppiCentralJetTags:probtaum1h0p
pfParticleNetFromMiniAODAK4PuppiCentralJetTags:probtaum1h1p
pfParticleNetFromMiniAODAK4PuppiCentralJetTags:probtaum1h2p
pfParticleNetFromMiniAODAK4PuppiCentralJetTags:probtaum3h0p
pfParticleNetFromMiniAODAK4PuppiCentralJetTags:probtaum3h1p
pfParticleNetFromMiniAODAK4PuppiCentralJetTags:probtaup1h0p
pfParticleNetFromMiniAODAK4PuppiCentralJetTags:probtaup1h1p
pfParticleNetFromMiniAODAK4PuppiCentralJetTags:probtaup1h2p
pfParticleNetFromMiniAODAK4PuppiCentralJetTags:probtaup3h0p
pfParticleNetFromMiniAODAK4PuppiCentralJetTags:probtaup3h1p
pfParticleNetFromMiniAODAK4PuppiCentralJetTags:probuds
pfParticleNetFromMiniAODAK4PuppiCentralJetTags:ptcorr
pfParticleNetFromMiniAODAK4PuppiCentralJetTags:ptnu
pfParticleNetFromMiniAODAK4PuppiCentralJetTags:ptreshigh
pfParticleNetFromMiniAODAK4PuppiCentralJetTags:ptreslow
pfParticleNetFromMiniAODAK4PuppiForwardJetTags:probg
pfParticleNetFromMiniAODAK4PuppiForwardJetTags:probq
pfParticleNetFromMiniAODAK4PuppiForwardJetTags:ptcorr
pfParticleNetFromMiniAODAK4PuppiForwardJetTags:ptnu
pfParticleNetFromMiniAODAK4PuppiForwardJetTags:ptreshigh
pfParticleNetFromMiniAODAK4PuppiForwardJetTags:ptreslow
pfParticleTransformerAK4JetTags:probb
pfParticleTransformerAK4JetTags:probbb
pfParticleTransformerAK4JetTags:probc
pfParticleTransformerAK4JetTags:probg
pfParticleTransformerAK4JetTags:problepb
pfParticleTransformerAK4JetTags:probuds
pfParticleNetFromMiniAODAK4PuppiCentralDiscriminatorsJetTags:BvsAll
pfParticleNetFromMiniAODAK4PuppiCentralDiscriminatorsJetTags:CvsB
pfParticleNetFromMiniAODAK4PuppiCentralDiscriminatorsJetTags:CvsL
pfParticleNetFromMiniAODAK4PuppiCentralDiscriminatorsJetTags:QvsG
pfParticleNetFromMiniAODAK4PuppiCentralDiscriminatorsJetTags:TauVsEle
pfParticleNetFromMiniAODAK4PuppiCentralDiscriminatorsJetTags:TauVsJet
pfParticleNetFromMiniAODAK4PuppiCentralDiscriminatorsJetTags:TauVsMu
pfParticleNetFromMiniAODAK4PuppiForwardDiscriminatorsJetTags:QvsG
pfParticleTransformerAK4DiscriminatorsJetTags:BvsAll
pfParticleTransformerAK4DiscriminatorsJetTags:BvsL
pfParticleTransformerAK4DiscriminatorsJetTags:CvsB
pfParticleTransformerAK4DiscriminatorsJetTags:CvsL
pfParticleTransformerAK4DiscriminatorsJetTags:QvsG

List of tagger outputs stored for AK8Puppi jets:

pfParticleNetFromMiniAODAK8JetTags:masscorr
pfParticleNetFromMiniAODAK8JetTags:probHbb
pfParticleNetFromMiniAODAK8JetTags:probHcc
pfParticleNetFromMiniAODAK8JetTags:probHgg
pfParticleNetFromMiniAODAK8JetTags:probHqq
pfParticleNetFromMiniAODAK8JetTags:probHte
pfParticleNetFromMiniAODAK8JetTags:probHtm
pfParticleNetFromMiniAODAK8JetTags:probHtt
pfParticleNetFromMiniAODAK8JetTags:probQCD0hf
pfParticleNetFromMiniAODAK8JetTags:probQCD1hf
pfParticleNetFromMiniAODAK8JetTags:probQCD2hf
pfParticleNetJetTags:probHbb
pfParticleNetJetTags:probHcc
pfParticleNetJetTags:probHqqqq
pfParticleNetJetTags:probQCDb
pfParticleNetJetTags:probQCDbb
pfParticleNetJetTags:probQCDc
pfParticleNetJetTags:probQCDcc
pfParticleNetJetTags:probQCDothers
pfParticleNetJetTags:probTbc
pfParticleNetJetTags:probTbcq
pfParticleNetJetTags:probTbel
pfParticleNetJetTags:probTbmu
pfParticleNetJetTags:probTbq
pfParticleNetJetTags:probTbqq
pfParticleNetJetTags:probTbta
pfParticleNetJetTags:probWcq
pfParticleNetJetTags:probWqq
pfParticleNetJetTags:probZbb
pfParticleNetJetTags:probZcc
pfParticleNetJetTags:probZqq
pfParticleNetDiscriminatorsJetTags:H4qvsQCD
pfParticleNetDiscriminatorsJetTags:HbbvsQCD
pfParticleNetDiscriminatorsJetTags:HccvsQCD
pfParticleNetDiscriminatorsJetTags:TvsQCD
pfParticleNetDiscriminatorsJetTags:WvsQCD
pfParticleNetDiscriminatorsJetTags:ZbbvsQCD
pfParticleNetDiscriminatorsJetTags:ZccvsQCD
pfParticleNetDiscriminatorsJetTags:ZvsQCD
pfParticleNetFromMiniAODAK8DiscriminatorsJetTags:HbbvsQCD
pfParticleNetFromMiniAODAK8DiscriminatorsJetTags:HccvsQCD
pfParticleNetFromMiniAODAK8DiscriminatorsJetTags:HggvsQCD
pfParticleNetFromMiniAODAK8DiscriminatorsJetTags:HqqvsQCD
pfParticleNetFromMiniAODAK8DiscriminatorsJetTags:HtevsQCD
pfParticleNetFromMiniAODAK8DiscriminatorsJetTags:HtmvsQCD
pfParticleNetFromMiniAODAK8DiscriminatorsJetTags:HttvsQCD

FYI JME L2 (@abenecke @alkaloge), BTV L2 (@SWuchterl @mondalspandan) and XPOG (@vlimant @hqucms)

PR validation:

passes the usual runTheMatrix test: runTheMatrix.py -l limited -i all --ibeos

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 14, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43965/38865

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @nurfikri89 (Nurfikri Norjoharuddeen) for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)
  • PhysicsTools/PatAlgos (xpog, reconstruction)

@vlimant, @cmsbuild, @jfernan2, @mandrenguyen, @hqucms can you please review it and eventually sign? Thanks.
@ahinzmann, @mbluj, @mmarionncern, @andrzejnovak, @Ming-Yan, @azotz, @gkasieczka, @JyothsnaKomaragiri, @gpetruc, @schoef, @gouskos, @jdamgov, @Senphy, @seemasharmafnal, @AlexDeMoor, @demuller, @AnnikaStein, @jdolen, @rappoccio, @hatakeyamak, @emilbols, @mariadalfonso, @nhanvtran this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@nurfikri89
Copy link
Contributor Author

@vlimant @hqucms, can this be backported to 14_0_X?

@hqucms
Copy link
Contributor

hqucms commented Feb 15, 2024

enable nano

@hqucms
Copy link
Contributor

hqucms commented Feb 15, 2024

please test

@mandrenguyen
Copy link
Contributor

type jetmet, btv

@vlimant
Copy link
Contributor

vlimant commented Feb 15, 2024

you may prepare a backport indeed

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-edbb09/37471/summary.html
COMMIT: 269be07
CMSSW: CMSSW_14_1_X_2024-02-14-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43965/37471/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 81 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 9463 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3248374
  • DQMHistoTests: Total failures: 5364
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3242988
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -21.884999999999998 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): -1.459 KiB Physics/NanoAODDQM
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 20 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16416
  • DQMHistoTests: Total failures: 20
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16396
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -13.186 KiB( 14 files compared)
  • DQMHistoSizes: changed ( 2500.001,... ): -0.735 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 2500.311,... ): -1.459 KiB Physics/NanoAODDQM
  • Checked 38 log files, 18 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.545 2.545 0.000 ( +0.0% ) 5.30 5.24 +1.2% 2.222 2.156
2500.001 2.692 2.692 0.000 ( +0.0% ) 4.73 4.72 +0.1% 2.644 2.546
2500.002 2.631 2.631 0.000 ( +0.0% ) 4.92 4.90 +0.4% 2.635 2.541
2500.01 1.315 1.315 0.000 ( +0.0% ) 9.92 9.63 +3.1% 2.349 2.255
2500.011 1.732 1.732 0.000 ( +0.0% ) 5.26 5.24 +0.3% 2.498 2.410
2500.012 1.578 1.578 0.000 ( +0.0% ) 7.52 7.51 +0.2% 2.438 2.316
2500.1 2.193 2.193 0.000 ( +0.0% ) 5.29 5.28 +0.2% 2.052 2.054
2500.2 2.307 2.307 0.000 ( +0.0% ) 6.10 6.01 +1.4% 1.975 1.969
2500.21 1.183 1.183 0.000 ( +0.0% ) 4.34 4.34 +0.0% 2.245 2.252
2500.211 1.547 1.547 0.000 ( +0.0% ) 3.80 3.81 -0.3% 2.333 2.325
2500.3 2.058 2.063 -0.005 ( -0.2% ) 12.64 12.69 -0.4% 1.960 1.954
2500.31 1.256 1.258 -0.003 ( -0.2% ) 20.16 20.19 -0.2% 2.341 2.327
2500.311 1.642 1.646 -0.004 ( -0.2% ) 13.65 13.57 +0.5% 2.431 2.418
2500.312 7.159 7.159 0.000 ( +0.0% ) 1.38 1.38 +0.4% 1.683 1.672
2500.313 1.564 1.564 0.000 ( +0.0% ) 6.59 6.89 -4.3% 1.036 1.028
2500.4 2.058 2.063 -0.005 ( -0.2% ) 12.70 12.71 -0.0% 1.955 1.954
2500.5 19.575 19.575 0.000 ( +0.0% ) 1.07 1.23 -12.6% 1.338 1.112

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43965/38904

@cmsbuild
Copy link
Contributor

Pull request #43965 was updated. @jfernan2, @hqucms, @cmsbuild, @mandrenguyen, @vlimant can you please check and sign again.

@hqucms
Copy link
Contributor

hqucms commented Feb 15, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-edbb09/37506/summary.html
COMMIT: 2c3010b
CMSSW: CMSSW_14_1_X_2024-02-15-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43965/37506/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 95 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 8397 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3248374
  • DQMHistoTests: Total failures: 4927
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3243425
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -21.884999999999998 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): -1.459 KiB Physics/NanoAODDQM
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 20 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16416
  • DQMHistoTests: Total failures: 20
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16396
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -13.186 KiB( 14 files compared)
  • DQMHistoSizes: changed ( 2500.001,... ): -0.735 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 2500.311,... ): -1.459 KiB Physics/NanoAODDQM
  • Checked 38 log files, 18 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.545 2.545 0.000 ( +0.0% ) 5.28 5.28 +0.0% 2.146 2.152
2500.001 2.692 2.692 0.000 ( +0.0% ) 4.74 4.69 +1.1% 2.583 2.513
2500.002 2.631 2.631 0.000 ( +0.0% ) 4.90 4.90 +0.2% 2.578 2.518
2500.01 1.315 1.315 0.000 ( +0.0% ) 9.66 9.87 -2.1% 2.258 2.326
2500.011 1.732 1.732 0.000 ( +0.0% ) 5.24 5.30 -1.2% 2.428 2.486
2500.012 1.578 1.578 0.000 ( +0.0% ) 7.44 7.57 -1.8% 2.343 2.365
2500.1 2.193 2.193 0.000 ( +0.0% ) 5.31 5.16 +2.9% 2.052 1.908
2500.2 2.307 2.307 0.000 ( +0.0% ) 6.09 6.08 +0.1% 1.965 1.812
2500.21 1.183 1.183 0.000 ( +0.0% ) 4.35 4.38 -0.7% 2.246 2.165
2500.211 1.547 1.547 0.000 ( +0.0% ) 3.84 3.80 +0.9% 2.330 2.176
2500.3 2.058 2.063 -0.005 ( -0.2% ) 12.70 12.76 -0.5% 1.948 1.783
2500.31 1.256 1.258 -0.003 ( -0.2% ) 20.15 20.03 +0.6% 2.342 2.166
2500.311 1.642 1.646 -0.004 ( -0.2% ) 13.10 13.72 -4.5% 2.428 2.250
2500.312 7.159 7.159 0.000 ( +0.0% ) 1.35 1.39 -2.5% 1.671 1.469
2500.313 1.564 1.564 0.000 ( +0.0% ) 6.52 6.06 +7.6% 1.023 0.720
2500.4 2.058 2.063 -0.005 ( -0.2% ) 12.81 12.76 +0.4% 1.950 1.786
2500.5 19.575 19.575 0.000 ( +0.0% ) 1.16 1.30 -10.7% 1.109 1.337

@mandrenguyen
Copy link
Contributor

What is the change in event size after the latest commit?

@nurfikri89
Copy link
Contributor Author

@mandrenguyen just very slightly lower, 2.6%. Will update in description.

@hqucms
Copy link
Contributor

hqucms commented Feb 16, 2024

+1

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c773400 into cms-sw:master Feb 19, 2024
25 checks passed
cmsbuild added a commit that referenced this pull request Feb 21, 2024
[MiniAOD] Backport of #43965 (Increase AK4 CHS pt cut and remove unsupported taggers for AK4 CHS and AK8 Puppi jets) to 14_0_X
@nurfikri89 nurfikri89 deleted the from1400pre3_CleanupCHSInMini branch February 25, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants