Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NanoAOD] Add EM energy fraction for CorrT1METJet #43966

Conversation

nurfikri89
Copy link
Contributor

PR description:

This PR adds the charged+neutral EM energy fraction branch for the CorrT1METJet table. One of the requirements of the MET Type-1 correction procedure is to only consider jets with EM energy fraction less than 0.9. The main Jet table has the EM energy fractions.

PR validation:

passes the usual runTheMatrix test: runTheMatrix.py -l limited -i all --ibeos

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 14, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43966/38868

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @nurfikri89 (Nurfikri Norjoharuddeen) for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@vlimant, @hqucms, @cmsbuild can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@hqucms
Copy link
Contributor

hqucms commented Feb 15, 2024

enable nano

@hqucms
Copy link
Contributor

hqucms commented Feb 15, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-226b52/37470/summary.html
COMMIT: 612bb90
CMSSW: CMSSW_14_1_X_2024-02-14-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43966/37470/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 97 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 52 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3248554
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3248526
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.815 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 0.121 KiB Physics/NanoAODDQM
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16524
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16524
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.694 KiB( 14 files compared)
  • DQMHistoSizes: changed ( 2500.001,... ): 0.121 KiB Physics/NanoAODDQM
  • Checked 38 log files, 18 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.551 2.545 0.006 ( +0.2% ) 5.28 5.24 +0.6% 2.193 2.156
2500.001 2.700 2.692 0.008 ( +0.3% ) 4.68 4.72 -0.8% 2.227 2.546
2500.002 2.641 2.631 0.009 ( +0.4% ) 4.87 4.90 -0.6% 2.133 2.541
2500.01 1.322 1.315 0.007 ( +0.6% ) 9.33 9.63 -3.1% 2.045 2.255
2500.011 1.745 1.732 0.012 ( +0.7% ) 5.22 5.24 -0.3% 1.968 2.410
2500.012 1.586 1.578 0.008 ( +0.5% ) 7.37 7.51 -1.9% 1.970 2.316
2500.1 2.194 2.193 0.001 ( +0.0% ) 5.28 5.28 +0.0% 2.035 2.054
2500.2 2.310 2.307 0.003 ( +0.1% ) 6.06 6.01 +0.7% 1.917 1.969
2500.21 1.185 1.183 0.002 ( +0.2% ) 4.33 4.34 -0.4% 1.947 2.252
2500.211 1.549 1.547 0.002 ( +0.1% ) 3.71 3.81 -2.6% 2.046 2.325
2500.3 2.065 2.063 0.002 ( +0.1% ) 12.32 12.69 -2.9% 1.934 1.954
2500.31 1.261 1.258 0.002 ( +0.2% ) 19.53 20.19 -3.3% 2.352 2.327
2500.311 1.648 1.646 0.002 ( +0.1% ) 13.12 13.57 -3.3% 2.410 2.418
2500.312 7.159 7.159 0.000 ( +0.0% ) 1.37 1.38 -0.5% 1.682 1.672
2500.313 1.564 1.564 0.000 ( +0.0% ) 6.47 6.89 -6.1% 1.037 1.028
2500.4 2.065 2.063 0.002 ( +0.1% ) 12.39 12.71 -2.5% 1.928 1.954
2500.5 19.575 19.575 0.000 ( +0.0% ) 1.06 1.23 -13.1% 1.120 1.112

@hqucms
Copy link
Contributor

hqucms commented Feb 15, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit eb5debb into cms-sw:master Feb 18, 2024
13 checks passed
cmsbuild added a commit that referenced this pull request Feb 21, 2024
…EMEFrac_CorrT1METJet

[NanoAOD] Backport of #43966 (Add EM energy fraction for CorrT1METJet) to 14_0_X
@nurfikri89 nurfikri89 deleted the from141X_202402141100_nano_addEMEFrac_CorrT1METJet branch February 21, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants