Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NanoAOD] Backport of #43966 (Add EM energy fraction for CorrT1METJet) to 14_0_X #43992

Conversation

nurfikri89
Copy link
Contributor

Backport of #43966

Original PR description:

This PR adds the charged+neutral EM energy fraction branch for the CorrT1METJet table. One of the requirements of the MET Type-1 correction procedure is to only consider jets with EM energy fraction less than 0.9. The main Jet table has the EM energy fractions.

PR validation:

passes the usual runTheMatrix test: runTheMatrix.py -l limited -i all --ibeos

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 16, 2024

A new Pull Request was created by @nurfikri89 (Nurfikri Norjoharuddeen) for CMSSW_14_0_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@vlimant, @cmsbuild, @hqucms can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 16, 2024

cms-bot internal usage

@vlimant
Copy link
Contributor

vlimant commented Feb 16, 2024

enable nano

@vlimant
Copy link
Contributor

vlimant commented Feb 16, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24e6a8/37519/summary.html
COMMIT: 80d25bb
CMSSW: CMSSW_14_0_X_2024-02-15-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43992/37519/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 86 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 57 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3248626
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3248595
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.815 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 0.121 KiB Physics/NanoAODDQM
  • Checked 200 log files, 161 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16524
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16524
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.694 KiB( 14 files compared)
  • DQMHistoSizes: changed ( 2500.001,... ): 0.121 KiB Physics/NanoAODDQM
  • Checked 38 log files, 18 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.551 2.545 0.006 ( +0.2% ) 5.28 5.23 +0.9% 2.153 2.171
2500.001 2.700 2.692 0.008 ( +0.3% ) 4.71 4.69 +0.4% 2.522 2.582
2500.002 2.641 2.631 0.009 ( +0.4% ) 4.88 4.81 +1.5% 2.521 2.582
2500.01 1.322 1.315 0.007 ( +0.6% ) 9.64 9.38 +2.8% 2.279 2.253
2500.011 1.745 1.732 0.012 ( +0.7% ) 5.09 5.14 -0.8% 2.345 2.404
2500.012 1.586 1.578 0.008 ( +0.5% ) 7.37 7.29 +1.1% 2.309 2.371
2500.1 2.194 2.193 0.001 ( +0.0% ) 5.26 5.23 +0.5% 1.966 1.998
2500.2 2.310 2.307 0.003 ( +0.1% ) 6.07 5.99 +1.2% 1.874 1.898
2500.21 1.185 1.183 0.002 ( +0.2% ) 4.31 4.31 -0.2% 2.128 2.207
2500.211 1.549 1.547 0.002 ( +0.1% ) 3.67 3.73 -1.6% 2.178 2.236
2500.3 2.065 2.063 0.002 ( +0.1% ) 12.62 12.38 +1.9% 1.899 1.901
2500.31 1.260 1.259 0.001 ( +0.1% ) 19.96 19.13 +4.3% 2.241 2.251
2500.311 1.650 1.648 0.002 ( +0.1% ) 12.14 11.59 +4.7% 2.253 2.258
2500.312 7.159 7.159 0.000 ( +0.0% ) 1.46 1.36 +7.2% 1.705 1.699
2500.313 1.564 1.564 0.000 ( +0.0% ) 6.58 6.48 +1.6% 1.056 1.051
2500.4 2.065 2.063 0.002 ( +0.1% ) 12.64 12.40 +2.0% 1.877 1.902
2500.5 19.575 19.575 0.000 ( +0.0% ) 1.14 1.09 +5.1% 1.092 1.093

@vlimant
Copy link
Contributor

vlimant commented Feb 20, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3ade401 into cms-sw:CMSSW_14_0_X Feb 21, 2024
12 checks passed
@nurfikri89 nurfikri89 deleted the portFrom141XTo140X_nano_addEMEFrac_CorrT1METJet branch February 21, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants