Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TkAl] miscellaneous updates related to analysis of μμ + vertex events (13.2.X) #42973

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 10, 2023

backport of #42459
backport of #42971

PR description:

See initial descriptions in master PRs.

PR validation:

cmssw compiles

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #42459 and #42971 to the last 2023 data-taking release.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 10, 2023

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_2_X.

It involves the following packages:

  • Alignment/OfflineValidation (alca)
  • DQMOffline/Alignment (dqm)

@nothingface0, @antoniovagnerini, @rvenditti, @syuvivida, @perrotta, @consuegs, @tjavaid, @saumyaphor4252, @cmsbuild can you please review it and eventually sign? Thanks.
@rsreds, @tlampen, @rociovilar, @adewit, @tocheng, @mmusich, @yuanchao this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Oct 10, 2023

@cmsbuild, please test

@mmusich
Copy link
Contributor Author

mmusich commented Oct 10, 2023

The apparent failure in TestDQMOfflineConfigurationGotAll is a pre-existing issue (documented at #42831).

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-090931/35108/summary.html
COMMIT: 07fee56
CMSSW: CMSSW_13_2_X_2023-10-09-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42973/35108/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test TestDQMOfflineConfigurationGotAll had ERRORS

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3198423
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3198398
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1132.131 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): 377.527 KiB AlCaReco/TkAlDiMuonAndVertex
  • DQMHistoSizes: changed ( 1000.0 ): 377.363 KiB AlCaReco/TkAlUpsilonMuMu
  • DQMHistoSizes: changed ( 1000.0 ): 377.240 KiB AlCaReco/TkAlJpsiMuMu
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

backport of #42971
(let the "backport" status depend on the more recent, and by now not yet merged, PR)

@mmusich
Copy link
Contributor Author

mmusich commented Oct 11, 2023

type bug-fix

@mmusich
Copy link
Contributor Author

mmusich commented Oct 11, 2023

@cms-sw/alca-l2 and @cms-sw/dqm-l2 let not the unrelated failure slow down the review!

@mmusich mmusich force-pushed the addUnbalanceForZPointingAngle_13_2_X branch from 07fee56 to 6d05bd7 Compare October 12, 2023 07:09
@cmsbuild
Copy link
Contributor

Pull request #42973 was updated. @tjavaid, @perrotta, @nothingface0, @syuvivida, @rvenditti, @consuegs, @saumyaphor4252, @cmsbuild, @antoniovagnerini can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Oct 12, 2023

please test with #42983

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-090931/35149/summary.html
COMMIT: 6d05bd7
CMSSW: CMSSW_13_2_X_2023-10-11-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42973/35149/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3198659
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3198634
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1132.131 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): 377.527 KiB AlCaReco/TkAlDiMuonAndVertex
  • DQMHistoSizes: changed ( 1000.0 ): 377.363 KiB AlCaReco/TkAlUpsilonMuMu
  • DQMHistoSizes: changed ( 1000.0 ): 377.240 KiB AlCaReco/TkAlJpsiMuMu
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Oct 14, 2023

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit bbbd24b into cms-sw:CMSSW_13_2_X Oct 16, 2023
@mmusich mmusich deleted the addUnbalanceForZPointingAngle_13_2_X branch October 17, 2023 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants