fix mistake in EDM_ML_DEBUG protected section of DiMuonVertexMonitor

[mmusich]

PR description:

Fixes a trivial mistake in the EDM_ML_DEBUG-protected section of DiMuonVertexMonitor, slipped in #42971.
Noticed in the static analyzer checks of PR #42971

PR validation:

Compiled defining EDM_ML_DEBUG as pre-processor directive.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is not a backport, but it will be backported to CMSSW_13.2.X at #42973

[mmusich]

type bug-fix

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42998/37171

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• DQMOffline/Alignment (dqm)

@antoniovagnerini, @tjavaid, @rvenditti, @cmsbuild, @nothingface0, @syuvivida can you please review it and eventually sign? Thanks.
@rociovilar this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from [TkAl] miscellaneous updates related to analysis of μμ + vertex events (13.2.X) #42973

[mmusich]

@cmsbuild, please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-016e6d/35150/summary.html
COMMIT: ca26a83
CMSSW: CMSSW_13_3_X_2023-10-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42998/35150/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 2500.52500.5_ScoutingNanodata13X/step2_ScoutingNanodata13X.log

Comparison Summary

Summary:

• You potentially removed 6 lines from the logs
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3356920
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3356892
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-016e6d/35161/summary.html
COMMIT: ca26a83
CMSSW: CMSSW_13_3_X_2023-10-12-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42998/35161/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3356920
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3356889
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[mmusich]

now static analyzer checks are clean.

[mmusich]

sorry @tjavaid but this is not a backport.

[tjavaid]

sorry @tjavaid but this is not a backport.

I misinterpreted the description of PR then.

[mmusich]

@tjavaid

I misinterpreted the description of PR then.

can you elaborate which part is not clear? In can amend it.
In any case this is a bug-fix for the DBG builds, can you please sign?

[tjavaid]

@tjavaid

I misinterpreted the description of PR then.

can you elaborate which part is not clear? In can amend it. In any case this is a bug-fix for the DBG builds, can you please sign?

@mmusich , it is clear now. thanks!

[tjavaid]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1