[TkAl] Realign DQM and Offline analysis of μμ + vertex events

[mmusich]

PR description:

Title says it all. After offline investigation (mainly from @vbotta) some discrepancy was found when comparing the results from the DiMuonVertexValidation module (in the package Alignment/OfflineValidation) and DiMuonVertexMonitor (in the package DQMOffline/Alignment).
These were traced back to the fact that the DQM module (by default) selects the primary vertex closest to the di-muon vertex, while the one in Alignment/OfflineValidation selects the first one (presumably the hardest in the event, but not guaranteed because there is no re-sorting post-refit). This is addressed in 2e70c3b by offering the user the possibility to use the closest (to X→μμ decay vertex) or the first primary vertex.
The other two commits:

• 79451cf updates slightly the unit test configuration for DiMuonVertexValidation,
• 4839b20 adds some debug statement in DiMuonVertexMonitor, that were useful during the debugging process.

PR validation:

Run successfully:

• scram b runtests_DiMuonVertex use-ibeos
• scram b runtests_testDiMuonVertexMonitor use-ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42971/37140

• This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42971/37140/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42971/37140/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42971/37141

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• Alignment/OfflineValidation (alca)
• DQMOffline/Alignment (dqm)

@nothingface0, @tjavaid, @rvenditti, @cmsbuild, @antoniovagnerini, @saumyaphor4252, @consuegs, @syuvivida, @perrotta can you please review it and eventually sign? Thanks.
@tocheng, @rociovilar, @mmusich, @tlampen, @yuanchao, @adewit, @rsreds this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42971/37145

• This PR adds an extra 28KB to repository

[cmsbuild]

Pull request #42971 was updated. @saumyaphor4252, @nothingface0, @syuvivida, @perrotta, @consuegs, @antoniovagnerini, @rvenditti, @cmsbuild, @tjavaid can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c4b5c5/35112/summary.html
COMMIT: d8087e7
CMSSW: CMSSW_13_3_X_2023-10-09-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42971/35112/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 5 lines from the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3356920
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3356895
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 214 log files, 167 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[perrotta]

+alca

[tjavaid]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1