-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest updates in DQM/TrackingMonitorSource for data/MC comparisons for the Tracking POG #42991
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42991/37164
|
A new Pull Request was created by @dbruschi for master. It involves the following packages:
@rvenditti, @antoniovagnerini, @tjavaid, @cmsbuild, @nothingface0, @syuvivida can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42991/37165
|
Pull request #42991 was updated. @nothingface0, @cmsbuild, @antoniovagnerini, @tjavaid, @rvenditti, @syuvivida can you please check and sign again. |
@cmsbuild, please test |
-1 Failed Tests: UnitTests RelVals-INPUT The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Unit TestsI found 1 errors in the following unit tests: ---> test SiStripDAQ_O2O_test had ERRORS RelVals-INPUT
Comparison SummarySummary:
|
@cmsbuild please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42991/37195
|
Pull request #42991 was updated. @tjavaid, @antoniovagnerini, @cmsbuild, @rvenditti, @nothingface0, @syuvivida can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38300d/35203/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This pull request contains the implementation of the latest distributions and plugins which are used by the Tracking POG for their data/MC comparisons. The main changes are to the StandaloneTrackMonitor plugin: a bug regarding the Z invariant mass and pt distribution has been fixed (they didn't have an impact on the results anyway), the histograms about the error on the IP are now in log scale, for dilepton events the cosphi3d distribution described here: https://indico.cern.ch/event/1312617/contributions/5521545/attachments/2694079/4675527/2023.08.01.misAlignmentPPD.pdf is evaluated.