Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.2.X] Increase number of sequences to be analyzed in DQMOffline/Configuration unit tests #42983

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 11, 2023

fixes #42831

PR description:

As reported in #42831 (comment), it seems that #42714 (more specifically just commit 5e21e71) causes the total number of distinct sequences to grow above the current limit (300) as analyzed by the unit tests of this package.
I merely follow the indications in the commented section of the BuildFile.xml:

<!-- To make sure we actually got all sequences, the last check checks that there are no sequences beyond the last test -->
<!-- This might need to updated when the number of distinct sequences grows, add more rows above and change the number here. -->

N.B. a forward port of this seems not necessary, the total number of sequences appears to be release-dependent

PR validation:

scram b runtests_TestDQMOfflineConfigurationGotAll use-ibeos runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_2_X.

It involves the following packages:

  • DQMOffline/Configuration (dqm)

@antoniovagnerini, @syuvivida, @rvenditti, @tjavaid, @cmsbuild, @nothingface0 can you please review it and eventually sign? Thanks.
@threus, @rociovilar this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich mmusich changed the title Increase number of sequences to be analyzed in DQMOffline/Configuration unit tests [13.2.X ]Increase number of sequences to be analyzed in DQMOffline/Configuration unit tests Oct 11, 2023
@mmusich mmusich changed the title [13.2.X ]Increase number of sequences to be analyzed in DQMOffline/Configuration unit tests [13.2.X] Increase number of sequences to be analyzed in DQMOffline/Configuration unit tests Oct 11, 2023
@mmusich
Copy link
Contributor Author

mmusich commented Oct 11, 2023

please test

@mmusich mmusich marked this pull request as ready for review October 11, 2023 12:16
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fde332/35130/summary.html
COMMIT: 545fbd1
CMSSW: CMSSW_13_2_X_2023-10-11-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42983/35130/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3198423
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3198394
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Oct 14, 2023

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8f34292 into cms-sw:CMSSW_13_2_X Oct 16, 2023
@mmusich mmusich deleted the fix_TestDQMOfflineConfigurationGotAll branch October 16, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants