-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13.2.X] Increase number of sequences to be analyzed in DQMOffline/Configuration
unit tests
#42983
[13.2.X] Increase number of sequences to be analyzed in DQMOffline/Configuration
unit tests
#42983
Conversation
A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_2_X. It involves the following packages:
@antoniovagnerini, @syuvivida, @rvenditti, @tjavaid, @cmsbuild, @nothingface0 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
DQMOffline/Configuration
unit testsDQMOffline/Configuration
unit tests
DQMOffline/Configuration
unit testsDQMOffline/Configuration
unit tests
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fde332/35130/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
fixes #42831
PR description:
As reported in #42831 (comment), it seems that #42714 (more specifically just commit 5e21e71) causes the total number of distinct sequences to grow above the current limit (300) as analyzed by the unit tests of this package.
I merely follow the indications in the commented section of the
BuildFile.xml
:cmssw/DQMOffline/Configuration/test/BuildFile.xml
Lines 11 to 12 in d9d4aec
N.B. a forward port of this seems not necessary, the total number of sequences appears to be release-dependent
PR validation:
scram b runtests_TestDQMOfflineConfigurationGotAll use-ibeos
runs fine.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A