Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] increase number of sequences to be analyzed in DQMOffline/Configuration unit tests #43575

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Dec 15, 2023

forward port of #42983

PR description:

See #42983 (comment). Cures failures in the IB unit tests

PR validation:

scram b runtests_TestDQMOfflineConfigurationGotAll use-ibeos runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but a forward port.

@cmsbuild cmsbuild added this to the CMSSW_14_0_X milestone Dec 15, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 15, 2023

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43575/38210

  • This PR adds an extra 8KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • DQMOffline/Configuration (dqm)

@cmsbuild, @nothingface0, @tjavaid, @antoniovagnerini, @rvenditti, @syuvivida can you please review it and eventually sign? Thanks.
@threus, @rociovilar this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Dec 15, 2023

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-31a6e7/36511/summary.html
COMMIT: 85b3419
CMSSW: CMSSW_14_0_X_2023-12-14-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/43575/36511/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3429858
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3429833
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 214 log files, 167 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Dec 18, 2023

@cms-sw/dqm-l2 do you have comments on this?

@smuzaffar
Copy link
Contributor

@mmusich , sorry I did not see this PR and opened #43586 which is same as this PR but prints the error message why TestDQMOfflineConfigurationGotAll fails. Feel free to either include #43586 changes in this PR or close this in favor of #43586

@mmusich
Copy link
Contributor Author

mmusich commented Dec 18, 2023

closing in favor of #43586

@mmusich mmusich closed this Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants