Adding FatJet trigger objects and filters for #41973

ATumasyan · 2023-06-15T13:34:58Z

PR description:

Added new FatJet trigger Filters with ParticleNet BBTag
Some unnecessary collections and filters were removed to make filterBits more understandable.
In particular:

mksel(["hltAK8SingleCaloJet200"]), # 0 # kept

mksel(["hltAK8DoublePFJet250"]), # 1 # not needed as hltAK8PFJetsCorrected is stored

mksel(["hltAK8DoublePFJet270"]), # 2 # not needed as hltAK8PFJetsCorrected is stored

mksel(["hltAK8DoublePFJetSDModMass30"]), # 3 kept

mksel(["hltAK8DoublePFJetSDModMass50"]), # 4 kept

mksel(["hltAK8PFJetsCorrectedMatchedToCaloJets200"]), # 5 # no need as both "hltAK8PFJetsCorrected" and "hltAK8SingleCaloJet200" are stored

mksel(["hltSingleAK8PFJet220","hltSingleAK8PFJet230"]), # 6 # no need as both "hltAK8PFJetsCorrected" and "hltAK8SingleCaloJet200" (hence hltAK8PFJetsCorrectedMatchedToCaloJets200) are stored.

mksel(["hltAK8PFSoftDropJets220","hltAK8PFSoftDropJets230"]), # kept

mksel(["hltAK8SinglePFJets220SoftDropMass40","hltAK8SinglePFJets230SoftDropMass40"]), # the same as above, this is the only filter which uses the collection above, so removed

mksel(["hltAK8PFJets220SoftDropMass40"]), # could be reached with the filter PNet filters which are added

mksel(["hltAK8SinglePFJets220SoftDropMass40PNetBBTag0p06"]), # 11 # kept

mksel(["hltAK8SinglePFJets230SoftDropMass40PNetTauTauTag0p03"]), # worth to move to boosted Tau

PR validation:

Tested with CMSSW_13_1_0

Added FatJet HHTo4b trigger objects and filters

W.r.t. previous version FatJet with PNet BBTag filters were added Removed some unnecessary collections and filters: 1) mksel(["hltAK8SingleCaloJet200"]), # kept 2) mksel(["hltAK8DoublePFJet250"]), # not needed as hltAK8PFJetsCorrected is stored 3) mksel(["hltAK8DoublePFJet270"]), # not needed as hltAK8PFJetsCorrected is stored 4) mksel(["hltAK8DoublePFJetSDModMass30"]), # kept 5) mksel(["hltAK8DoublePFJetSDModMass50"]), # kept 6) mksel(["hltAK8PFJetsCorrectedMatchedToCaloJets200"]), # no need as both "hltAK8PFJetsCorrected" and "hltAK8SingleCaloJet200" are stored 7) mksel(["hltSingleAK8PFJet220","hltSingleAK8PFJet230"]), # no need as both "hltAK8PFJetsCorrected" and "hltAK8SingleCaloJet200" (hence hltAK8PFJetsCorrectedMatchedToCaloJets200) are stored. 8) mksel(["hltAK8PFSoftDropJets220","hltAK8PFSoftDropJets230"]), # kept 9) mksel(["hltAK8SinglePFJets220SoftDropMass40","hltAK8SinglePFJets230SoftDropMass40"]), # the same as above, this is the only filter which uses the collection above 10) mksel(["hltAK8PFJets220SoftDropMass40"]), # could be reached with the filter bellow 11) mksel(["hltAK8SinglePFJets220SoftDropMass40PNetBBTag0p06"]), # kept 12) mksel(["hltAK8SinglePFJets230SoftDropMass40PNetTauTauTag0p03"]), # move to boosted tau

Adding FatJet Trigger objects and filters

cmsbuild · 2023-06-15T13:42:10Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41973/35937

This PR adds an extra 20KB to repository

cmsbuild · 2023-06-15T13:42:34Z

A new Pull Request was created by @ATumasyan for master.

It involves the following packages:

PhysicsTools/NanoAOD (xpog)

@cmsbuild, @simonepigazzini, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

simonepigazzini · 2023-06-15T14:11:58Z

enable nano

simonepigazzini · 2023-06-15T14:12:03Z

please test

cmsbuild · 2023-06-15T16:37:48Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ad2fc9/33185/summary.html
COMMIT: 7648470
CMSSW: CMSSW_13_2_X_2023-06-15-1100/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41973/33185/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 16 lines to the logs
Reco comparison results: 15 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3196062
DQMHistoTests: Total failures: 34
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3196006
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 207 log files, 159 edm output root files, 48 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 143 differences found in the comparisons
DQMHistoTests: Total files compared: 15
DQMHistoTests: Total histograms compared: 15505
DQMHistoTests: Total failures: 143
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 15362
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
Checked 31 log files, 14 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.446	2.438	0.008 ( +0.3% )	5.46	5.30	+3.1%	2.110	1.987
2500.001	2.552	2.546	0.007 ( +0.3% )	4.89	4.74	+3.3%	2.545	2.034
2500.002	2.497	2.491	0.006 ( +0.2% )	5.09	4.87	+4.5%	2.524	2.028
2500.01	1.240	1.240	0.000 ( +0.0% )	10.20	9.53	+7.0%	2.226	2.065
2500.011	1.604	1.603	0.000 ( +0.0% )	5.43	5.16	+5.4%	2.426	1.867
2500.012	1.485	1.485	0.000 ( +0.0% )	7.83	7.38	+6.1%	2.337	1.840
2500.1	2.158	2.153	0.005 ( +0.2% )	5.51	5.37	+2.6%	1.969	1.839
2500.2	2.271	2.260	0.011 ( +0.5% )	4.61	5.59	-17.6%	1.892	1.696
2500.21	1.146	1.145	0.001 ( +0.1% )	4.46	4.38	+1.9%	2.177	1.740
2500.211	1.504	1.503	0.001 ( +0.1% )	3.94	3.67	+7.6%	2.250	1.778
2500.3	2.008	1.998	0.010 ( +0.5% )	14.06	12.94	+8.7%	1.694	1.600
2500.31	1.209	1.207	0.002 ( +0.1% )	20.67	18.51	+11.6%	2.090	1.970
2500.311	1.585	1.584	0.001 ( +0.1% )	15.82	14.48	+9.3%	2.158	2.019
2500.4	2.008	1.998	0.010 ( +0.5% )	13.93	13.01	+7.1%	1.691	1.694

simonepigazzini · 2023-06-19T13:18:25Z

@mstamenk, @ATumasyan can you please clarify the overlap between this PR and the one we merged some weeks ago: #41692 ?

ATumasyan · 2023-06-19T15:18:05Z

@simonepigazzini I checked and found out, that with the previous modification the output did not contain all the filters and collections, which were added. The reason was the line:
sel = cms.string("type(85) && pt > 120 && coll('hltAK8PFJetsCorrected')")
which now modified to
sel = cms.string("type(85) && pt > 120")
Second point is, that some of the previously added lines (filters and collections) can be skipped (please see the description at the very top), making trigger_bits more understandable

vlimant · 2023-06-28T11:55:15Z

@mstamenk can you please confirm ; and then we need the adequate back port to 13.0 and 13.1 if you want this in prompt.
#41985 and #41974

mstamenk · 2023-06-28T12:16:52Z

Hi @ATumasyan ,

mksel(["hltAK8SinglePFJets230SoftDropMass40PNetTauTauTag0p03"]), # worth to move to boosted Tau

I only see it removed so far, is this expected?

Regarding the rest, I think I agree with the updates.

ATumasyan · 2023-06-28T12:27:57Z

Hi @mstamenk
Yes, I only removed it, but I think it was already included in boosted Tau: id = cms.int32(1515)

mstamenk · 2023-06-28T12:36:28Z

But if I have 2 boosted taus, how do I know which one fired the trigger?

ATumasyan · 2023-06-28T12:48:31Z

@mstamenk as far as I understand "hltAK8SinglePFJets230SoftDropMass40PNetTauTauTag0p03" is looking for boosted pair of Taus. Not really sure that I understand the question correctly, but basically it should be with the trigger object matching.
And for that you need to store needed trigger object (or filter).
What I was saying, is that "hltAK8SinglePFJets230SoftDropMass40PNetTauTauTag0p03" filter was already stored in BoostedTau block. And if it worked there properly (I did not checked), then there is no need to add this filter once again in FatJet block.

mstamenk · 2023-06-28T12:50:20Z

Ah apologies, I should have checked and I missed that point.

All good, thanks a lot for the update!

Looks good on my side!

simonepigazzini · 2023-06-30T08:06:16Z

+xpog

@ATumasyan, can you please open backports to 13_1_X and 13_0_X such that we can have this eventually deployed for prompt nano? Thank you.

cmsbuild · 2023-06-30T08:06:41Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2023-06-30T08:14:45Z

please test
(past ones has expired)

cmsbuild · 2023-06-30T12:11:02Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ad2fc9/33481/summary.html
COMMIT: 7648470
CMSSW: CMSSW_13_2_X_2023-06-29-2300/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41973/33481/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 7 lines from the logs
Reco comparison results: 3795 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3193832
DQMHistoTests: Total failures: 3932
DQMHistoTests: Total nulls: 55
DQMHistoTests: Total successes: 3189823
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
Checked 207 log files, 159 edm output root files, 48 DQM output files
TriggerResults: found differences in 1 / 46 workflows

NANO Comparison Summary

Summary:

You potentially removed 6 lines from the logs
Reco comparison results: 143 differences found in the comparisons
DQMHistoTests: Total files compared: 15
DQMHistoTests: Total histograms compared: 15505
DQMHistoTests: Total failures: 143
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 15362
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
Checked 31 log files, 14 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.0	2.443	2.436	0.008 ( +0.3% )	5.48	5.00	+9.6%	2.110	1.817
2500.001	2.552	2.546	0.007 ( +0.3% )	4.91	4.41	+11.2%	2.557	2.400
2500.002	2.497	2.491	0.006 ( +0.2% )	5.10	4.58	+11.2%	2.536	2.241
2500.01	1.240	1.240	0.000 ( +0.0% )	10.04	9.00	+11.6%	2.232	1.899
2500.011	1.604	1.603	0.000 ( +0.0% )	5.39	4.67	+15.2%	2.429	2.065
2500.012	1.485	1.485	0.000 ( +0.0% )	7.82	6.85	+14.1%	2.336	2.017
2500.1	2.169	2.163	0.006 ( +0.3% )	5.50	4.98	+10.4%	1.982	1.690
2500.2	2.271	2.260	0.011 ( +0.5% )	6.29	5.80	+8.5%	1.886	1.580
2500.21	1.146	1.145	0.001 ( +0.1% )	4.51	3.75	+20.3%	2.177	1.869
2500.211	1.504	1.503	0.001 ( +0.1% )	3.92	3.30	+18.8%	2.250	1.872
2500.3	2.008	1.998	0.010 ( +0.5% )	13.91	15.55	-10.6%	1.692	1.411
2500.31	1.209	1.207	0.002 ( +0.1% )	22.21	25.19	-11.8%	2.094	1.747
2500.311	1.585	1.584	0.001 ( +0.1% )	15.88	16.89	-6.0%	2.165	1.787
2500.4	2.008	1.998	0.010 ( +0.5% )	13.88	15.49	-10.4%	1.695	1.410

perrotta · 2023-06-30T15:15:15Z

+1

ATumasyan · 2023-06-30T15:35:37Z

@simonepigazzini

can you please open backports to 13_1_X and 13_0_X such that we can have this eventually deployed for prompt nano?
I'm sorry, but I don't really understand what should I do, can you please instruct, I'm not good at git

simonepigazzini · 2023-07-03T07:55:33Z

Hi, you should make the same changes starting from one of the most recent 13_0_X and 13_1_X releases, and open to pull request selecting as branch not the master (as done for this one) but the 13_0_X and 13_1_X branches. See this one as an example #41985.

ATumasyan added 3 commits June 9, 2023 19:54

Update triggerObjects_cff.py

ba0b126

Added FatJet HHTo4b trigger objects and filters

Update triggerObjects_cff.py

7648470

Adding FatJet Trigger objects and filters

cmsbuild added this to the CMSSW_13_2_X milestone Jun 15, 2023

cmsbuild added pending-signatures tests-pending orp-pending code-checks-pending xpog-pending labels Jun 15, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 15, 2023

cmsbuild added tests-started and removed tests-pending labels Jun 15, 2023

cmsbuild added tests-approved and removed tests-started labels Jun 15, 2023

cmsbuild mentioned this pull request Jun 20, 2023

Adding filter flag to SiStripApproximateClusters #41815

Merged

cmsbuild added fully-signed xpog-approved and removed pending-signatures xpog-pending labels Jun 30, 2023

cmsbuild added tests-started and removed tests-approved labels Jun 30, 2023

cmsbuild added tests-approved and removed tests-started labels Jun 30, 2023

cmsbuild added orp-approved and removed orp-pending labels Jun 30, 2023

cmsbuild merged commit 5146003 into cms-sw:master Jun 30, 2023

This was referenced Jul 3, 2023

Update triggerObjects_cff.py #42173

Merged

Update triggerObjects_cff.py #42174

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding FatJet trigger objects and filters for #41973

Adding FatJet trigger objects and filters for #41973

ATumasyan commented Jun 15, 2023

cmsbuild commented Jun 15, 2023

cmsbuild commented Jun 15, 2023

simonepigazzini commented Jun 15, 2023

simonepigazzini commented Jun 15, 2023

cmsbuild commented Jun 15, 2023

simonepigazzini commented Jun 19, 2023

ATumasyan commented Jun 19, 2023

vlimant commented Jun 28, 2023

mstamenk commented Jun 28, 2023

ATumasyan commented Jun 28, 2023

mstamenk commented Jun 28, 2023

ATumasyan commented Jun 28, 2023

mstamenk commented Jun 28, 2023 •

edited

Loading

simonepigazzini commented Jun 30, 2023

cmsbuild commented Jun 30, 2023

perrotta commented Jun 30, 2023

cmsbuild commented Jun 30, 2023

perrotta commented Jun 30, 2023

ATumasyan commented Jun 30, 2023

simonepigazzini commented Jul 3, 2023

Adding FatJet trigger objects and filters for #41973

Adding FatJet trigger objects and filters for #41973

Conversation

ATumasyan commented Jun 15, 2023

PR description:

PR validation:

cmsbuild commented Jun 15, 2023

cmsbuild commented Jun 15, 2023

simonepigazzini commented Jun 15, 2023

simonepigazzini commented Jun 15, 2023

cmsbuild commented Jun 15, 2023

Comparison Summary

NANO Comparison Summary

simonepigazzini commented Jun 19, 2023

ATumasyan commented Jun 19, 2023

vlimant commented Jun 28, 2023

mstamenk commented Jun 28, 2023

ATumasyan commented Jun 28, 2023

mstamenk commented Jun 28, 2023

ATumasyan commented Jun 28, 2023

mstamenk commented Jun 28, 2023 • edited Loading

simonepigazzini commented Jun 30, 2023

cmsbuild commented Jun 30, 2023

perrotta commented Jun 30, 2023

cmsbuild commented Jun 30, 2023

Comparison Summary

NANO Comparison Summary

perrotta commented Jun 30, 2023

ATumasyan commented Jun 30, 2023

simonepigazzini commented Jul 3, 2023

mstamenk commented Jun 28, 2023 •

edited

Loading