Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update triggerObjects_cff.py #42173

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Conversation

ATumasyan
Copy link
Contributor

Adding FatJet trigger objects and filters for nanoAOD

PR description:

Adding FatJet trigger objects and filters

PR validation:

Tested with CMSSW_13_1_0

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

#41973

Adding FatJet trigger objects and filters for nanoAOD
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2023

A new Pull Request was created by @ATumasyan for CMSSW_13_1_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @simonepigazzini, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@iarspider
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2023

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dcfac3/33518/summary.html
COMMIT: 227dbfe
CMSSW: CMSSW_13_1_X_2023-07-03-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42173/33518/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

  • You potentially removed 14 lines from the logs
  • Reco comparison results: 15 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3222811
  • DQMHistoTests: Total failures: 36
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3222753
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@simonepigazzini
Copy link
Contributor

enable nano

@simonepigazzini
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dcfac3/33526/summary.html
COMMIT: 227dbfe
CMSSW: CMSSW_13_1_X_2023-07-03-1100/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42173/33526/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3222811
  • DQMHistoTests: Total failures: 36
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3222753
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 110 differences found in the comparisons
  • DQMHistoTests: Total files compared: 12
  • DQMHistoTests: Total histograms compared: 12351
  • DQMHistoTests: Total failures: 110
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 12241
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 11 files compared)
  • Checked 25 log files, 11 edm output root files, 12 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.31 2.443 2.435 0.008 ( +0.3% ) 5.40 5.37 +0.7% 2.106 2.104
2500.311 2.552 2.545 0.007 ( +0.3% ) 4.78 4.86 -1.6% 2.538 2.545
2500.312 2.497 2.491 0.006 ( +0.2% ) 5.00 5.00 -0.0% 2.520 2.527
2500.33 1.240 1.240 0.000 ( +0.0% ) 10.23 10.20 +0.3% 2.239 2.223
2500.331 1.603 1.603 0.000 ( +0.0% ) 5.44 5.45 -0.2% 2.422 2.423
2500.332 1.485 1.485 0.000 ( +0.0% ) 7.88 7.85 +0.5% 2.340 2.332
2500.401 2.168 2.163 0.006 ( +0.3% ) 5.41 5.44 -0.6% 1.973 1.976
2500.501 1.762 1.753 0.009 ( +0.5% ) 9.21 9.29 -0.9% 1.846 1.850
2500.511 1.146 1.145 0.001 ( +0.1% ) 4.46 4.49 -0.6% 2.169 2.173
2500.5111 1.504 1.503 0.001 ( +0.1% ) 4.00 3.96 +0.8% 2.248 2.246
2500.601 2.025 2.015 0.011 ( +0.5% ) 13.11 13.02 +0.7% 1.730 1.729

@perrotta
Copy link
Contributor

perrotta commented Jul 4, 2023

backport of #41973

@simonepigazzini
Copy link
Contributor

+1

same changes as in the master PR

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Jul 4, 2023

+1

@cmsbuild cmsbuild merged commit e550e67 into cms-sw:CMSSW_13_1_X Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants