Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trigger filter bits - backport to CMSSW_13_1_X #41985

Merged
merged 3 commits into from
Jun 28, 2023

Conversation

mstamenk
Copy link

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 16, 2023

A new Pull Request was created by @mstamenk (Marko Stamenkovic) for CMSSW_13_1_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @simonepigazzini, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@simonepigazzini
Copy link
Contributor

enable nano

@simonepigazzini
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-308088/33224/summary.html
COMMIT: c3de7dc
CMSSW: CMSSW_13_1_X_2023-06-18-2300/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41985/33224/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 18 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3221591
  • DQMHistoTests: Total failures: 34
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3221535
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 55 differences found in the comparisons
  • DQMHistoTests: Total files compared: 12
  • DQMHistoTests: Total histograms compared: 12351
  • DQMHistoTests: Total failures: 100
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 12251
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 11 files compared)
  • Checked 25 log files, 11 edm output root files, 12 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.31 2.435 2.435 0.000 ( +0.0% ) 5.33 5.34 -0.3% 2.101 2.103
2500.311 2.545 2.545 0.000 ( +0.0% ) 4.80 4.81 -0.1% 2.541 2.533
2500.312 2.491 2.491 0.000 ( +0.0% ) 5.00 4.97 +0.5% 2.527 2.528
2500.33 1.240 1.240 0.000 ( +0.0% ) 10.23 10.24 -0.2% 2.226 2.232
2500.331 1.603 1.603 0.000 ( +0.0% ) 5.41 5.40 +0.3% 2.424 2.416
2500.332 1.485 1.485 0.000 ( +0.0% ) 7.83 7.81 +0.2% 2.329 2.335
2500.401 2.163 2.163 -0.000 ( -0.0% ) 5.41 5.41 +0.1% 2.004 1.980
2500.501 1.753 1.752 0.001 ( +0.1% ) 9.22 9.20 +0.3% 1.851 1.852
2500.511 1.145 1.144 0.001 ( +0.1% ) 4.50 4.50 -0.0% 2.165 2.173
2500.5111 1.503 1.502 0.000 ( +0.0% ) 3.98 3.95 +0.6% 2.228 2.249
2500.601 2.015 2.014 0.001 ( +0.0% ) 13.20 12.99 +1.6% 1.729 1.733

@perrotta
Copy link
Contributor

backport of #41692

@vlimant
Copy link
Contributor

vlimant commented Jun 28, 2023

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d3db02c into cms-sw:CMSSW_13_1_X Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants