Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trigger filter bits in CMSSW - backport to 13_0 #41974

Merged
merged 3 commits into from
Jun 28, 2023

Conversation

mstamenk
Copy link

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 15, 2023

A new Pull Request was created by @mstamenk (Marko Stamenkovic) for CMSSW_13_0_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @simonepigazzini, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@simonepigazzini
Copy link
Contributor

enable nano

@simonepigazzini
Copy link
Contributor

please test

@simonepigazzini
Copy link
Contributor

verbatim backport #41692

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9ac5fe/33184/summary.html
COMMIT: b09957e
CMSSW: CMSSW_13_0_X_2023-06-15-1100/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41974/33184/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 164 lines to the logs
  • Reco comparison results: 305 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3315916
  • DQMHistoTests: Total failures: 4224
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3311670
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially removed 6 lines from the logs
  • Reco comparison results: 55 differences found in the comparisons
  • DQMHistoTests: Total files compared: 12
  • DQMHistoTests: Total histograms compared: 12351
  • DQMHistoTests: Total failures: 100
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 12251
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 11 files compared)
  • Checked 25 log files, 11 edm output root files, 12 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.31 2.438 2.438 0.000 ( +0.0% ) 5.44 5.36 +1.4% 2.111 2.110
2500.311 2.545 2.545 0.000 ( +0.0% ) 4.82 4.85 -0.7% 2.544 2.545
2500.312 2.491 2.491 0.000 ( +0.0% ) 5.03 4.98 +1.1% 2.524 2.519
2500.33 1.240 1.240 0.000 ( +0.0% ) 10.23 10.32 -0.8% 2.229 2.228
2500.331 1.603 1.603 0.000 ( +0.0% ) 5.50 5.46 +0.8% 2.423 2.427
2500.332 1.485 1.485 0.000 ( +0.0% ) 7.90 7.94 -0.6% 2.330 2.336
2500.401 2.153 2.153 -0.000 ( -0.0% ) 5.49 5.46 +0.7% 1.977 1.971
2500.501 1.753 1.752 0.001 ( +0.1% ) 9.39 9.30 +0.9% 1.854 1.857
2500.511 1.145 1.144 0.001 ( +0.1% ) 4.50 4.52 -0.5% 2.177 2.182
2500.5111 1.503 1.502 0.000 ( +0.0% ) 4.07 4.01 +1.5% 2.248 2.243
2500.601 2.015 2.014 0.001 ( +0.0% ) 12.91 12.96 -0.4% 1.736 1.735

@perrotta
Copy link
Contributor

backport of #41692

@perrotta
Copy link
Contributor

@mstamenk did you also prepare the backport for 13_1_X?
If not, please do so, if you want to backport in the older 13_0_X, as here

@mstamenk
Copy link
Author

Hi @perrotta , I did, here the PR: #41985 (comment)

@vlimant
Copy link
Contributor

vlimant commented Jun 28, 2023

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 512df87 into cms-sw:CMSSW_13_0_X Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants