Change of GE21 layouts and plots, and VFAT status with VFAT mask and missing VFATs

[quark2]

PR description:

In this PR, plots for GE21 have been divided into module(+layer). In the same manner, the cells for GE21 in the summary plot have been rearranged by module(+layer).

Also, masked VFATs and error/warning status of missing VFATs are now being displayed.

PR validation:

Tests are done with cmsRun $CMSSW_RELEASE_BASE/src/DQM/Integration/python/clients/gem_dqm_sourceclient-live_cfg.py unitTest=True runNumber=362760 dataset=/ExpressPhysics/Run2022G-Express-v1/FEVT minLumi=19 maxLumi=21 and runTheMatrix.py -l limited -i all --ibeos since it makes effects on P5

@jshlee @watson-ij @seungjin-yang @yeckang

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41915/35871

• This PR adds an extra 44KB to repository

[cmsbuild]

A new Pull Request was created by @quark2 for master.

It involves the following packages:

• DQM/GEM (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@watson-ij this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[emanueleusai]

type gem

[emanueleusai]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-150264/33111/summary.html
COMMIT: 0caf4c4
CMSSW: CMSSW_13_2_X_2023-06-12-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41915/33111/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 7 lines to the logs
• Reco comparison results: 239 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3190409
• DQMHistoTests: Total failures: 96
• DQMHistoTests: Total nulls: 52
• DQMHistoTests: Total successes: 3190239
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 4020.061 KiB( 47 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): 9.615 KiB GEM/Digis
• DQMHistoSizes: changed ( 11634.0,... ): -1.617 KiB GEM/DAQStatus
• DQMHistoSizes: changed ( 11634.0,... ): -0.161 KiB GEM/EventInfo
• DQMHistoSizes: changed ( 23234.0,... ): 664.605 KiB GEM/Digis
• DQMHistoSizes: changed ( 23234.0,... ): -3.938 KiB GEM/DAQStatus
• DQMHistoSizes: changed ( 23234.0,... ): 0.199 KiB GEM/EventInfo
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[emanueleusai]

+1

• diffs in tracking DQM plots unrelated to this PR

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

@quark2 please check the new warnings in Phase2 workflows, e.g.23634.0 TTbar_14TeV+2026D95:

%MSG-e GEMDigiSource:  GEMDigiSource:GEMDigiSource 13-Jun-2023 07:42:31 CEST  Run: 1 Event: 2
WARNING: Cannot find the histogram corresponing to the given key

%MSG
%MSG-e GEMDigiSource:  GEMDigiSource:GEMDigiSource 13-Jun-2023 07:42:31 CEST  Run: 1 Event: 2
WARNING: Cannot find the histogram corresponing to the given key

%MSG

[cmsbuild]

Pull request #41915 was updated. @nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please check and sign again.

[emanueleusai]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-150264/33729/summary.html
COMMIT: bde8f35
CMSSW: CMSSW_13_2_X_2023-07-17-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41915/33729/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 17 lines from the logs
• Reco comparison results: 53 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3195133
• DQMHistoTests: Total failures: 260
• DQMHistoTests: Total nulls: 52
• DQMHistoTests: Total successes: 3194799
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 4020.061 KiB( 47 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): 9.615 KiB GEM/Digis
• DQMHistoSizes: changed ( 11634.0,... ): -1.617 KiB GEM/DAQStatus
• DQMHistoSizes: changed ( 11634.0,... ): -0.161 KiB GEM/EventInfo
• DQMHistoSizes: changed ( 23234.0,... ): 664.605 KiB GEM/Digis
• DQMHistoSizes: changed ( 23234.0,... ): -3.938 KiB GEM/DAQStatus
• DQMHistoSizes: changed ( 23234.0,... ): 0.199 KiB GEM/EventInfo
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[rappoccio]

unhold

[emanueleusai]

+1

• DQM differences in GEM consequence of the PR, other changes in Btag and JetMET are unrelated to PR

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1