-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add on GE21-M-L1 and GE21-P-L2 plots #1306
Conversation
Hi @Dongwoon77, your changes have been incorporated in HG2402b release and deployed in the testbed VMs. Kindly validate, thanks! |
GEMLayout(dqmitems, 'Common/06 GE21-P-L2-M2 Lumi-based chamber status', | ||
[{'path': 'GEM/EventInfo/chamberStatus_inLumi_GE21-P-L2-M2', 'description': 'Lumi-based chamber status in GE21-P-L2-M2'}], | ||
GEMLayout(dqmitems, 'Common/06 GE21-M-L1-M2 Lumi-based chamber status', | ||
[{'path': 'GEM/EventInfo/chamberStatus_inLumi_GE21-M-L1-M2', 'description': 'Lumi-based chamber status in GE21-M-L1-M2'}], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dongwoon77 Is this correct? When we check inside the ROOT files created by the DQM GEM client we still see chamberStatus_inLumi_GE21-P-L2-M2
but no chamberStatus_inLumi_GE21-M-L1-M2
:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dongwoon77 please confirm this so that we can proceed with the deployment.
This link is some of the lines matching to GE21-P-L2 module [1] I didn't edit that, but this lines were pushed back at code so It looks like difference at git-diff. and no plots for GE21-M-L1 are not implemented in the central P5 DQM currently, but it will be added in the coming runs. Thank you! |
@Dongwoon77 Just to make sure, this means that this PR is fine as it is for now? |
Yep, we have checked that this PR looks fine. Thank you! |
PR description:
This PR is related to PRs on cms-sw; see
cms-sw/cmssw#41915 (to master)
cms-sw/cmssw#42483 (backport)