Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add on GE21-M-L1 and GE21-P-L2 plots #1306

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

Dongwoon77
Copy link
Contributor

PR description:

  • replace GE21-M-L2 with GE21-M-L1
  • Lumi-based chamber status, OptoHybrid status and VFAT status (chamber vs. VFAT)
  • Add on GE21-M-L1 recohits occupancy and average cluster plots
  • Add on GE21-M AMC status plot.

This PR is related to PRs on cms-sw; see
cms-sw/cmssw#41915 (to master)
cms-sw/cmssw#42483 (backport)

@arooshap arooshap merged commit b068c1d into dmwm:master Mar 7, 2024
@arooshap
Copy link
Member

arooshap commented Mar 7, 2024

Hi @Dongwoon77,

your changes have been incorporated in HG2402b release and deployed in the testbed VMs. Kindly validate, thanks!

@Dongwoon77
Copy link
Contributor Author

Dear @arooshap.

Sure, I'll test it with #1304 PR.

GEMLayout(dqmitems, 'Common/06 GE21-P-L2-M2 Lumi-based chamber status',
[{'path': 'GEM/EventInfo/chamberStatus_inLumi_GE21-P-L2-M2', 'description': 'Lumi-based chamber status in GE21-P-L2-M2'}],
GEMLayout(dqmitems, 'Common/06 GE21-M-L1-M2 Lumi-based chamber status',
[{'path': 'GEM/EventInfo/chamberStatus_inLumi_GE21-M-L1-M2', 'description': 'Lumi-based chamber status in GE21-M-L1-M2'}],
Copy link
Contributor

@nothingface0 nothingface0 Mar 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dongwoon77 Is this correct? When we check inside the ROOT files created by the DQM GEM client we still see chamberStatus_inLumi_GE21-P-L2-M2 but no chamberStatus_inLumi_GE21-M-L1-M2:

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dongwoon77 please confirm this so that we can proceed with the deployment.

@Dongwoon77
Copy link
Contributor Author

Hi @arooshap @nothingface0.

This link is some of the lines matching to GE21-P-L2 module [1]

I didn't edit that, but this lines were pushed back at code so It looks like difference at git-diff.

and no plots for GE21-M-L1 are not implemented in the central P5 DQM currently, but it will be added in the coming runs.

[1] https://github.com/Dongwoon77/deployment/blob/GEMOnlineDQMForFullGE21/dqmgui/layouts/gem-layouts.py#L56-L75

Thank you!

@nothingface0
Copy link
Contributor

nothingface0 commented Mar 14, 2024

Hi @arooshap @nothingface0.

This link is some of the lines matching to GE21-P-L2 module [1]

I didn't edit that, but this lines were pushed back at code so It looks like difference at git-diff.

and no plots for GE21-M-L1 are not implemented in the central P5 DQM currently, but it will be added in the coming runs.

[1] Dongwoon77/deployment@GEMOnlineDQMForFullGE21/dqmgui/layouts/gem-layouts.py#L56-L75

Thank you!

@Dongwoon77 Just to make sure, this means that this PR is fine as it is for now?

@Dongwoon77
Copy link
Contributor Author

@nothingface0

Yep, we have checked that this PR looks fine.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants