Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_2_X] Change of GE21 layouts and plots, and VFAT status with VFAT mask and missing VFATs #42483

Conversation

quark2
Copy link
Contributor

@quark2 quark2 commented Aug 7, 2023

PR description:

In this PR, plots for GE21 have been divided into modules (+layers). In the same manner, the cells for GE21 in the summary plot have been rearranged by module(+layer).

Also, masked VFATs and error/warning status of missing VFATs are now being displayed.

This is a backport of #41915 to 13_2_X.

PR validation:

Tests are done with cmsRun $CMSSW_RELEASE_BASE/src/DQM/Integration/python/clients/gem_dqm_sourceclient-live_cfg.py unitTest=True runNumber=362760 dataset=/ExpressPhysics/Run2022G-Express-v1/FEVT minLumi=19 maxLumi=21 and runTheMatrix.py -l limited -i all --ibeos since it makes effects on P5

@jshlee @watson-ij @seungjin-yang @yeckang

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2023

A new Pull Request was created by @quark2 for CMSSW_13_2_X.

It involves the following packages:

  • DQM/GEM (dqm)
  • Validation/MuonGEMHits (dqm)

@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@jshlee, @missirol, @JanFSchulte, @watson-ij this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Aug 7, 2023

backport of #41915

@perrotta
Copy link
Contributor

perrotta commented Aug 7, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2023

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49d896/34116/summary.html
COMMIT: 2b0d37f
CMSSW: CMSSW_13_2_X_2023-08-06-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42483/34116/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 1351.0DAS Error
  • 1352.0DAS Error
  • 1364.0DAS Error

Comparison Summary

Summary:

  • You potentially added 10 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3195837
  • DQMHistoTests: Total failures: 38
  • DQMHistoTests: Total nulls: 52
  • DQMHistoTests: Total successes: 3195725
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 4020.061 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 9.615 KiB GEM/Digis
  • DQMHistoSizes: changed ( 11634.0,... ): -1.617 KiB GEM/DAQStatus
  • DQMHistoSizes: changed ( 11634.0,... ): -0.161 KiB GEM/EventInfo
  • DQMHistoSizes: changed ( 23234.0,... ): 664.605 KiB GEM/Digis
  • DQMHistoSizes: changed ( 23234.0,... ): -3.938 KiB GEM/DAQStatus
  • DQMHistoSizes: changed ( 23234.0,... ): 0.199 KiB GEM/EventInfo
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

type gem

@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-49d896/34126/summary.html
COMMIT: 2b0d37f
CMSSW: CMSSW_13_2_X_2023-08-07-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42483/34126/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3195837
  • DQMHistoTests: Total failures: 35
  • DQMHistoTests: Total nulls: 52
  • DQMHistoTests: Total successes: 3195728
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 4020.061 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 9.615 KiB GEM/Digis
  • DQMHistoSizes: changed ( 11634.0,... ): -1.617 KiB GEM/DAQStatus
  • DQMHistoSizes: changed ( 11634.0,... ): -0.161 KiB GEM/EventInfo
  • DQMHistoSizes: changed ( 23234.0,... ): 664.605 KiB GEM/Digis
  • DQMHistoSizes: changed ( 23234.0,... ): -3.938 KiB GEM/DAQStatus
  • DQMHistoSizes: changed ( 23234.0,... ): 0.199 KiB GEM/EventInfo
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

testing 13_0 at p5

@emanueleusai
Copy link
Member

+1

  • p5 tests ok

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants