-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[13_0_X] Change of GE21 layouts and plots, and VFAT status with VFAT mask and missing VFATs #42482
[13_0_X] Change of GE21 layouts and plots, and VFAT status with VFAT mask and missing VFATs #42482
Conversation
A new Pull Request was created by @quark2 for CMSSW_13_0_X. It involves the following packages:
@nothingface0, @emanueleusai, @cmsbuild, @pmandrik, @syuvivida, @tjavaid, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
backport of #41915 |
please test |
@quark2 please provide in addition at least the backport to the next data taking release cycle, 13_2_X. |
Hi @perrotta, Okay, I'll make the backport soon. How about a backport to 13_1_X? |
Ahh, never mind. I was told I don't need to consider 13_1_X. |
-1 Failed Tests: RelVals-INPUT RelVals-INPUTThe relvals timed out after 4 hours. Comparison SummarySummary:
|
type gem |
please test |
@quark2 do you need this in online DQM machines? |
Hi @emanueleusai, Yep, I need it in the DQM machine. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-79fb6f/34127/summary.html Comparison SummarySummary:
|
testing at p5 |
+1
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
By the way, there is backport to 13_0_X and 13_2_X but not to 13_1_X: I imagine that it is not needed by @cms-sw/dqm-l2 in that intermediate release intended for Phase2 |
PR description:
In this PR, plots for GE21 have been divided into modules (+layers). In the same manner, the cells for GE21 in the summary plot have been rearranged by module(+layer).
Also, masked VFATs and error/warning status of missing VFATs are now being displayed.
This is a backport of #41915 to 13_0_X.
PR validation:
Tests are done with
cmsRun $CMSSW_RELEASE_BASE/src/DQM/Integration/python/clients/gem_dqm_sourceclient-live_cfg.py unitTest=True runNumber=362760 dataset=/ExpressPhysics/Run2022G-Express-v1/FEVT minLumi=19 maxLumi=21
andrunTheMatrix.py -l limited -i all --ibeos
since it makes effects on P5@jshlee @watson-ij @seungjin-yang @yeckang