[13_0_X] Combined backport of developments in CalibTracker/SiStripHitEfficiency

[mmusich]

backport of #41065
backport of #41050
backport of #40963

PR description:

The goal of this PR is to backport for 2023 data-taking several fixes and improvements proposed in the master branch for the CalibTracker/SiStripHitEfficiency package.

• 76c3ff3: resolved the SIGSEV issues observed in the master ASAN_X IBs: here for CalibTracker/SiStripHitEfficiency
• 13a7f1b: apply CMS code rules in SiStripHitEffFromCalibTree
• 4ad0244 : remove unused methods
• b40891c : range based loops in StripHitEffFromCalibTree
• ec62881 : implements in SiStripHitEfficiencyHarvester a generic function for summary plots of efficiency trends per layer vs variable (PU, inst. lumi, bx number) This will show up directly in the GUI efficiency plots vs event quantities.
• 7046634 : introduces a more refined error treatment in trend of efficiency vs lumi, PU and BX in SiStripHitEfficiencyHarvester, using Clopper-Pearson confidence interval instead of naive binomial errors.
• 7046634 : use uniform convention for data-members in SiStripHitEffFromCalibTree
• 8307e38 : direct initialization of subdetfound and subdettotal

PR validation:

cmssw compiles

The following command:

cmsDriver.py stepHarvest -s ALCAHARVEST:SiStripHitEff --conditions 124X_dataRun3_Express_v9 --scenario pp --data --era Run3 --dasquery='file dataset=/StreamExpress/Run2022G-PromptCalibProdSiStripHitEff-Express-v1/ALCAPROMPT run=362437' -n -1 --customise_commands='process.alcasiStripHitEfficiencyHarvester.isAtPCL = cms.bool (False)'

runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Combined backport of #41065, #41050, #40963: needed for 2023 data-taking.

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_0_X.

It involves the following packages:

• CalibTracker/SiStripHitEfficiency (alca)

@cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks.
@echabert, @mmusich, @robervalwalsh, @gbenelli, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from More refined error treatment in trend of efficiency vs lumi, PU and BX in SiStripHitEfficiencyHarvester #41065

[mmusich]

test parameters:

• workflows = 1001.2, 1001.3

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-713285/31505/summary.html
COMMIT: 8307e38
CMSSW: CMSSW_13_0_X_2023-03-21-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41126/31505/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 22 lines from the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3565983
• DQMHistoTests: Total failures: 47
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3565914
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 922.729 KiB( 50 files compared)
• DQMHistoSizes: changed ( 1001.0 ): 922.729 KiB AlCaReco/SiStripHitEfficiency
• Checked 224 log files, 166 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[tvami]

urgent

• needed for data taking

[francescobrivio]

@cms-sw/orp-l2 let's try to include this in the upcoming CMSSW_13_0_1 if possible

Cheers,
Francesco as ORM

[perrotta]

+1