More refined error treatment in trend of efficiency vs lumi, PU and BX in SiStripHitEfficiencyHarvester

[mmusich]

PR description:

This is a quick follow-up to #41050 introducing a more refined error treatment in trend of efficiency vs lumi, PU and BX in SiStripHitEfficiencyHarvester, using Clopper-Pearson confidence interval instead of naive binomial errors.
I profit of this PR to address a couple of comments leftover in #41050:

• use uniform convention for data-members in SiStripHitEffFromCalibTree
• direct initialization of subdetfound and subdettotal

PR validation:

Run successfully:

cmsDriver.py stepHarvest -s ALCAHARVEST:SiStripHitEff --conditions 124X_dataRun3_Express_v9 --scenario pp --data --era Run3 --dasquery='file dataset=/StreamExpress/Run2022G-PromptCalibProdSiStripHitEff-Express-v1/ALCAPROMPT run=362437' -n -1 --customise_commands='process.alcasiStripHitEfficiencyHarvester.isAtPCL = cms.bool (False)'

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but to be backported together with #41050 in 13.0.X

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41065/34666

• This PR adds an extra 40KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• CalibTracker/SiStripHitEfficiency (alca)

@cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks.
@echabert, @mmusich, @robervalwalsh, @gbenelli, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[tvami]

@cmsbuild , please test workflow 1001.3

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e20fe4/31302/summary.html
COMMIT: a50bccd
CMSSW: CMSSW_13_1_X_2023-03-15-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41065/31302/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 10 lines to the logs
• Reco comparison results: 12 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3565630
• DQMHistoTests: Total failures: 51
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3565557
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 922.729 KiB( 49 files compared)
• DQMHistoSizes: changed ( 1001.0 ): 922.729 KiB AlCaReco/SiStripHitEfficiency
• Checked 217 log files, 165 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

• tests pass, changes in https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_13_1_X_2023-03-15-1100+e20fe4/56034/1001.0_RunMinBias2011A/AlCaReco_SiStripHitEfficiency.html are expected

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41065/34681

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #41065 was updated. @cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please check and sign again.

[perrotta]

@cmsbuild please test workflow 1001.3

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e20fe4/31322/summary.html
COMMIT: dee8ecb
CMSSW: CMSSW_13_1_X_2023-03-16-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41065/31322/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• You potentially added 5 lines to the logs
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3565693
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3565667
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 613.512 KiB( 49 files compared)
• DQMHistoSizes: changed ( 1001.0 ): 613.512 KiB AlCaReco/SiStripHitEfficiency
• Checked 217 log files, 165 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

• resign

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[perrotta]

merge

[perrotta]

ping bot