Clean-up in CalibTracker/SiStripHitEfficiency and add trend of efficiency vs lumi, PU and BX in SiStripHitEfficiencyHarvester

[mmusich]

PR description:

This PR offers some clean-up of the CalibTracker/SiStripHitEfficiency codes:

• apply CMS code rules in SiStripHitEffFromCalibTree
• remove unused methods
• range based loops in StripHitEffFromCalibTree

In addition I implement in SiStripHitEfficiencyHarvester a generic function for summary plots of efficiency trends per layer vs variable (PU, inst. lumi, bx number) in commit fba034e. This will show up directly in the GUI efficiency plots vs event quantities.

PR validation:

Run successfully the following command:

cmsDriver.py stepHarvest -s ALCAHARVEST:SiStripHitEff --conditions 124X_dataRun3_Express_v9 --scenario pp --data --era Run3 --dasquery='file dataset=/StreamExpress/Run2022G-PromptCalibProdSiStripHitEff-Express-v1/ALCAPROMPT run=362437' -n -1 --customise_commands='process.alcasiStripHitEfficiencyHarvester.isAtPCL = cms.bool (False)'

and obtained the following plots:

Vs PU	Vs Inst Lumi

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but will be backported to CMSSW_13_0_X for data-taking purposes.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41050/34622

• This PR adds an extra 52KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• CalibTracker/SiStripHitEfficiency (alca)

@cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks.
@echabert, @mmusich, @robervalwalsh, @gbenelli, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-45e8dc/31267/summary.html
COMMIT: fba034e
CMSSW: CMSSW_13_1_X_2023-03-13-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41050/31267/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 11 lines from the logs
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3550756
• DQMHistoTests: Total failures: 51
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3550683
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 309.217 KiB( 48 files compared)
• DQMHistoSizes: changed ( 1001.0 ): 309.217 KiB AlCaReco/SiStripHitEfficiency
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[tvami]

I see diffs in 1001.0, was that expected?

[mmusich]

see diffs in 1001.0, was that expected?

Yes, these would be due to the MEs I have added, see PR description

[tvami]

+alca

• PR according to description
• diffs in 1001.0 are expected

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

can we just set these equal to {0} here and remove lines 506-510?

[mmusich]

Well, maybe, but what's the benefit?

[rappoccio]

It's a bit cleaner.

[mmusich]

Since I had to touch the module again, I addressed this at a50bccd

[rappoccio]

+1