fix ASAN Segmentation failure & heap-buffer-overflow in unit test Alignment/OfflineValidation/GCPall

[mmusich]

resolves #41079

PR description:

Title says it all.

PR validation:

In CMSSW_13_1_X_2023-03-16-2300, scram b runtests_GCPall runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

[mmusich]

type bug-fix

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41080/34694

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• Alignment/OfflineValidation (alca)

@cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test for CMSSW_13_1_ASAN_X

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98740b/31361/summary.html
COMMIT: f3178b3
CMSSW: CMSSW_13_1_ASAN_X_2023-03-15-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41080/31361/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @smuzaffar [CORE] Cleanup USE_UNITTEST_DIR which is now enabled at project level #41070
• @smuzaffar [ALCA] Cleanup USE_UNITTEST_DIR which is now enabled at project level #41068
• @mmusich More refined error treatment in trend of efficiency vs lumi, PU and BX in SiStripHitEfficiencyHarvester #41065
• @smuzaffar [DB] Cleanup USE_UNITTEST_DIR which is now enabled at project level #41066
• @missirol remove duplicates from PhysicsTools/TensorFlow/test/BuildFile.xml #41037
• @mmusich Fix Phase-1 Barrel Pixel Inner / Outer ladders numbering in several monitoring tools #40989
• @Dr15Jones Make sure variables are preserved in ReggeGribovPartonMCInterface #40962
• @makortel Fix propagation of an earlier exception in Transformer #40879
• @nhduongvn Handle invalid entries in <data-access> of site-local-config.xml #40961
• @bsunanda Run3-alca239 Add a file which is used for phi-symmetry calibration using local runs of HCAL #40969

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98740b/31361/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98740b/31361/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test NewStreamerZSTD had ERRORS
---> test NewStreamerUNCOMPRESSED had ERRORS
---> test NewStreamerLZMA had ERRORS
---> test NewStreamerZLIB had ERRORS
and more ...

[mmusich]

OK, not enough

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41080/34700

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #41080 was updated. @cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please check and sign again.

[mmusich]

@cmsbuild, please test for CMSSW_13_1_ASAN_X

[mmusich]

test GCPall succeeded this time: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98740b/31371/unitTests/src/Alignment/OfflineValidation/test/GCPall/testing.log

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98740b/31371/summary.html
COMMIT: 920dcdb
CMSSW: CMSSW_13_1_ASAN_X_2023-03-15-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41080/31371/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @smuzaffar [CORE] Cleanup USE_UNITTEST_DIR which is now enabled at project level #41070
• @smuzaffar [ALCA] Cleanup USE_UNITTEST_DIR which is now enabled at project level #41068
• @mmusich More refined error treatment in trend of efficiency vs lumi, PU and BX in SiStripHitEfficiencyHarvester #41065
• @smuzaffar [DB] Cleanup USE_UNITTEST_DIR which is now enabled at project level #41066
• @missirol remove duplicates from PhysicsTools/TensorFlow/test/BuildFile.xml #41037
• @mmusich Fix Phase-1 Barrel Pixel Inner / Outer ladders numbering in several monitoring tools #40989
• @Dr15Jones Make sure variables are preserved in ReggeGribovPartonMCInterface #40962
• @makortel Fix propagation of an earlier exception in Transformer #40879
• @nhduongvn Handle invalid entries in <data-access> of site-local-config.xml #40961
• @bsunanda Run3-alca239 Add a file which is used for phi-symmetry calibration using local runs of HCAL #40969

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98740b/31371/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98740b/31371/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test NewStreamerUNCOMPRESSED had ERRORS
---> test NewStreamerLZMA had ERRORS
---> test NewStreamerZLIB had ERRORS
---> test TestIOPoolInputNoParentDictionary had ERRORS
and more ...

[mmusich]

@cmsbuild, please test

• for the regular variant

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98740b/31382/summary.html
COMMIT: 920dcdb
CMSSW: CMSSW_13_1_X_2023-03-17-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41080/31382/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 7 lines from the logs
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3550882
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3550856
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

• both ASAN and std CMSSW pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1