Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run3-alca239 Add a file which is used for phi-symmetry calibration using local runs of HCAL #40969

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Run3-alca239 Add a file which is used for phi-symmetry calibration using local runs of HCAL #40969

merged 1 commit into from
Mar 16, 2023

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Mar 7, 2023 •
edited
Loading

PR description:

Add a file which is used for phi-symmetry calibration using local runs of HCAL. Also. used in several DPG analysis codes. Strange that it was not in the repository for so long

PR validation:

The added chi file has been tested externally in the context of phi symmetry studies. Then use the runTheMatrix test workflows to see that it does not interfere with any of the existing workflow.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

@cmsbuild cmsbuild added this to the CMSSW_13_1_X milestone Mar 7, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40969/34469

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2023

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • Calibration/HcalAlCaRecoProducers (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented Mar 7, 2023

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-344755/31111/summary.html
COMMIT: d43a049
CMSSW: CMSSW_13_1_X_2023-03-06-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40969/31111/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 24 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3529727
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3529704
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Mar 7, 2023

Strange that it was not in the repository for so long
PR validation:
Use the runTheMatrix test workflows

@bsunanda this makes no sense, how can you use any runTheMatrix wf-s if this was not in the repo until so far? You'd need to add it to one of the tests as well. And please do that in this PR, dont open another one

@bsunanda
Copy link
Contributor Author

@tvami You are right. It was tested externally in the context of phi symmetry studies

@bsunanda
Copy link
Contributor Author

@tvami I have edited the main section. Please approve this PR

@tvami
Copy link
Contributor

tvami commented Mar 10, 2023

+alca

  • file not use in the main CMSSW, only in private codes
  • on the other hand it would be good to add a wf that actually makes this ALCARECO, and/or consumes it too

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta
perrotta reviewed Mar 10, 2023
View reviewed changes
Copy link
Contributor

@perrotta perrotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you are adding a new file, please make the configurations in it more clean, as suggested

Calibration/HcalAlCaRecoProducers/python/ALCARECOHcalCalPedestalLocal_cff.py Outdated
Comment on lines 51 to 57
hfrecoMBNZS = RecoLocalCalo.HcalRecProducers.hfsimplereco_cfi.hfsimplereco.clone()

hfrecoMBNZS.firstSample = 2 # Run 2 default before 2017
hfrecoMBNZS.samplesToAdd = 2
hfrecoMBNZS.digiLabel = 'hcalDigiAlCaMB'
hfrecoMBNZS.tsFromDB = cms.bool(False)
hfrecoMBNZS.dropZSmarkedPassed = cms.bool(False)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
hfrecoMBNZS = RecoLocalCalo.HcalRecProducers.hfsimplereco_cfi.hfsimplereco.clone()
hfrecoMBNZS.firstSample = 2 # Run 2 default before 2017
hfrecoMBNZS.samplesToAdd = 2
hfrecoMBNZS.digiLabel = 'hcalDigiAlCaMB'
hfrecoMBNZS.tsFromDB = cms.bool(False)
hfrecoMBNZS.dropZSmarkedPassed = cms.bool(False)
hfrecoMBNZS = RecoLocalCalo.HcalRecProducers.hfsimplereco_cfi.hfsimplereco.clone(
hfrecoMBNZS.firstSample = 2, # Run 2 default before 2017
hfrecoMBNZS.samplesToAdd = 2,
hfrecoMBNZS.digiLabel = 'hcalDigiAlCaMB',
hfrecoMBNZS.tsFromDB = False,
hfrecoMBNZS.dropZSmarkedPassed = False
)

Calibration/HcalAlCaRecoProducers/python/ALCARECOHcalCalPedestalLocal_cff.py Outdated
Comment on lines 42 to 48
horecoMBNZS = RecoLocalCalo.HcalRecProducers.hosimplereco_cfi.hosimplereco.clone()

horecoMBNZS.firstSample = 4
horecoMBNZS.samplesToAdd = 4
horecoMBNZS.digiLabel = 'hcalDigiAlCaMB'
horecoMBNZS.tsFromDB = cms.bool(False)
horecoMBNZS.dropZSmarkedPassed = cms.bool(False)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
horecoMBNZS = RecoLocalCalo.HcalRecProducers.hosimplereco_cfi.hosimplereco.clone()
horecoMBNZS.firstSample = 4
horecoMBNZS.samplesToAdd = 4
horecoMBNZS.digiLabel = 'hcalDigiAlCaMB'
horecoMBNZS.tsFromDB = cms.bool(False)
horecoMBNZS.dropZSmarkedPassed = cms.bool(False)
horecoMBNZS = RecoLocalCalo.HcalRecProducers.hosimplereco_cfi.hosimplereco.clone(
horecoMBNZS.firstSample = 4,
horecoMBNZS.samplesToAdd = 4,
horecoMBNZS.digiLabel = 'hcalDigiAlCaMB',
horecoMBNZS.tsFromDB = False,
horecoMBNZS.dropZSmarkedPassed = False
)

Calibration/HcalAlCaRecoProducers/python/ALCARECOHcalCalPedestalLocal_cff.py Outdated

import RecoLocalCalo.HcalRecProducers.HBHEPhase1Reconstructor_cfi
hbherecoMBNZS = RecoLocalCalo.HcalRecProducers.HBHEPhase1Reconstructor_cfi.hbheprereco.clone(
digiLabelQIE8 = cms.InputTag("hcalDigiAlCaMB"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove type specifications in this cloned configuration

Calibration/HcalAlCaRecoProducers/python/ALCARECOHcalCalPedestalLocal_cff.py Outdated

from Configuration.Eras.Modifier_run2_HCAL_2017_cff import run2_HCAL_2017
run2_HCAL_2017.toModify( hbherecoMBNZS,
processQIE11 = cms.bool(True),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
processQIE11 = cms.bool(True),
processQIE11 = True,

Calibration/HcalAlCaRecoProducers/python/ALCARECOHcalCalPedestalLocal_cff.py Outdated
run2_HCAL_2017.toModify( hbherecoMBNZS,
processQIE11 = cms.bool(True),
# temporarily disabled until RecoLocalCalo/HcalRecProducers/python/HBHEPhase1Reconstructor_cfi.py:flagParametersQIE11 is filled
# setNoiseFlagsQIE11 = cms.bool(True),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# setNoiseFlagsQIE11 = cms.bool(True),
# setNoiseFlagsQIE11 = True,

Calibration/HcalAlCaRecoProducers/python/ALCARECOHcalCalPedestalLocal_cff.py Outdated
# setNoiseFlagsQIE11 = cms.bool(True),
)
run2_HCAL_2017.toModify( hbherecoNoise,
processQIE11 = cms.bool(True),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
processQIE11 = cms.bool(True),
processQIE11 = True,

Calibration/HcalAlCaRecoProducers/python/ALCARECOHcalCalPedestalLocal_cff.py Outdated
run2_HCAL_2017.toModify( hbherecoNoise,
processQIE11 = cms.bool(True),
# temporarily disabled until RecoLocalCalo/HcalRecProducers/python/HBHEPhase1Reconstructor_cfi.py:flagParametersQIE11 is filled
# setNoiseFlagsQIE11 = cms.bool(True),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# setNoiseFlagsQIE11 = cms.bool(True),
# setNoiseFlagsQIE11 = True,

@perrotta
Copy link
Contributor

ping @bsunanda

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40969/34651

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

Pull request #40969 was updated. @tvami, @saumyaphor4252, @francescobrivio can you please check and sign again.

@tvami
Copy link
Contributor

tvami commented Mar 15, 2023

+alca

  • the file in this PR is not consumed in central CMSSW, tests are not testing it / wont be affected by it

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-344755/31291/summary.html
COMMIT: abb2904
CMSSW: CMSSW_13_1_X_2023-03-14-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40969/31291/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • You potentially removed 13 lines from the logs
  • Reco comparison results: 25 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3550756
  • DQMHistoTests: Total failures: 128
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3550606
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-344755/31295/summary.html
COMMIT: abb2904
CMSSW: CMSSW_13_1_X_2023-03-14-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40969/31295/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 23 lines from the logs
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3550756
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3550725
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 126e442 into cms-sw:master Mar 16, 2023
@cmsbuild cmsbuild mentioned this pull request Mar 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perrotta perrotta perrotta left review comments

Assignees
No one assigned
Labels
alca-approved code-checks-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_13_1_X
Development

Successfully merging this pull request may close these issues.
4 participants
@bsunanda @cmsbuild @tvami @perrotta