Fix propagation of an earlier exception in Transformer #40879

makortel · 2023-02-24T19:29:37Z

PR description:

This PR proposes a possible fix for #40868.

PR validation:

FWCore/Integration unit tests pass

cmsbuild · 2023-02-24T19:36:19Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40879/34349

This PR adds an extra 40KB to repository

cmsbuild · 2023-02-24T19:36:42Z

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

FWCore/Framework (core)
FWCore/Integration (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@missirol, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

makortel · 2023-02-24T19:39:06Z

@cmsbuild, please test

makortel · 2023-02-24T19:44:31Z

@Dr15Jones What do you think?

cmsbuild · 2023-02-24T22:20:28Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ebc98f/30893/summary.html
COMMIT: 3f397f0
CMSSW: CMSSW_13_1_X_2023-02-24-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40879/30893/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 6 lines from the logs
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3528955
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3528932
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 213 log files, 164 edm output root files, 49 DQM output files
TriggerResults: no differences found

Dr15Jones · 2023-02-28T19:40:43Z

FWCore/Integration/test/transformTest_cfg.py

@@ -27,6 +28,8 @@
 process.maxEvents.input = 4

 process.start = cms.EDProducer("IntProducer", ivalue = cms.int32(1))
+if args.exception:
+  process.start = cms.EDProducer("FailingProducer")


So the test failure is in what is consumed and not in the actual transform call its.

Right, basically from anywhere in the data dependence chain of the module registering the transformation call.

Dr15Jones · 2023-02-28T19:42:08Z

FWCore/Framework/src/ProductResolvers.cc

+    // products were actually produced and which not, because the
+    // transforming products are never produced by time of commit_()
+    // by construction.
+    if (edp) {


Should the putProduct call always get a null wrapper? Or does the later call also call putProduct?

The putProduct() call from Event::commit_()

cmssw/FWCore/Framework/src/Event.cc

Lines 170 to 175 in ff2213a

for (auto index : iShouldPut) {

auto resolver = p.getProductResolverByIndex(index);

if (not resolver->productResolved()) {

dynamic_cast<ProductPutterBase const*>(resolver)->putProduct(std::unique_ptr<WrapperBase>());

}

}

will always have a null wrapper. The Transformer itself calls putProduct() via EventPrincipal::put()

cmssw/FWCore/Framework/src/EventPrincipal.cc

Line 209 in ff2213a

dynamic_cast<ProductPutterBase const*>(phb)->putProduct(std::move(edp));

cmssw/FWCore/Framework/src/EventForTransformer.cc

Lines 22 to 26 in ff2213a

void EventForTransformer::put(ProductResolverIndex index,

std::unique_ptr<WrapperBase> edp,

BasicHandle const& iGetHandle) {

eventPrincipal_.put(index, std::move(edp), iGetHandle.provenance()->productProvenance()->parentageID());

}

Written that, I see now an alternative to customizing putProduct() that would be to customize (in some way) productResolved() to return true for Transformer. The productResolved() seems to be called only in {Event,LuminosityBlock,Run,ProcessBlock}::commit_(), but on a first thought "lying" in productResolved() sounds conceptually worse than leaving the status unaltered in putProduct().

makortel · 2023-03-13T09:17:42Z

I'm coming to the conclusion that this is the least bad (quick) way, and given the "plan" to revisit the transformation ability in a context of more general memory space handling, and revisiting the Event system internals to make them more flexible, I would not spend much more time with this fix now.

…ts lost in Transformer

makortel · 2023-03-13T17:14:37Z

Rebased to fix a conflict.

cmsbuild · 2023-03-13T17:22:15Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40879/34596

This PR adds an extra 20KB to repository

cmsbuild · 2023-03-13T17:22:42Z

Pull request #40879 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please check and sign again.

makortel · 2023-03-13T18:04:04Z

@cmsbuild, please test

cmsbuild · 2023-03-13T20:40:51Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ebc98f/31250/summary.html
COMMIT: b70e365
CMSSW: CMSSW_13_1_X_2023-03-13-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40879/31250/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 12 lines from the logs
Reco comparison results: 11 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3550756
DQMHistoTests: Total failures: 10
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3550724
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 213 log files, 164 edm output root files, 49 DQM output files
TriggerResults: no differences found

makortel · 2023-03-16T06:23:19Z

Another incarnation of #39803

makortel · 2023-03-16T06:23:31Z

+core

cmsbuild · 2023-03-16T06:23:39Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2023-03-16T07:49:15Z

+1

makortel mentioned this pull request Feb 24, 2023

Exceptions not propagated through Transformer #40868

Closed

cmsbuild added this to the CMSSW_13_1_X milestone Feb 24, 2023

cmsbuild added core-pending pending-signatures tests-pending orp-pending code-checks-pending labels Feb 24, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 24, 2023

cmsbuild added tests-started and removed tests-pending labels Feb 24, 2023

cmsbuild added tests-approved and removed tests-started labels Feb 24, 2023

Dr15Jones reviewed Feb 28, 2023

View reviewed changes

cmsbuild mentioned this pull request Mar 10, 2023

[CORE] Various fixes/improvements for unit test #41024

Merged

makortel added 2 commits March 13, 2023 18:06

Add tests that fail if an exception from earlier module in a chain ge…

756f5cb

…ts lost in Transformer

Fix propagation of earlier exception in Transformer

b70e365

makortel force-pushed the fixTransformerLostException branch from 3f397f0 to b70e365 Compare March 13, 2023 17:14

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Mar 13, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 13, 2023

cmsbuild added tests-started and removed tests-pending labels Mar 13, 2023

cmsbuild added tests-approved and removed tests-started labels Mar 13, 2023

cmsbuild added core-approved fully-signed and removed core-pending pending-signatures labels Mar 16, 2023

cmsbuild added orp-approved and removed orp-pending labels Mar 16, 2023

cmsbuild merged commit e1890c9 into cms-sw:master Mar 16, 2023

This was referenced Mar 17, 2023

Fix exceptions getting lost in a Transfomer EDProducer cms-sw/framework-team#507

Closed

[13_0_X] Fix propagation of an earlier exception in Transformer #41078

Merged

cmsbuild mentioned this pull request Mar 17, 2023

fix ASAN Segmentation failure & heap-buffer-overflow in unit test Alignment/OfflineValidation/GCPall #41080

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix propagation of an earlier exception in Transformer #40879

Fix propagation of an earlier exception in Transformer #40879

makortel commented Feb 24, 2023

cmsbuild commented Feb 24, 2023

cmsbuild commented Feb 24, 2023

makortel commented Feb 24, 2023

makortel commented Feb 24, 2023

cmsbuild commented Feb 24, 2023

Dr15Jones Feb 28, 2023

makortel Feb 28, 2023

Dr15Jones Feb 28, 2023

makortel Feb 28, 2023

makortel commented Mar 13, 2023

makortel commented Mar 13, 2023

cmsbuild commented Mar 13, 2023

cmsbuild commented Mar 13, 2023

makortel commented Mar 13, 2023

cmsbuild commented Mar 13, 2023

makortel commented Mar 16, 2023

makortel commented Mar 16, 2023

cmsbuild commented Mar 16, 2023

perrotta commented Mar 16, 2023

	for (auto index : iShouldPut) {
	auto resolver = p.getProductResolverByIndex(index);
	if (not resolver->productResolved()) {
	dynamic_cast<ProductPutterBase const*>(resolver)->putProduct(std::unique_ptr<WrapperBase>());
	}
	}

	void EventForTransformer::put(ProductResolverIndex index,
	std::unique_ptr<WrapperBase> edp,
	BasicHandle const& iGetHandle) {
	eventPrincipal_.put(index, std::move(edp), iGetHandle.provenance()->productProvenance()->parentageID());
	}

Fix propagation of an earlier exception in Transformer #40879

Fix propagation of an earlier exception in Transformer #40879

Conversation

makortel commented Feb 24, 2023

PR description:

PR validation:

cmsbuild commented Feb 24, 2023

cmsbuild commented Feb 24, 2023

makortel commented Feb 24, 2023

makortel commented Feb 24, 2023

cmsbuild commented Feb 24, 2023

Comparison Summary

Dr15Jones Feb 28, 2023

Choose a reason for hiding this comment

makortel Feb 28, 2023

Choose a reason for hiding this comment

Dr15Jones Feb 28, 2023

Choose a reason for hiding this comment

makortel Feb 28, 2023

Choose a reason for hiding this comment

makortel commented Mar 13, 2023

makortel commented Mar 13, 2023

cmsbuild commented Mar 13, 2023

cmsbuild commented Mar 13, 2023

makortel commented Mar 13, 2023

cmsbuild commented Mar 13, 2023

Comparison Summary

makortel commented Mar 16, 2023

makortel commented Mar 16, 2023

cmsbuild commented Mar 16, 2023

perrotta commented Mar 16, 2023