fix segmentation violation in SiStripHitEffFromCalibTree and SiStripHitResolFromCalibTree in ASAN_X

[mmusich]

resolves #37781

PR description:

The goal of this PR is to fix the SIGSEV issues observed in the master ASAN_X IBs:

• here for CalibTracker/SiStripHitEfficiency
• here for CalibTracker/SiStripHitResolution

PR validation:

Successfully run the package unit tests in CMSSW_13_1_ASAN_X_2023-03-03-2300 (el8_amd64_gcc11):

scram b runtests

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40963/34463

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• CalibTracker/SiStripHitEfficiency (alca)
• CalibTracker/SiStripHitResolution (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@echabert, @mmusich, @robervalwalsh, @gbenelli, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test for CMSSW_13_1_ASAN_X

[mmusich]

unit tests passed nicely already.

[mmusich]

@cmsbuild, please abort

• no point in testing further than the unit tests.

[mmusich]

@cmsbuild, please test

[cmsbuild]

-1

Failed Tests: RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5d9de0/31094/summary.html
COMMIT: fd13c2d
CMSSW: CMSSW_13_1_ASAN_X_2023-03-03-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40963/31094/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 5.15.1_TTbarFS/step1_TTbarFS.log
• 135.4135.4_ZEEFS_13/step1_ZEEFS_13.log
• 138.4138.4_PromptCollisions2021/step2_PromptCollisions2021.log

Expand to see more relval errors ...

• 138.5
• 136.7611
• 136.8311
• 136.88811
• 140.56
• 4.53
• 2018.1
• 158.01
• 136.731
• 136.793
• 136.874
• 1000.0
• 1001.0
• 1306.0
• 1330.0
• 139.001
• 13234.0
• 312.0
• 9.0
• 25.0
• 10042.0
• 13434.0
• 10024.0
• 10824.0
• 25202.0
• 11634.0
• 11634.914
• 11634.7
• 10224.0
• 12434.0
• 11634.911
• 20900.0
• 20896.0
• 11834.0
• 20834.0
• 20834.75
• 20834.76
• 250202.181
• 23234.0
• 21034.999

AddOn Tests

• fastsim

[fastsim:1] cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi  --conditions auto:run1_mc --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - elapsed time: 108 sec (ended on Mon Mar  6 18:35:31 2023) - exit: 256

• fastsim1

[fastsim1:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - elapsed time: 106 sec (ended on Mon Mar  6 18:35:30 2023) - exit: 256

• fastsim2

[fastsim2:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 : FAILED - elapsed time: 102 sec (ended on Mon Mar  6 18:35:30 2023) - exit: 256

Expand to see more addon errors ...

• pat1
• hlt_mc_Fake
• hlt_mc_Fake1
• hlt_mc_Fake2
• hlt_mc_GRun
• hlt_mc_HIon
• hlt_mc_PIon
• hlt_mc_PRef
• hlt_data_Fake
• hlt_data_Fake1
• hlt_data_Fake2
• hlt_data_GRun
• hlt_data_HIon
• hlt_data_PIon
• hlt_data_PRef

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5d9de0/31096/summary.html
COMMIT: fd13c2d
CMSSW: CMSSW_13_1_X_2023-03-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40963/31096/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 14 lines from the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3529727
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3529705
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[mmusich]

type bug-fix

[tvami]

+alca

• unit tests passed for ASAN, std CMSSW fully passed

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1