Updates to L1 tracking (improved use of stub bend etc.) #40335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Find best match (matches HLS for all barrel layers and some disks) * Fixed comment * Removed extra table init calls * code-format * Added descriptive comments
* add possibility to invent stubs * fix missing index in l1tstub * apply code format * updated function names and description,update invent l1tstub creation * apply code format * remove parameter from tracklet_cfi * change default invent option to true * code format
* Add disk cut tables * Removed debug lines * code-format * Fixed LUTs * Disk LUTs for MP * Initialize LUTs * Added comments to TrackletLUT.h * code-format
* Trying best cut values * Added header, clang-format
* fix for stubs with identical position but different bends. * Update L1FPGATrackProducer.cc
* Move module loop to setup * Import functions from trackerTFP * Ian's 2nd comment * Code-format Co-authored-by: Jack Li <[email protected]>
Fixed comment in code
* CalcBendCuts - Uses bend encoding to decode bend * Modified CalcBendCuts to be off by default, changed nzbinsPhiCorr to 1 by default * Added changed in TP LUT and set default nzbinsPhiCorr to 1 * Turned off CalcBendCuts and revised comments * PR Cleanup * More PR cleanup * Address PR comments * code-format
* kf bug fixes, f/w sync. * updated reduced dat files and channel assignment. * correct channel assignment. * reduced dat files deleted.
* These changes implements a LUT as function of the raidal projection in the disks to determine which r bins needs to be searched - and the finer position within the r bin * Added extra pipeline stage to match HLS * Ran code-format * Remove some hard-coded numbers * Fixed parentheses * code-format * Minor fixes to remove some hardcoded numbers * Run code-format Co-authored-by: Anders <[email protected]>
* Changes from Anders * code-formatted
* Changed DR so that tracks are only compared to each other if they're in the same overlapping rinv bin. * Added some comments * Changed parts of the code dealing with overlapbins to make it less complex. * Ran scram b -j 8 code-format and other such commands * Fixed line breaks from scram b -j8 code-format. * Fixed line breaks * Fixed line breaks * Deleted unused variables, made comments describing functions more explicit, and declared several things const to save CPU. * Added values that limit the number of tracks per bin and number of comparisons per bin based on firmware limitations. * Added variables that would allow cutting tracks after a set number of tracks is reached in each bin as well as limiting the number of tracks that are compared in eachbin. * Fixed the formatting of new values in Settings.h and PurgeDuplicate.cc * Fixed the formatting of new values in Settings.h and PurgeDuplicate.cc * Changed the way PurgeDuplicate.cc evaluates seedRank * To help rebase * Atownse2 calc bend cuts (#178) * CalcBendCuts - Uses bend encoding to decode bend * Modified CalcBendCuts to be off by default, changed nzbinsPhiCorr to 1 by default * Added changed in TP LUT and set default nzbinsPhiCorr to 1 * Turned off CalcBendCuts and revised comments * PR Cleanup * More PR cleanup * Address PR comments * code-format * Deleted git comments from rebase. * Added comments to better explain functions in Settings.h * Changed a vector size comparison for DR that would keep 1 more track per bin than allowed * Changed DR values to recover performance * Added a DR variable to the maxStep map Co-authored-by: Daniel Ally <[email protected]> Co-authored-by: Austin Townsend <[email protected]> readd data files as not yet in CMSSW release Create github_CI.yml Readd git CI code after branching from latest CMSSW relese bug fixes dummy tweak Make DR easier to understand update to python3 tweak tweak tweak tweak Switch to D88 geometry updated to geometry D88 migrate to D77 geom Switch to D88 geometry Update to new label names Update to new label names Switch to D88 geometry Allow use of D76 MC tweak Create README.md Update README.md Update README.md Update README.md DUMMY COMMIT BEFORE PR Removed CI and data files
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40335/33422
|
|
A new Pull Request was created by @tomalin (Ian Tomalin) for master. It involves the following packages:
@rekovic, @epalencia, @cmsbuild, @AdrianoDee, @srimanob, @cecilecaillol can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
-1 Failed Tests: RelVals RelVals-INPUT RelValsRelVals-INPUT |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40335/35905
|
|
Pull request #40335 was updated. @epalencia, @AdrianoDee, @srimanob, @cmsbuild, @aloeliger can you please check and sign again. |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98192e/33125/summary.html Comparison SummarySummary:
|
|
+l1
|
|
Is this PR waiting for anything else, or can it be merged now? |
|
@cms-sw/upgrade-l2 Do you have any comments for @tomalin? |
|
+upgrade |
cmsbuild
added
fully-signed
upgrade-approved
and removed
pending-signatures
upgrade-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
Tracking performance little changed.