Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New stub window tune #40326

Closed
wants to merge 41 commits into from
Closed

New stub window tune #40326

wants to merge 41 commits into from

Conversation

rgoldouz
Copy link
Contributor

Dear Experts,

We have developed a new stub window tune which leads to a lower rate keeping the same efficiencies for electron and muon track trigger reconstruction.
Our studies are documented in the following detector note: DN-20-005

Please let me know if you have any question.

Thanks,
Reza

bryates and others added 30 commits November 24, 2022 16:59
@bryates @tomalin
Find best MC match (cms-sw#174)
3a634da 
* Find best match (matches HLS for all barrel layers and some disks)

* Fixed comment

* Removed extra table init calls

* code-format

* Added descriptive comments
@sarafiorendi @tomalin
Add possibility to invent seeding stubs coordinates before DR (cms-sw…
295a73e 
…#170)

* add possibility to invent stubs

* fix missing index in l1tstub

* apply code format

* updated function names and description,update invent l1tstub creation

* apply code format

* remove parameter from tracklet_cfi

* change default invent option to true

* code format
@bryates @tomalin
MC/MP LUTs (cms-sw#176)
a2849c8 
* Add disk cut tables

* Removed debug lines

* code-format

* Fixed LUTs

* Disk LUTs for MP

* Initialize LUTs

* Added comments to TrackletLUT.h

* code-format
@bryates @tomalin
MP best match (cms-sw#180)
c7c8339 
* Trying best cut values

* Added header, clang-format
@tschuh @tomalin
fix for stubs with identical position but different bends. (cms-sw#183)
6392209 
* fix for stubs with identical position but different bends.

* Update L1FPGATrackProducer.cc
@Jingyan95 @tomalin
Move module loop to setup (cms-sw#175)
bff95fe 
* Move module loop to setup

* Import functions from trackerTFP

* Ian's 2nd comment

* Code-format

Co-authored-by: Jack Li <[email protected]>
@tomalin
Update FitTrack.cc
9e89897 
Fixed comment in code
@tomalin
Added option to print digi format (cms-sw#187)
a9a4fff
@atownse2 @tomalin
Atownse2 calc bend cuts (cms-sw#178)
e0a6507 
* CalcBendCuts - Uses bend encoding to decode bend

* Modified CalcBendCuts to be off by default, changed nzbinsPhiCorr to 1 by default

* Added changed in TP LUT and set default nzbinsPhiCorr to 1

* Turned off CalcBendCuts and revised comments

* PR Cleanup

* More PR cleanup

* Address PR comments

* code-format
@tschuh @tomalin
kf bug fixes, f/w sync. (cms-sw#188)
8b7574d 
* kf bug fixes, f/w sync.

* updated reduced dat files and channel assignment.

* correct channel assignment.

* reduced dat files deleted.
@bryates @aryd @tomalin
MP disk projection LUT (cms-sw#185)
ed50147 
* These changes implements a LUT as function of the raidal projection in the disks to determine which r bins needs to be searched - and the finer position within the r bin

* Added extra pipeline stage to match HLS

* Ran code-format

* Remove some hard-coded numbers

* Fixed parentheses

* code-format

* Minor fixes to remove some hardcoded numbers

* Run code-format

Co-authored-by: Anders <[email protected]>
@tomalin
Produce combined module MemPrint & LUT files for reduced project (cms…
4dc5a44 
…-sw#189)

* Changes from Anders

* code-formatted
@tschuh @tomalin
tiny fix of start_of_orbit_bit. (cms-sw#190)
03725db
@dally96 @atownse2 @tomalin
Duplicate Removal with overlapping rinv bins (cms-sw#181)
1c6d529 
* Changed DR so that tracks are only compared to each other if they're in the same overlapping rinv bin.

* Added some comments

* Changed parts of the code dealing with overlapbins to make it less complex.

* Ran scram b -j 8 code-format and other such commands

* Fixed line breaks from scram b -j8 code-format.

* Fixed line breaks

* Fixed line breaks

* Deleted unused variables, made comments describing functions more explicit, and declared several things const to save CPU.

* Added values that limit the number of tracks per bin and number of comparisons per bin based on firmware limitations.

* Added variables that would allow cutting tracks after a set number of tracks is reached in each bin as well as limiting the number of tracks that are compared in eachbin.

* Fixed the formatting of new values in Settings.h and PurgeDuplicate.cc

* Fixed the formatting of new values in Settings.h and PurgeDuplicate.cc

* Changed the way PurgeDuplicate.cc evaluates seedRank

* To help rebase

* Atownse2 calc bend cuts (cms-sw#178)

* CalcBendCuts - Uses bend encoding to decode bend

* Modified CalcBendCuts to be off by default, changed nzbinsPhiCorr to 1 by default

* Added changed in TP LUT and set default nzbinsPhiCorr to 1

* Turned off CalcBendCuts and revised comments

* PR Cleanup

* More PR cleanup

* Address PR comments

* code-format

* Deleted git comments from rebase.

* Added comments to better explain functions in Settings.h

* Changed a vector size comparison for DR that would keep 1 more track per bin than allowed

* Changed DR values to recover performance

* Added a DR variable to the maxStep map

Co-authored-by: Daniel Ally <[email protected]>
Co-authored-by: Austin Townsend <[email protected]>
@tomalin
readd data files as not yet in CMSSW release
92a351d
@tomalin
Create github_CI.yml
df5c08c
@tomalin
Readd git CI code after branching from latest CMSSW relese
1d3d30d
@tomalin
bug fixes
4e419b2
@tomalin
dummy
df5259d
@tomalin
tweak
0247263
@tomalin
Make DR easier to understand
9ab7a5e
@tomalin
update to python3
f586b57
@tomalin
tweak
22adf04
@tomalin
tweak
6eaa835
@tomalin
tweak
7f6ff0b
@tomalin
tweak
d3ffc47
@tomalin
Switch to D88 geometry
dfd926a
@tomalin
updated to geometry D88
acaaf7f
@tomalin
migrate to D77 geom
0efcd66
@tomalin
Switch to D88 geometry
2edacd7
@cmsbuild cmsbuild added this to the CMSSW_13_0_X milestone Dec 15, 2022
@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40326/33408

This was referenced Dec 15, 2022
Closed
Merged
@tomalin
Copy link
Contributor

tomalin commented Dec 15, 2022

PLEASE DO NOT MERGE THIS PR! It is not ready for central CMSSW (and contains an astonishingly large number of changed files).
--- Ian Tomalin (L1 track co-convener).

@rgoldouz rgoldouz closed this Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-rejected l1-pending new-package-pending orp-pending pending-signatures tests-pending upgrade-pending
Projects
None yet
Milestone
CMSSW_13_0_X
Development

Successfully merging this pull request may close these issues.
9 participants
@rgoldouz @cmsbuild @tomalin @bryates @sarafiorendi @tschuh @Jingyan95 @atownse2 @dally96