Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from triplet only tracks to all tracks, to avoid problems with tr... #175

Merged
merged 2 commits into from
Sep 10, 2013

Conversation

mandrenguyen
Copy link
Contributor

...acking particles (and b/c it makes more sense)

… tracking particles (and b/c it makes more sense)
@nclopezo
Copy link
Contributor

Hi,

I took CMSSW_7_0_X_2013-07-23-1400, pulled these changes and ran the unit tests and Relvals. All the tests passed.

@nclopezo
Copy link
Contributor

Hi,
I ran the tests again with the new commit and all tests passed.

}// end simhit loop
#endif

// This currently will always return false, since we can no loger use the sim hits to check for triplets. This would need to be fixed if we want to enable this feature, but it's not being used at the moment, since tripletSeedOnly is always set to False - Matt Nguyen, 24/7/2013
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is now a solution to get the SimHits, see pull request 203: #203. You can thus get the previous behavior back.

@ktf
Copy link
Contributor

ktf commented Aug 9, 2013

@mandrenguyen can you please look into this?

@mandrenguyen
Copy link
Contributor Author

It's fine as it is.
-Matt

On 8/9/13 1:42 PM, Giulio Eulisse wrote:

@mandrenguyen https://github.com/mandrenguyen can you please look
into this?


Reply to this email directly or view it on GitHub
#175 (comment).


Matthew Nguyen
Chargé de Recherche
LLR-École Polytechnique
91128 Palaiseau FRANCE

+33 1 69 33 55 65

@ktf
Copy link
Contributor

ktf commented Aug 9, 2013

Thanks. @thspeer can you please sign if it's ok for you?

@ghost ghost assigned thspeer Aug 9, 2013
@thspeer
Copy link
Contributor

thspeer commented Aug 22, 2013

Matt, I see no changes in DQM files in WF 140.0 . In which workflow and where should I see a difference ?

@mandrenguyen
Copy link
Contributor Author

Hi,
I'm on vacation until September 2nd.
Cheers,
-Matt

On 8/22/13 12:11 PM, thspeer wrote:

Matt, I see no changes in DQM files in WF 140.0 . In which workflow
and where should I see a difference ?


Reply to this email directly or view it on GitHub
#175 (comment).


Matthew Nguyen
Chargé de Recherche
LLR-École Polytechnique
91128 Palaiseau FRANCE

+33 1 69 33 55 65

@thspeer
Copy link
Contributor

thspeer commented Sep 10, 2013

+1
Tested 5c02aae in CMSSW_7_0_X_2013-08-19-0200-175
No difference seen in tests

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests.

ktf added a commit that referenced this pull request Sep 10, 2013
Switch from triplet only tracks to all tracks, to avoid problems with tr...
@ktf ktf merged commit a48a4b2 into cms-sw:CMSSW_7_0_X Sep 10, 2013
tahuang1991 pushed a commit to tahuang1991/cmssw that referenced this pull request Jun 25, 2014
nclopezo pushed a commit to nclopezo/cmssw that referenced this pull request Nov 21, 2014
ipapaver pushed a commit to ipapaver/cmssw that referenced this pull request Oct 24, 2017
update and fix cmgListChunksToResub script to also take into account …
tstreble pushed a commit to tstreble/cmssw that referenced this pull request Feb 9, 2018
Expand GEN level information and prototype tool to handle TC geometry related info
gpetruc pushed a commit to gpetruc/cmssw that referenced this pull request Jul 5, 2018
New b-regression and deepCSV for  80X Moriond17 datasets
bi-ran added a commit to bi-ran/cmssw that referenced this pull request Nov 28, 2018
protect against trying to read empty l1 info
enable l1 info in hltanalysis by default
bi-ran added a commit to bi-ran/cmssw that referenced this pull request Jan 24, 2019
protect against trying to read empty l1 info
enable l1 info in hltanalysis by default
slava77 pushed a commit to slava77/cmssw that referenced this pull request Oct 9, 2021
Add initial documentation for CMSSW integration
@mandrenguyen mandrenguyen deleted the tp_fix_HI branch March 4, 2022 10:12
emily-tsai11 pushed a commit to emily-tsai11/cmssw that referenced this pull request Nov 15, 2022
* Move module loop to setup

* Import functions from trackerTFP

* Ian's 2nd comment

* Code-format

Co-authored-by: Jack Li <[email protected]>
rgoldouz pushed a commit to rgoldouz/cmssw that referenced this pull request Dec 15, 2022
* Move module loop to setup

* Import functions from trackerTFP

* Ian's 2nd comment

* Code-format

Co-authored-by: Jack Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants