-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from triplet only tracks to all tracks, to avoid problems with tr... #175
Conversation
… tracking particles (and b/c it makes more sense)
Hi, I took CMSSW_7_0_X_2013-07-23-1400, pulled these changes and ran the unit tests and Relvals. All the tests passed. |
Hi, |
}// end simhit loop | ||
#endif | ||
|
||
// This currently will always return false, since we can no loger use the sim hits to check for triplets. This would need to be fixed if we want to enable this feature, but it's not being used at the moment, since tripletSeedOnly is always set to False - Matt Nguyen, 24/7/2013 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is now a solution to get the SimHits, see pull request 203: #203. You can thus get the previous behavior back.
@mandrenguyen can you please look into this? |
It's fine as it is. On 8/9/13 1:42 PM, Giulio Eulisse wrote:
Matthew Nguyen +33 1 69 33 55 65 |
Thanks. @thspeer can you please sign if it's ok for you? |
Matt, I see no changes in DQM files in WF 140.0 . In which workflow and where should I see a difference ? |
Hi, On 8/22/13 12:11 PM, thspeer wrote:
Matthew Nguyen +33 1 69 33 55 65 |
+1 |
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. |
Switch from triplet only tracks to all tracks, to avoid problems with tr...
remove more tao msg
Force test pull requests
update and fix cmgListChunksToResub script to also take into account …
Expand GEN level information and prototype tool to handle TC geometry related info
New b-regression and deepCSV for 80X Moriond17 datasets
protect against trying to read empty l1 info enable l1 info in hltanalysis by default
protect against trying to read empty l1 info enable l1 info in hltanalysis by default
Add initial documentation for CMSSW integration
* Move module loop to setup * Import functions from trackerTFP * Ian's 2nd comment * Code-format Co-authored-by: Jack Li <[email protected]>
* Move module loop to setup * Import functions from trackerTFP * Ian's 2nd comment * Code-format Co-authored-by: Jack Li <[email protected]>
...acking particles (and b/c it makes more sense)