Extended PhaseI Pixel Layers geometry scenario. #181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I took CMSSW_7_0_X_2013-07-25-0200, pulled these changes and ran the unit tests and Relvals. All the tests passed. |
|
Hi, I think it should be queued also for 61X_SLHCX, right? |
|
I would suggest a more meaningful name for this geometry. Perhaps Extended2017PlusFwdPixel (as it is presumably the postls1+phase 1 pixel+forward pixel extension (where as the Phase1 pixel is just the current geometry plus the tracker upgrade, which is more or less obsolete) and "Layers" is not meaningful to me. |
|
Ok, I'll close it for the moment. This geometry description is not ready as I understand. |
|
To be renamed when ready. |
|
There is no harm in including it in a development release, afaik.. For for fastsim, it is just a matter of having the reco geom which is basically there. The XML is sufficient. -----Original Message----- Ok, I'll close it for the moment. This geometry description is not ready as I understand. — |
ghost
assigned 
|
Ianna was there any follow up on this? |
nclopezo
pushed a commit
to nclopezo/cmssw
that referenced
this pull request
Nov 21, 2014
update watchers.yaml
gpetruc
added a commit
to gpetruc/cmssw
that referenced
this pull request
Dec 19, 2014
Heppy LeptonAnalyzer: updates and more sensible defaults:
jpata
pushed a commit
to jpata/cmssw
that referenced
this pull request
Sep 29, 2015
count status 2 b hadrons
mrcarver
pushed a commit
to mrcarver/cmssw
that referenced
this pull request
Mar 5, 2016
New quality definition, and code refactorin
ipapaver
pushed a commit
to ipapaver/cmssw
that referenced
this pull request
Oct 24, 2017
VG + TTbar1L powheg
mariadalfonso
added a commit
to mariadalfonso/cmssw
that referenced
this pull request
Dec 18, 2017
SRCR trainings for 2L
tstreble
pushed a commit
to tstreble/cmssw
that referenced
this pull request
Feb 16, 2018
Add clustering and calibration customization functions
mverzett
pushed a commit
to mverzett/cmssw
that referenced
this pull request
Jul 25, 2018
…based_94X NanoAOD PRs 177, 179, 180 rebased to current 94X master
rovere
pushed a commit
to rovere/cmssw
that referenced
this pull request
Oct 25, 2018
mandrenguyen
pushed a commit
to mandrenguyen/cmssw
that referenced
this pull request
Feb 13, 2019
…w#181) * class to write L1 object information using standard data types * do not run l1object by default
bi-ran
pushed a commit
to bi-ran/cmssw
that referenced
this pull request
Jun 14, 2019
…w#181) * class to write L1 object information using standard data types * do not run l1object by default
bi-ran
added a commit
to bi-ran/cmssw
that referenced
this pull request
Jun 20, 2019
…w#213) * class to write L1 object information using standard data types * do not run l1object by default backport of (cms-sw#181)
rgoldouz
pushed a commit
to rgoldouz/cmssw
that referenced
this pull request
Dec 15, 2022
* Changed DR so that tracks are only compared to each other if they're in the same overlapping rinv bin. * Added some comments * Changed parts of the code dealing with overlapbins to make it less complex. * Ran scram b -j 8 code-format and other such commands * Fixed line breaks from scram b -j8 code-format. * Fixed line breaks * Fixed line breaks * Deleted unused variables, made comments describing functions more explicit, and declared several things const to save CPU. * Added values that limit the number of tracks per bin and number of comparisons per bin based on firmware limitations. * Added variables that would allow cutting tracks after a set number of tracks is reached in each bin as well as limiting the number of tracks that are compared in eachbin. * Fixed the formatting of new values in Settings.h and PurgeDuplicate.cc * Fixed the formatting of new values in Settings.h and PurgeDuplicate.cc * Changed the way PurgeDuplicate.cc evaluates seedRank * To help rebase * Atownse2 calc bend cuts (cms-sw#178) * CalcBendCuts - Uses bend encoding to decode bend * Modified CalcBendCuts to be off by default, changed nzbinsPhiCorr to 1 by default * Added changed in TP LUT and set default nzbinsPhiCorr to 1 * Turned off CalcBendCuts and revised comments * PR Cleanup * More PR cleanup * Address PR comments * code-format * Deleted git comments from rebase. * Added comments to better explain functions in Settings.h * Changed a vector size comparison for DR that would keep 1 more track per bin than allowed * Changed DR values to recover performance * Added a DR variable to the maxStep map Co-authored-by: Daniel Ally <[email protected]> Co-authored-by: Austin Townsend <[email protected]>
cmsbuild
pushed a commit
that referenced
this pull request
Jun 20, 2023
* Changed DR so that tracks are only compared to each other if they're in the same overlapping rinv bin. * Added some comments * Changed parts of the code dealing with overlapbins to make it less complex. * Ran scram b -j 8 code-format and other such commands * Fixed line breaks from scram b -j8 code-format. * Fixed line breaks * Fixed line breaks * Deleted unused variables, made comments describing functions more explicit, and declared several things const to save CPU. * Added values that limit the number of tracks per bin and number of comparisons per bin based on firmware limitations. * Added variables that would allow cutting tracks after a set number of tracks is reached in each bin as well as limiting the number of tracks that are compared in eachbin. * Fixed the formatting of new values in Settings.h and PurgeDuplicate.cc * Fixed the formatting of new values in Settings.h and PurgeDuplicate.cc * Changed the way PurgeDuplicate.cc evaluates seedRank * To help rebase * Atownse2 calc bend cuts (#178) * CalcBendCuts - Uses bend encoding to decode bend * Modified CalcBendCuts to be off by default, changed nzbinsPhiCorr to 1 by default * Added changed in TP LUT and set default nzbinsPhiCorr to 1 * Turned off CalcBendCuts and revised comments * PR Cleanup * More PR cleanup * Address PR comments * code-format * Deleted git comments from rebase. * Added comments to better explain functions in Settings.h * Changed a vector size comparison for DR that would keep 1 more track per bin than allowed * Changed DR values to recover performance * Added a DR variable to the maxStep map Co-authored-by: Daniel Ally <[email protected]> Co-authored-by: Austin Townsend <[email protected]> readd data files as not yet in CMSSW release Create github_CI.yml Readd git CI code after branching from latest CMSSW relese bug fixes dummy tweak Make DR easier to understand update to python3 tweak tweak tweak tweak Switch to D88 geometry updated to geometry D88 migrate to D77 geom Switch to D88 geometry Update to new label names Update to new label names Switch to D88 geometry Allow use of D76 MC tweak Create README.md Update README.md Update README.md Update README.md DUMMY COMMIT BEFORE PR Removed CI and data files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: it should be taken to both 612_SLHC7 and 70x