Add possibility to invent seeding stubs coordinates before DR #170
Conversation
| bool isSeedingStub(int, int, int); | ||
| std::string l1tinfo(const L1TStub*, std::string); | ||
| std::pair<int, int> findLayerDisk(const Stub*); | ||
| std::vector<double> getInventedCoords(unsigned int, const Stub*, Tracklet*); |
There was a problem hiding this comment.
Add comments explaining what these two "invented" functions do.
| std::pair<int, int> findLayerDisk(const Stub*); | ||
| std::vector<double> getInventedCoords(unsigned int, const Stub*, Tracklet*); | ||
| std::vector<double> getInventedCoordsExtended(unsigned int, const Stub*, Tracklet*); | ||
| std::vector<const Stub*> seedStubCoordsFromTracklet(unsigned int, Tracklet*, std::vector<const Stub*>); |
There was a problem hiding this comment.
Add comment explaining what seedStubCoordsFromTracklet does. Also the name of this function is misleading. It doesn't return the coordinates. It returns the invented stubs.
| Stub* invent_stub_ptr = new Stub(*thisStub); | ||
| const L1TStub* L1stub = thisStub->l1tstub(); | ||
|
|
||
| L1TStub invent_L1stub(L1stub->DTClink(), |
There was a problem hiding this comment.
This seems a long-winded way to copy an L1TStub. Can't you just profit from L1TStub's default copy constructor and do:
L1TStub invent_L1TStub = L1stub;
invent_L1TStub.setCoords(x,y,z);
where you also need to add function L1TStub::setCoords(x,y,z);
| double stub_z_invent = inv_r_z_phi[1]; | ||
|
|
||
| Stub* invent_stub_ptr = new Stub(*thisStub); | ||
| const L1TStub* L1stub = thisStub->l1tstub(); |
There was a problem hiding this comment.
All variable names in CMSSW must start with a lower case letter.
| @@ -13,6 +13,7 @@ | |||
| asciiFileName = cms.untracked.string(""), | |||
| Extended = cms.bool(False), | |||
| Reduced = cms.bool(False), | |||
| InventStubs = cms.bool(False), | |||
There was a problem hiding this comment.
Is there a reason this parameter needs to be in Tracklet_cfi.py, and not just specified in Settings.h?
There was a problem hiding this comment.
yes so that it can be changed w/o compiling the code
There was a problem hiding this comment.
In that case, I suggest removing it from Tracklet_cfi.py. The same argument would apply to every other parameter in Settings.h. The problem with putting params in Tracklet_cfi.py is that the value specified in Settings.h is then ignored, which tends to confuse people. Ahd we won't change this parameter of yours very often.
(The use of Settings.h is ugly, and forced on us by the request of some members of L1TrkAlgo that the code can also run outside CMSSW. I hope we can move away from this in the Future emulation.)
|
I suggest setting inventStubs_=true, since whilst it is false, we are simulating an algo that we don't know how to implement in FW. |
* add possibility to invent stubs * fix missing index in l1tstub * apply code format * updated function names and description,update invent l1tstub creation * apply code format * remove parameter from tracklet_cfi * change default invent option to true * code format
PR description:
Include code to enable the setting of seeding stubs coordinates to those inferred from the tracklet trajectory, before the DR step.
Performance shown here