Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Produce combined module MemPrint & LUT files for reduced project #189

Merged
merged 2 commits into from
Nov 9, 2022

Conversation

tomalin
Copy link
Collaborator

@tomalin tomalin commented Nov 8, 2022

…uced project

PR description:

This PR has two fixes to produced the LUTs and MemPrint tar files for the reduced combined module configuration. There is a minor fix in VMRouterCM to protect agains not writing the AllStubs memory. (In the reduced configuration this memory is not written for L1 and L2 where the seeing is done.) This also write out all LUT files in the .dat format, i.e. HEX numbers. This simplifies the reading of the files in hdl.

PR validation:

Files were generated and tested by running the reduced combined module chain in HLS.

Copy link

@aryd aryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me.

Copy link

@bryates bryates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well. None of the changes undo my previous PR.

@tomalin tomalin merged commit 5e167c3 into L1TK-dev-12_5_0_pre2 Nov 9, 2022
tomalin added a commit that referenced this pull request Nov 24, 2022
@tomalin tomalin deleted the ReducedCombinedModuleFixes2 branch November 6, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants