-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and cleaning of BPH trigger DQM/RelVal code and plots #40125
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40125/33121
|
A new Pull Request was created by @vjmastra (Vincenzo) for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-066c3d/29290/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
@vjmastra I understood that this PR should have just removed unneeded commented out lines. |
Hi, the added plots are "resurrected" from some commented code. The histograms are trigger efficiencies for muons and dimuons wrt rapidity, which are useful as there are triggers that include selection with a cut in rapidity of the muon pair (rather than on the muons' pseudorapidity individually - monitored with already available plots) |
+1 |
PR description:
Update DQM and RelVal code for BPH Trigger plots to take into account new triggers (eg inclusive dimuon trigger HLT_DoubleMuon4_3_LowMass_v), few changes in path names and cleaning of empty plots and corresponding code
Code has been cleaned after discussion in #39768
Short report in STEAM meeting: https://indico.cern.ch/event/1180797/#17-b-physics-quarkonia-pag
PR validation:
Code has been tested following twiki in CMSSW 12_6_0_pre3 on a BuMixing RelVal file
Recent output file: https://cernbox.cern.ch/s/NdDOJBWrwBwznzT
Previous output file: /afs/cern.ch/user/v/vmastrap/public/bph-dqm-12_6_0_pre3/DQM_V0001_R000000001__Global__CMSSW_X_Y_Z__RECO.root
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Previously asking for backporting in 12_4 and 12_5,
but not needed anymore