Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated root to tip of branch v6-26-00-patches #8204

Closed
wants to merge 2 commits into from
Closed

Updated root to tip of branch v6-26-00-patches #8204

wants to merge 2 commits into from

Conversation

iarspider
Copy link
Contributor

No description provided.

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for branch IB/CMSSW_13_0_X/rootnext.

@smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5aaf4/29298/summary.html
COMMIT: abfc327
CMSSW: CMSSW_13_0_ROOT626_X_2022-11-27-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8204/29298/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

  File "/cvmfs/cms-ib.cern.ch/sw/x86_64/week1/el8_amd64_gcc10/cms/cmssw/CMSSW_13_0_ROOT626_X_2022-11-27-2300/src/FWCore/Utilities/scripts/edmCheckClassVersion", line 181, in 
    raise RuntimeError("failed to load library '"+options.library+"'")
RuntimeError: failed to load library 'libValidationHGCalValidation.so'
>> Checking EDM Class Version for src/Alignment/CocoaFit/src/classes_def.xml in libAlignmentCocoaFit.so
Suggestion: You can run 'scram build updateclassversion' to generate src/Validation/HGCalValidation/src/classes_def.xml.generated with updated ClassVersion
gmake: *** [tmp/el8_amd64_gcc10/edm_checks/libValidationHGCalValidation.so] Error 1
>> Checking EDM Class Version for src/Alignment/LaserAlignment/src/classes_def.xml in libAlignmentLaserAlignment.so
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libDataFormatsStdDictionaries.so
@@@@ ----> OK  EDM Class Transients 
>> Checking EDM Class Version for src/Calibration/HcalCalibAlgos/src/classes_def.xml in libCalibrationHcalCalibAlgos.so

@iarspider
Copy link
Contributor Author

test parameters:

  • full_cmssw = true

@cmsbuild
Copy link
Contributor

Pull request #8204 was updated.

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5aaf4/29306/summary.html
COMMIT: 80cdeff
CMSSW: CMSSW_13_0_ROOT626_X_2022-11-27-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8204/29306/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5aaf4/29306/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5aaf4/29306/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS
---> test TestIOPoolInputNoParentDictionary had ERRORS
---> test test_edmPickEvents had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 17011 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3417179
  • DQMHistoTests: Total failures: 43506
  • DQMHistoTests: Total nulls: 87
  • DQMHistoTests: Total successes: 3373564
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -803.7359999999998 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 18.477 KiB EcalBarrel/EBIntegrityTask
  • DQMHistoSizes: changed ( 1000.0,... ): 7.848 KiB EcalEndcap/EEIntegrityTask
  • DQMHistoSizes: changed ( 11634.0,... ): 189.412 KiB HLT/BPH
  • DQMHistoSizes: changed ( 11834.0 ): 1.430 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 20834.0,... ): -454.062 KiB MTD/ETL
  • DQMHistoSizes: changed ( 20834.0,... ): 2.552 KiB MTD/BTL
  • DQMHistoSizes: changed ( 20834.0,... ): 0.406 KiB EcalBarrel/EBIntegrityTask
  • DQMHistoSizes: changed ( 20834.0,... ): 0.266 KiB EcalEndcap/EEIntegrityTask
  • Checked 206 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 6 / 46 workflows

@iarspider
Copy link
Contributor Author

please test

@iarspider
Copy link
Contributor Author

test-edmpickevents and test-das-selected-lumis failed due to proxy parsing error. TestIOPoolInputNoParentDictionary failed with

no StreamerInfo found in <...>/DataFormatsTestObjects_xr_rdict.pcm therefore preventing schema evolution when reading this file. The file was produced with version 6.26/07 of ROOT.

@smuzaffar

@iarspider
Copy link
Contributor Author

@aandvalenzuela commented on previous PR to update root-patches:

TestIOPoolInputNoParentDictionary is expected due to version update.

@smuzaffar
Copy link
Contributor

looks good but we will hold on to updating it for now ( waiting for root6.26 validation)

@smuzaffar smuzaffar closed this Nov 29, 2022
@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5aaf4/29315/summary.html
COMMIT: 80cdeff
CMSSW: CMSSW_13_0_ROOT626_X_2022-11-28-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/8204/29315/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5aaf4/29315/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5aaf4/29315/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test TestIOPoolInputNoParentDictionary had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 16756 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3421159
  • DQMHistoTests: Total failures: 40947
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3380189
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.43 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 11834.0 ): 1.430 KiB SiStrip/MechanicalView
  • Checked 206 log files, 48 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 6 / 46 workflows

@iarspider iarspider deleted the root-update-v6-26-00-patches-20221128 branch February 12, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
externals-pending orp-pending pending-signatures tests-rejected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iarspider @cmsbuild @smuzaffar