MTD reconstruction: fix local cluster position and uncertainty determination

[fabiocos]

PR description:

A detailed explanation of the work behind this PR is given in https://indico.cern.ch/event/1223129/contributions/5145722/attachments/2553661/4399902/MTDDPG_clustering_20221125.pdf .

The FTLCluster object is updated, by replacing the so far unused y position of the cluster with the uncertainty on the x position, which is special for BTL since it has more information than that deriving from the mere pixel dimension.
The x position and uncertainty in BTL crystals can be measured from the time difference of the two SiPM better than assuming a flat distribution distributed along the crystal. This piece of information is now correctly propagated through the clustering algorithm until the end.
Also the fact that the uncertainty was based so far on a sigle pixel size, instead of propagating the uncertainty on a weighted average of pixels is now fixed.

PR validation:

Extensive checks were done using the test workflow 20903.0 (single muons with flat pT in the range [0.7,10] GeV).
The pull distribution in x has now a properly behaved shape, as shown in the presentation.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40146/33138

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

• DataFormats/FTLRecHit (upgrade, reconstruction)
• RecoLocalFastTime/FTLClusterizer (upgrade, reconstruction)
• RecoLocalFastTime/FTLCommonAlgos (upgrade, reconstruction)

@cmsbuild, @AdrianoDee, @srimanob, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@trtomei, @missirol, @beaucero, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test with #40143

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-710bc3/29241/summary.html
COMMIT: 6ece4c6
CMSSW: CMSSW_12_6_X_2022-11-24-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40146/29241/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 266 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3417179
• DQMHistoTests: Total failures: 1039
• DQMHistoTests: Total nulls: 87
• DQMHistoTests: Total successes: 3416031
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -2709.07 KiB( 47 files compared)
• DQMHistoSizes: changed ( 20834.0,... ): -454.062 KiB MTD/ETL
• DQMHistoSizes: changed ( 20834.0,... ): 2.552 KiB MTD/BTL
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 206 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40146/33166

• This PR adds an extra 28KB to repository

[cmsbuild]

Pull request #40146 was updated. @cmsbuild, @AdrianoDee, @srimanob, @mandrenguyen, @clacaputo can you please check and sign again.

[fabiocos]

please test with #40143

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-710bc3/29285/summary.html
COMMIT: b314558
CMSSW: CMSSW_13_0_X_2022-11-27-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40146/29285/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 258 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3417179
• DQMHistoTests: Total failures: 1028
• DQMHistoTests: Total nulls: 86
• DQMHistoTests: Total successes: 3416043
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -2709.0660000000003 KiB( 47 files compared)
• DQMHistoSizes: changed ( 20834.0,... ): -454.062 KiB MTD/ETL
• DQMHistoSizes: changed ( 20834.0,... ): 2.552 KiB MTD/BTL
• Checked 206 log files, 48 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+reconstruction
Comparisons show differences in line w/ expectation, mainly to 4D vertexing, track matching to the MTD and various timing related quantities.

[fabiocos]

@mandrenguyen as soon as #40103 is integrated so as to provide a reference, the most relevant changes in the local reconstruction should be evident, you may see the plots I have shown last Friday at the MTD DPG meeting (presentation linked in the description)

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1