-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MTD validation: update monitoring of reconstructed clusters #40143
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40143/33134
|
A new Pull Request was created by @fabiocos (Fabio Cossutti) for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@gsorrentino18 FYI |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fea080/29235/summary.html Comparison SummarySummary:
|
thanks to @gsorrentino18 for noticing it, of course it does not change any conclusion/result |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40143/33136
|
Pull request #40143 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fea080/29240/summary.html Comparison SummarySummary:
|
@cms-sw/dqm-l2 any comment or question? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
In order to support the validation of MTD cluster properties, which will be the topic of a next PR, several histograms so far optional and off by default are promoted as regular histograms to be monitored. At the same time, the large memory-consuming 2D occupancy plots are moved under the optional flag, since they are more useful for visual inspection in case of debugging than for quantitative comparisons.
PR validation:
The code runs smoothly on test wf. 20903.0 producing the desired output.