Update and cleaning of BPH trigger DQM/RelVal plots - backport to 12_5_X

[vjmastra]

PR description:

Update DQM and RelVal code for BPH Trigger plots to take into account new triggers (eg inclusive dimuon trigger HLT_DoubleMuon4_3_LowMass_v), few changes in path names and cleaning of empty plots

Short report in STEAM meeting: https://indico.cern.ch/event/1180797/#17-b-physics-quarkonia-pag

PR validation:

Code has been tested following twiki in CMSSW 12_6_0_pre3 on a BuMixing RelVal file

Output file: /afs/cern.ch/user/v/vmastrap/public/bph-dqm-12_6_0_pre3/DQM_V0001_R000000001__Global__CMSSW_X_Y_Z__RECO.root

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport to 12_4_X (and 12_5_X) to have plots in the offline DQM GUI (now using 12_4)

Backport from 12_6 of PR #39768: #39768
Backport to 12_4_X: #39979

[cmsbuild]

A new Pull Request was created by @vjmastra (Vincenzo) for CMSSW_12_5_X.

It involves the following packages:

• DQMOffline/Trigger (dqm)
• HLTriggerOffline/HeavyFlavor (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@mtosi, @Fedespring, @missirol, @HuguesBrun, @jhgoh, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Update and cleaning of BPH trigger DQM/RelVal plots #39768

[perrotta]

backport of #39768

[emanueleusai]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-68b53c/28851/summary.html
COMMIT: 0b33427
CMSSW: CMSSW_12_5_X_2022-11-07-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39980/28851/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3718263
• DQMHistoTests: Total failures: 32
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3718208
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -30748.002 KiB( 50 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): -5128.503 KiB HLT/BPH
• DQMHistoSizes: changed ( 139.001 ): 23.020 KiB HLT/BPH
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 216 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[emanueleusai]

+1

• HLT path update PR

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_6_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

@vjmastra @emanueleusai about the "cleaning" part of this PR: I see that large chunks of code have been just commented out, in separate but connected part of the code and configuration. I wouldn't really call it "cleaning", indeed...
Is there any reason why they need to stay there, even commented out? Wouldn't a real cleaning that removes all those parts, if not necessary, be more appropriate?
If they need instead to stay there, because they are expected to get resurrected any time soon, probably a cleaner way to do it is to add an additional configuration parameter that allows to switch them on and off when needed. Or at lease a few additional comment lines that explain to possible future maintainers of this code what those commented out lines are intended to, and what needs to be uncommented if they want to resurrect a given feature.
PS: I know that I already approved myself the master version of this PR; but evidently I missed this point. Please comment here, and if you think to really clean up the code and configurations, please make it in the master first, and then backport in this PR and in #39979

[emanueleusai]

@perrotta I agree the unused code should just be removed. @vjmastra can you clarify if the commented line are corresponding to the empty plots? if that's the case we should just remove them.

[vjmastra]

Dear @perrotta @emanueleusai
I apologize for the late reply
I agree with you that this is indeed not a cleaning from the code point of view, but it is in the sense that many (empty) plots have been removed
If you think it is the case, I can try to make a better and cleaner update of the code for what concerns the commit "remove empty RelVal plots"

[perrotta]

Dear @perrotta @emanueleusai I apologize for the late reply I agree with you that this is indeed not a cleaning from the code point of view, but it is in the sense that many (empty) plots have been removed If you think it is the case, I can try to make a better and cleaner update of the code for what concerns the commit "remove empty RelVal plots"

Yes, @vjmastra please do, starting from the master

[rappoccio]

At this point, is there any motivation to backport this to 12_5 since the datataking period is over? Should we leave it in the master branch alone?

[vjmastra]

Hi, I have created a new PR for the master (#40125)
I agree that backporting to 12_4 and 12_5 is no more needed - I added this piece of information in the new PR
Thanks

[rappoccio]

+1

I suppose there's no harm in putting this in for consistency, it's already ready to go.