Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and cleaning of BPH trigger DQM/RelVal plots - backport to 12_4_X #39979

Merged
merged 3 commits into from
Nov 28, 2022

Conversation

vjmastra
Copy link
Contributor

@vjmastra vjmastra commented Nov 3, 2022

PR description:

Update DQM and RelVal code for BPH Trigger plots to take into account new triggers (eg inclusive dimuon trigger HLT_DoubleMuon4_3_LowMass_v), few changes in path names and cleaning of empty plots

Short report in STEAM meeting: https://indico.cern.ch/event/1180797/#17-b-physics-quarkonia-pag

PR validation:

Code has been tested following twiki in CMSSW 12_6_0_pre3 on a BuMixing RelVal file

Output file: /afs/cern.ch/user/v/vmastrap/public/bph-dqm-12_6_0_pre3/DQM_V0001_R000000001__Global__CMSSW_X_Y_Z__RECO.root

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport to 12_4_X (and 12_5_X) to have plots in the offline DQM GUI (now using 12_4)

Backport from 12_6 of PR #39768: #39768
Backport to 12_5_X: #39980

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2022

A new Pull Request was created by @vjmastra (Vincenzo) for CMSSW_12_4_X.

It involves the following packages:

  • DQMOffline/Trigger (dqm)
  • HLTriggerOffline/HeavyFlavor (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@mtosi, @Fedespring, @missirol, @HuguesBrun, @jhgoh, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Nov 3, 2022

backport of #39768

@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2022

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fbfff2/28852/summary.html
COMMIT: 4a3b0d5
CMSSW: CMSSW_12_4_X_2022-11-07-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39979/28852/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3703530
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3703500
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -30763.496 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): -5130.717 KiB HLT/BPH
  • DQMHistoSizes: changed ( 139.001 ): 20.806 KiB HLT/BPH
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

please test

  • let's retest

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fbfff2/28981/summary.html
COMMIT: 4a3b0d5
CMSSW: CMSSW_12_4_X_2022-11-11-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39979/28981/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3703530
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3703506
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -30763.496 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): -5130.717 KiB HLT/BPH
  • DQMHistoSizes: changed ( 139.001 ): 20.806 KiB HLT/BPH
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

@emanueleusai
Copy link
Member

hold

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @emanueleusai
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@emanueleusai
Copy link
Member

unhold

  • questions solved. code cleanup (removing commented lines) will happen only in master.

@cmsbuild cmsbuild removed the hold label Nov 28, 2022
@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 264bba6 into cms-sw:CMSSW_12_4_X Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants